added validator for rjsf, hook form via standard schema

app/src/ui/components/form/json-schema/JsonSchemaForm.tsx

@@ -5,10 +5,10 @@ import { cloneDeep } from "lodash-es";
 import { forwardRef, useId, useImperativeHandle, useRef, useState } from "react";
 import { fields as Fields } from "./fields";
 import { templates as Templates } from "./templates";
-import { RJSFTypeboxValidator } from "./typebox/RJSFTypeboxValidator";
 import { widgets as Widgets } from "./widgets";
+import { JsonvTsValidator } from "./JsonvTsValidator";
 
-const validator = new RJSFTypeboxValidator();
+const validator = new JsonvTsValidator();
 
 // @todo: don't import FormProps, instead, copy it here instead of "any"
 export type JsonSchemaFormProps = any & {

app/src/ui/components/form/json-schema/JsonSchemaValidator.ts

@@ -1,121 +0,0 @@
-import { type OutputUnit, Validator } from "@cfworker/json-schema";
-import type {
-   CustomValidator,
-   ErrorSchema,
-   ErrorTransformer,
-   FormContextType,
-   RJSFSchema,
-   RJSFValidationError,
-   StrictRJSFSchema,
-   UiSchema,
-   ValidationData,
-   ValidatorType,
-} from "@rjsf/utils";
-import { toErrorSchema } from "@rjsf/utils";
-import { get } from "lodash-es";
-
-function removeUndefinedKeys(obj: any): any {
-   if (!obj) return obj;
-
-   if (typeof obj === "object") {
-      Object.keys(obj).forEach((key) => {
-         if (obj[key] === undefined) {
-            delete obj[key];
-         } else if (typeof obj[key] === "object") {
-            removeUndefinedKeys(obj[key]);
-         }
-      });
-   }
-
-   if (Array.isArray(obj)) {
-      return obj.filter((item) => item !== undefined);
-   }
-
-   return obj;
-}
-
-function onlyKeepMostSpecific(errors: OutputUnit[]) {
-   const mostSpecific = errors.filter((error) => {
-      return !errors.some((other) => {
-         return error !== other && other.instanceLocation.startsWith(error.instanceLocation);
-      });
-   });
-   return mostSpecific;
-}
-
-const debug = true;
-const validate = true;
-
-export class JsonSchemaValidator<
-   T = any,
-   S extends StrictRJSFSchema = RJSFSchema,
-   F extends FormContextType = any,
-> implements ValidatorType
-{
-   // @ts-ignore
-   rawValidation<Result extends OutputUnit = OutputUnit>(schema: S, formData?: T) {
-      if (!validate) return { errors: [], validationError: null };
-
-      debug && console.log("JsonSchemaValidator.rawValidation", schema, formData);
-      const validator = new Validator(schema as any);
-      const validation = validator.validate(removeUndefinedKeys(formData));
-      const specificErrors = onlyKeepMostSpecific(validation.errors);
-
-      return { errors: specificErrors, validationError: null as any };
-   }
-
-   validateFormData(
-      formData: T | undefined,
-      schema: S,
-      customValidate?: CustomValidator,
-      transformErrors?: ErrorTransformer,
-      uiSchema?: UiSchema,
-   ): ValidationData<T> {
-      if (!validate) return { errors: [], errorSchema: {} as any };
-
-      debug &&
-         console.log(
-            "JsonSchemaValidator.validateFormData",
-            formData,
-            schema,
-            customValidate,
-            transformErrors,
-            uiSchema,
-         );
-      const { errors } = this.rawValidation(schema, formData);
-      debug && console.log("errors", { errors });
-
-      const transformedErrors = errors
-         //.filter((error) => error.keyword !== "properties")
-         .map((error) => {
-            const schemaLocation = error.keywordLocation.replace(/^#\/?/, "").split("/").join(".");
-            const propertyError = get(schema, schemaLocation);
-            const errorText = `${error.error.replace(/\.$/, "")}${propertyError ? ` "${propertyError}"` : ""}`;
-            //console.log(error, schemaLocation, get(schema, schemaLocation));
-            return {
-               name: error.keyword,
-               message: errorText,
-               property: "." + error.instanceLocation.replace(/^#\/?/, "").split("/").join("."),
-               schemaPath: error.keywordLocation,
-               stack: error.error,
-            };
-         });
-      debug && console.log("transformed", transformedErrors);
-
-      return {
-         errors: transformedErrors,
-         errorSchema: toErrorSchema(transformedErrors),
-      } as any;
-   }
-
-   toErrorList(errorSchema?: ErrorSchema<T>, fieldPath?: string[]): RJSFValidationError[] {
-      debug && console.log("JsonSchemaValidator.toErrorList", errorSchema, fieldPath);
-      return [];
-   }
-
-   isValid(schema: S, formData: T | undefined, rootSchema: S): boolean {
-      if (!validate) return true;
-      debug && console.log("JsonSchemaValidator.isValid", schema, formData, rootSchema);
-      return this.rawValidation(schema, formData).errors.length === 0;
-   }
-}

app/src/ui/components/form/json-schema/JsonvTsValidator.ts

@@ -1,6 +1,4 @@
-import { Check } from "@sinclair/typebox/value";
-import { Errors } from "@sinclair/typebox/errors";
-import { FromSchema } from "./from-schema";
+import * as s from "jsonv-ts";
 
 import type {
    CustomValidator,
@@ -16,7 +14,7 @@ import { toErrorSchema } from "@rjsf/utils";
 
 const validate = true;
 
-export class RJSFTypeboxValidator<T = any, S extends StrictRJSFSchema = RJSFSchema>
+export class JsonvTsValidator<T = any, S extends StrictRJSFSchema = RJSFSchema>
    implements ValidatorType
 {
    // @ts-ignore
@@ -24,16 +22,16 @@ export class RJSFTypeboxValidator<T = any, S extends StrictRJSFSchema = RJSFSche
       if (!validate) {
          return { errors: [], validationError: null as any };
       }
-      const tbSchema = FromSchema(schema as unknown);
 
-      //console.log("--validation", tbSchema, formData);
+      const jsSchema = s.fromSchema(schema as any);
+      const result = jsSchema.validate(formData);
 
-      if (Check(tbSchema, formData)) {
+      if (result.valid) {
          return { errors: [], validationError: null as any };
       }
 
       return {
-         errors: [...Errors(tbSchema, formData)],
+         errors: result.errors,
          validationError: null as any,
       };
    }
@@ -48,14 +46,12 @@ export class RJSFTypeboxValidator<T = any, S extends StrictRJSFSchema = RJSFSche
       const { errors } = this.rawValidation(schema, formData);
 
       const transformedErrors = errors.map((error) => {
-         const schemaLocation = error.path.substring(1).split("/").join(".");
-
          return {
             name: "any",
-            message: error.message,
-            property: "." + schemaLocation,
-            schemaPath: error.path,
-            stack: error.message,
+            message: error.error,
+            property: "." + error.instanceLocation.substring(1).split("/").join("."),
+            schemaPath: error.instanceLocation,
+            stack: error.error,
          };
       });
 

app/src/ui/components/form/json-schema/typebox/from-schema.ts

@@ -1,299 +0,0 @@
-/*--------------------------------------------------------------------------
-
-@sinclair/typebox/prototypes
-
-The MIT License (MIT)
-
-Copyright (c) 2017-2024 Haydn Paterson (sinclair) <haydn.developer@gmail.com>
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
-
----------------------------------------------------------------------------*/
-
-import * as Type from "@sinclair/typebox";
-
-// ------------------------------------------------------------------
-// Schematics
-// ------------------------------------------------------------------
-const IsExact = (value: unknown, expect: unknown) => value === expect;
-const IsSValue = (value: unknown): value is SValue =>
-   Type.ValueGuard.IsString(value) ||
-   Type.ValueGuard.IsNumber(value) ||
-   Type.ValueGuard.IsBoolean(value);
-const IsSEnum = (value: unknown): value is SEnum =>
-   Type.ValueGuard.IsObject(value) &&
-   Type.ValueGuard.IsArray(value.enum) &&
-   value.enum.every((value) => IsSValue(value));
-const IsSAllOf = (value: unknown): value is SAllOf =>
-   Type.ValueGuard.IsObject(value) && Type.ValueGuard.IsArray(value.allOf);
-const IsSAnyOf = (value: unknown): value is SAnyOf =>
-   Type.ValueGuard.IsObject(value) && Type.ValueGuard.IsArray(value.anyOf);
-const IsSOneOf = (value: unknown): value is SOneOf =>
-   Type.ValueGuard.IsObject(value) && Type.ValueGuard.IsArray(value.oneOf);
-const IsSTuple = (value: unknown): value is STuple =>
-   Type.ValueGuard.IsObject(value) &&
-   IsExact(value.type, "array") &&
-   Type.ValueGuard.IsArray(value.items);
-const IsSArray = (value: unknown): value is SArray =>
-   Type.ValueGuard.IsObject(value) &&
-   IsExact(value.type, "array") &&
-   !Type.ValueGuard.IsArray(value.items) &&
-   Type.ValueGuard.IsObject(value.items);
-const IsSConst = (value: unknown): value is SConst =>
-   // biome-ignore lint: reason
-   Type.ValueGuard.IsObject(value) && Type.ValueGuard.IsObject(value["const"]);
-const IsSString = (value: unknown): value is SString =>
-   Type.ValueGuard.IsObject(value) && IsExact(value.type, "string");
-const IsSNumber = (value: unknown): value is SNumber =>
-   Type.ValueGuard.IsObject(value) && IsExact(value.type, "number");
-const IsSInteger = (value: unknown): value is SInteger =>
-   Type.ValueGuard.IsObject(value) && IsExact(value.type, "integer");
-const IsSBoolean = (value: unknown): value is SBoolean =>
-   Type.ValueGuard.IsObject(value) && IsExact(value.type, "boolean");
-const IsSNull = (value: unknown): value is SBoolean =>
-   Type.ValueGuard.IsObject(value) && IsExact(value.type, "null");
-const IsSProperties = (value: unknown): value is SProperties => Type.ValueGuard.IsObject(value);
-// prettier-ignore
-// biome-ignore format:
-const IsSObject = (value: unknown): value is SObject => Type.ValueGuard.IsObject(value) && IsExact(value.type, 'object') && IsSProperties(value.properties) && (value.required === undefined || Type.ValueGuard.IsArray(value.required) && value.required.every((value: unknown) => Type.ValueGuard.IsString(value)))
-type SValue = string | number | boolean;
-type SEnum = Readonly<{ enum: readonly SValue[] }>;
-type SAllOf = Readonly<{ allOf: readonly unknown[] }>;
-type SAnyOf = Readonly<{ anyOf: readonly unknown[] }>;
-type SOneOf = Readonly<{ oneOf: readonly unknown[] }>;
-type SProperties = Record<PropertyKey, unknown>;
-type SObject = Readonly<{
-   type: "object";
-   properties: SProperties;
-   required?: readonly string[];
-}>;
-type STuple = Readonly<{ type: "array"; items: readonly unknown[] }>;
-type SArray = Readonly<{ type: "array"; items: unknown }>;
-type SConst = Readonly<{ const: SValue }>;
-type SString = Readonly<{ type: "string" }>;
-type SNumber = Readonly<{ type: "number" }>;
-type SInteger = Readonly<{ type: "integer" }>;
-type SBoolean = Readonly<{ type: "boolean" }>;
-type SNull = Readonly<{ type: "null" }>;
-// ------------------------------------------------------------------
-// FromRest
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromRest<T extends readonly unknown[], Acc extends Type.TSchema[] = []> = (
-  // biome-ignore lint: reason
-  T extends readonly [infer L extends unknown, ...infer R extends unknown[]]
-    ? TFromSchema<L> extends infer S extends Type.TSchema
-      ? TFromRest<R, [...Acc, S]>
-      : TFromRest<R, [...Acc]>
-    : Acc
-)
-function FromRest<T extends readonly unknown[]>(T: T): TFromRest<T> {
-   return T.map((L) => FromSchema(L)) as never;
-}
-// ------------------------------------------------------------------
-// FromEnumRest
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromEnumRest<T extends readonly SValue[], Acc extends Type.TSchema[] = []> = (
-  T extends readonly [infer L extends SValue, ...infer R extends SValue[]]
-    ? TFromEnumRest<R, [...Acc, Type.TLiteral<L>]>
-    : Acc
-)
-function FromEnumRest<T extends readonly SValue[]>(T: T): TFromEnumRest<T> {
-   return T.map((L) => Type.Literal(L)) as never;
-}
-// ------------------------------------------------------------------
-// AllOf
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromAllOf<T extends SAllOf> = (
-  TFromRest<T['allOf']> extends infer Rest extends Type.TSchema[]
-    ? Type.TIntersectEvaluated<Rest>
-    : Type.TNever
-)
-function FromAllOf<T extends SAllOf>(T: T): TFromAllOf<T> {
-   return Type.IntersectEvaluated(FromRest(T.allOf), T);
-}
-// ------------------------------------------------------------------
-// AnyOf
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromAnyOf<T extends SAnyOf> = (
-  TFromRest<T['anyOf']> extends infer Rest extends Type.TSchema[]
-    ? Type.TUnionEvaluated<Rest>
-    : Type.TNever
-)
-function FromAnyOf<T extends SAnyOf>(T: T): TFromAnyOf<T> {
-   return Type.UnionEvaluated(FromRest(T.anyOf), T);
-}
-// ------------------------------------------------------------------
-// OneOf
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromOneOf<T extends SOneOf> = (
-  TFromRest<T['oneOf']> extends infer Rest extends Type.TSchema[]
-    ? Type.TUnionEvaluated<Rest>
-    : Type.TNever
-)
-function FromOneOf<T extends SOneOf>(T: T): TFromOneOf<T> {
-   return Type.UnionEvaluated(FromRest(T.oneOf), T);
-}
-// ------------------------------------------------------------------
-// Enum
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromEnum<T extends SEnum> = (
-  TFromEnumRest<T['enum']> extends infer Elements extends Type.TSchema[]
-    ? Type.TUnionEvaluated<Elements>
-    : Type.TNever
-)
-function FromEnum<T extends SEnum>(T: T): TFromEnum<T> {
-   return Type.UnionEvaluated(FromEnumRest(T.enum));
-}
-// ------------------------------------------------------------------
-// Tuple
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromTuple<T extends STuple> = (
-  TFromRest<T['items']> extends infer Elements extends Type.TSchema[]
-    ? Type.TTuple<Elements>
-    : Type.TTuple<[]>
-)
-// prettier-ignore
-// biome-ignore format:
-function FromTuple<T extends STuple>(T: T): TFromTuple<T> {
-  return Type.Tuple(FromRest(T.items), T) as never
-}
-// ------------------------------------------------------------------
-// Array
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromArray<T extends SArray> = (
-  TFromSchema<T['items']> extends infer Items extends Type.TSchema
-    ? Type.TArray<Items>
-    : Type.TArray<Type.TUnknown>
-)
-// prettier-ignore
-// biome-ignore format:
-function FromArray<T extends SArray>(T: T): TFromArray<T> {
-  return Type.Array(FromSchema(T.items), T) as never
-}
-// ------------------------------------------------------------------
-// Const
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-type TFromConst<T extends SConst> = (
-  Type.Ensure<Type.TLiteral<T['const']>>
-)
-function FromConst<T extends SConst>(T: T) {
-   return Type.Literal(T.const, T);
-}
-// ------------------------------------------------------------------
-// Object
-// ------------------------------------------------------------------
-type TFromPropertiesIsOptional<
-   K extends PropertyKey,
-   R extends string | unknown,
-> = unknown extends R ? true : K extends R ? false : true;
-// prettier-ignore
-// biome-ignore format:
-type TFromProperties<T extends SProperties, R extends string | unknown> = Type.Evaluate<{
-  -readonly [K in keyof T]: TFromPropertiesIsOptional<K, R> extends true
-    ? Type.TOptional<TFromSchema<T[K]>>
-    : TFromSchema<T[K]>
-}>
-// prettier-ignore
-// biome-ignore format:
-type TFromObject<T extends SObject> = (
-  TFromProperties<T['properties'], Exclude<T['required'], undefined>[number]> extends infer Properties extends Type.TProperties
-    ? Type.TObject<Properties>
-    : Type.TObject<{}>
-)
-function FromObject<T extends SObject>(T: T): TFromObject<T> {
-   const properties = globalThis.Object.getOwnPropertyNames(T.properties).reduce((Acc, K) => {
-      return {
-         // biome-ignore lint:
-         ...Acc,
-         [K]:
-            // biome-ignore lint: reason
-            T.required && T.required.includes(K)
-               ? FromSchema(T.properties[K])
-               : Type.Optional(FromSchema(T.properties[K])),
-      };
-   }, {} as Type.TProperties);
-
-   if ("additionalProperties" in T) {
-      return Type.Object(properties, {
-         additionalProperties: FromSchema(T.additionalProperties),
-      }) as never;
-   }
-
-   return Type.Object(properties, T) as never;
-}
-// ------------------------------------------------------------------
-// FromSchema
-// ------------------------------------------------------------------
-// prettier-ignore
-// biome-ignore format:
-export type TFromSchema<T> = (
-  T extends SAllOf ? TFromAllOf<T> :
-  T extends SAnyOf ? TFromAnyOf<T> :
-  T extends SOneOf ? TFromOneOf<T> :
-  T extends SEnum ? TFromEnum<T> :
-  T extends SObject ? TFromObject<T> :
-  T extends STuple ? TFromTuple<T> :
-  T extends SArray ? TFromArray<T> :
-  T extends SConst ? TFromConst<T> :
-  T extends SString ? Type.TString :
-  T extends SNumber ? Type.TNumber :
-  T extends SInteger ? Type.TInteger :
-  T extends SBoolean ? Type.TBoolean :
-  T extends SNull ? Type.TNull :
-  Type.TUnknown
-)
-/** Parses a TypeBox type from raw JsonSchema */
-export function FromSchema<T>(T: T): TFromSchema<T> {
-   // prettier-ignore
-   // biome-ignore format:
-   return (
-    IsSAllOf(T) ? FromAllOf(T) :
-    IsSAnyOf(T) ? FromAnyOf(T) :
-    IsSOneOf(T) ? FromOneOf(T) :
-    IsSEnum(T) ? FromEnum(T) :
-    IsSObject(T) ? FromObject(T) :
-    IsSTuple(T) ? FromTuple(T) :
-    IsSArray(T) ? FromArray(T) :
-    IsSConst(T) ? FromConst(T) :
-    IsSString(T) ? Type.String(T) :
-    IsSNumber(T) ? Type.Number(T) :
-    IsSInteger(T) ? Type.Integer(T) :
-    IsSBoolean(T) ? Type.Boolean(T) :
-    IsSNull(T) ? Type.Null(T) :
-    Type.Unknown(T || {})
-  ) as never
-}