shishantbiswas/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(cli): fix TestTokens harder (#22684)

Browse Source 
`time.Now()` is greater than microsecond precision while timestamps we
store in Postgres are only microsecond precision. Flake potential is
non-zero.
This commit is contained in:
Cian Johnston
2026-03-06 00:04:09 +00:00
committed by GitHub
parent 9f6f4ba74d
commit 0b1e4880bd
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/tokens_test.go
+13 -2
View File
@@ -16,6 +16,7 @@ import (
"github.com/coder/coder/v2/coderd/coderdtest" "github.com/coder/coder/v2/coderd/coderdtest"
"github.com/coder/coder/v2/coderd/database" "github.com/coder/coder/v2/coderd/database"
"github.com/coder/coder/v2/coderd/database/dbgen" "github.com/coder/coder/v2/coderd/database/dbgen"
"github.com/coder/coder/v2/coderd/database/dbtime"
"github.com/coder/coder/v2/codersdk" "github.com/coder/coder/v2/codersdk"
"github.com/coder/coder/v2/testutil" "github.com/coder/coder/v2/testutil"
) )
@@ -184,12 +185,22 @@ func TestTokens(t *testing.T) {
clitest.SetupConfig(t, client, root) clitest.SetupConfig(t, client, root)
buf = new(bytes.Buffer) buf = new(bytes.Buffer)
inv.Stdout = buf inv.Stdout = buf
// Precondition: validate token is not expired before expiring
var expiredAtBefore time.Time
token, err := client.APIKeyByName(ctx, secondUser.ID.String(), "token-two")
require.NoError(t, err)
now := dbtime.Now()
require.True(t, token.ExpiresAt.After(now), "token should not be expired yet (expiresAt=%s, now=%s)", token.ExpiresAt.UTC(), now)
expiredAtBefore = token.ExpiresAt
err = inv.WithContext(ctx).Run() err = inv.WithContext(ctx).Run()
require.NoError(t, err) require.NoError(t, err)
// Validate that token was expired // Validate that token was expired
if token, err := client.APIKeyByName(ctx, secondUser.ID.String(), "token-two"); assert.NoError(t, err) { if token, err := client.APIKeyByName(ctx, secondUser.ID.String(), "token-two"); assert.NoError(t, err) {
now := time.Now() now := dbtime.Now()
require.False(t, token.ExpiresAt.After(now), "token expiresAt should not be in the future, but was %s (now=%s)", token.ExpiresAt, now) require.NotEqual(t, token.ExpiresAt, expiredAtBefore, "token expiresAt is the same as before expiring, but should have been updated")
require.False(t, token.ExpiresAt.After(now), "token expiresAt should not be in the future after expiring, but was %s (now=%s)", token.ExpiresAt.UTC(), now)
} }
// Delete by ID (explicit delete flag) // Delete by ID (explicit delete flag)