From 1adc22fffdd5e710f302466eb952af40961b5d77 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Sat, 14 Mar 2026 22:15:47 +0200 Subject: [PATCH] fix(agent/reaper): skip reaper tests in CI (#23068) ForkReap's syscall.ForkExec and process-directed signals remain flaky in CI despite the subprocess isolation added in #22894. Restore the testutil.InCI() skip guard that was removed in that change. Fixes coder/internal#1402 --- agent/reaper/reaper_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/agent/reaper/reaper_test.go b/agent/reaper/reaper_test.go index 2b5a44a21c..d044b4e85c 100644 --- a/agent/reaper/reaper_test.go +++ b/agent/reaper/reaper_test.go @@ -78,6 +78,9 @@ func withDone(t *testing.T) []reaper.Option { // processes and passes their PIDs through the shared channel. func TestReap(t *testing.T) { t.Parallel() + if testutil.InCI() { + t.Skip("Detected CI, skipping reaper tests") + } if !runSubprocess(t) { return } @@ -124,6 +127,9 @@ func TestReap(t *testing.T) { //nolint:tparallel // Subtests must be sequential, each starts its own reaper. func TestForkReapExitCodes(t *testing.T) { t.Parallel() + if testutil.InCI() { + t.Skip("Detected CI, skipping reaper tests") + } if !runSubprocess(t) { return } @@ -164,6 +170,9 @@ func TestForkReapExitCodes(t *testing.T) { // ensures SIGINT cannot kill the parent test binary. func TestReapInterrupt(t *testing.T) { t.Parallel() + if testutil.InCI() { + t.Skip("Detected CI, skipping reaper tests") + } if !runSubprocess(t) { return }