feat: smart file-based target selection for scripts/githooks (#23358)

Pre-commit classifies staged files and runs make pre-commit-light
when no Go, TypeScript, or Makefile changes are present. This
skips gen, lint/go, lint/ts, fmt/go, fmt/ts, and the binary
build. A markdown-only commit takes seconds instead of minutes.

Pre-push uses the same heuristic: if only light files changed
(docs, shell, terraform, etc.), tests are skipped entirely.
Falls back to the full make targets when Go/TS/Makefile changes
are detected, CODER_HOOK_RUN_ALL=1 is set, or the diff range
can't be determined.

Also adds test-storybook to make pre-push (vitest with the
storybook project in Playwright browser mode).
This commit is contained in:
Mathias Fredriksson
2026-03-20 17:05:44 +02:00
committed by GitHub
parent 03a1653324
commit 23542cb6af
4 changed files with 116 additions and 10 deletions
+21 -4
View File
@@ -1,9 +1,9 @@
#!/usr/bin/env bash
#
# Pre-commit hook that runs CI-equivalent checks locally.
# Runs `make pre-commit` (gen, fmt, lint, typos, build) which
# catches most CI failures without needing Docker or Playwright.
# Heavier checks (tests, site build) run via the pre-push hook.
# Classifies staged files by type and only runs relevant make
# targets. Falls back to the full `make pre-commit` when the
# Makefile changed or CODER_HOOK_RUN_ALL=1 is set.
#
# Installation (worktree-compatible):
#
@@ -20,4 +20,21 @@ unset GIT_DIR
if [[ "$(git rev-parse --git-dir)" != "$(git rev-parse --git-common-dir)" ]]; then
git config --worktree core.hooksPath scripts/githooks
fi
exec make pre-commit
if [[ ${CODER_HOOK_RUN_ALL:-} == 1 ]]; then
exec make pre-commit
fi
staged=$(git diff --cached --name-only --diff-filter=d)
if [[ -z $staged ]]; then
echo "pre-commit: no staged changes, skipping"
exit 0
fi
# If Go, TS, or build-system files changed, run the full
# pre-commit. Otherwise run the lightweight target that
# covers everything except gen, Go/TS fmt+lint, and binary build.
if echo "$staged" | grep -qE '\.(go|ts|tsx|sql|proto)$|^go\.(mod|sum)$|^site/|^Makefile$'; then
exec make pre-commit
fi
exec make pre-commit-light
+48 -1
View File
@@ -1,6 +1,11 @@
#!/usr/bin/env bash
#
# Pre-push hook that runs tests and builds the site locally.
# Classifies changed files (vs remote branch or merge-base)
# and only runs relevant test targets. Falls back to the full
# `make pre-push` when the Makefile changed, the diff range
# can't be determined, or CODER_HOOK_RUN_ALL=1 is set.
#
# The pre-commit hook handles gen, fmt, lint, typos, and build.
#
# Opt in/out without modifying this file:
@@ -32,6 +37,13 @@ if [[ "$(git rev-parse --git-dir)" != "$(git rev-parse --git-common-dir)" ]]; th
git config --worktree core.hooksPath scripts/githooks
fi
# Drain stdin before any early exits so git doesn't see a
# broken pipe. The push refs are used later for classification.
push_refs=()
while read -r local_ref local_oid remote_ref remote_oid; do
push_refs+=("$local_ref $local_oid $remote_ref $remote_oid")
done
# Explicit opt-in/opt-out via git config (overrides allowlist).
run=false
opt_in=$(git config --type=bool coder.pre-push 2>/dev/null || true)
@@ -55,7 +67,42 @@ fi
rc=0
if $run; then
make pre-push || rc=$?
if [[ ${CODER_HOOK_RUN_ALL:-} == 1 ]]; then
make pre-push || rc=$?
else
# Determine changed files from push refs.
zero="0000000000000000000000000000000000000000"
changed=""
fallback=false
for entry in "${push_refs[@]}"; do
read -r _local_ref local_oid _remote_ref remote_oid <<< "$entry"
if [[ $local_oid == "$zero" ]]; then
continue
fi
if [[ $remote_oid == "$zero" ]]; then
base=$(git merge-base "$local_oid" origin/main 2>/dev/null || true)
if [[ -z $base ]]; then
fallback=true
break
fi
else
base="$remote_oid"
fi
files=$(git diff --name-only "$base" "$local_oid" 2>/dev/null || true)
if [[ -n $files ]]; then
changed+=$'\n'"$files"
fi
done
if $fallback || [[ -z $changed ]]; then
make pre-push || rc=$?
elif echo "$changed" | grep -qE '\.(go|ts|tsx|sql|proto)$|^go\.(mod|sum)$|^site/|^Makefile$'; then
make pre-push || rc=$?
else
echo "pre-push: no Go/TS changes, skipping tests"
fi
fi
fi
# Hint is printed unconditionally so that AI agents that are not