From 2afd1a203e50def90b1bf1d7cc3e0181bad7e01a Mon Sep 17 00:00:00 2001 From: Dean Sheather Date: Tue, 24 Jun 2025 19:01:29 +1000 Subject: [PATCH] chore: disable devtunnel tests on windows (#18521) --- coderd/devtunnel/tunnel_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/coderd/devtunnel/tunnel_test.go b/coderd/devtunnel/tunnel_test.go index 50573c19e5..e8f526fed7 100644 --- a/coderd/devtunnel/tunnel_test.go +++ b/coderd/devtunnel/tunnel_test.go @@ -11,6 +11,7 @@ import ( "net/http" "net/http/httptest" "net/url" + "runtime" "strconv" "strings" "testing" @@ -33,6 +34,10 @@ import ( func TestTunnel(t *testing.T) { t.Parallel() + if runtime.GOOS == "windows" { + t.Skip("these tests are flaky on windows and cause the tests to fail with '(unknown)' and no output, see https://github.com/coder/internal/issues/579") + } + cases := []struct { name string version tunnelsdk.TunnelVersion @@ -173,6 +178,7 @@ func newTunnelServer(t *testing.T) *tunnelServer { srv := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { if handler != nil { handler.ServeHTTP(w, r) + return } w.WriteHeader(http.StatusBadGateway) @@ -207,6 +213,7 @@ func newTunnelServer(t *testing.T) *tunnelServer { if err == nil { break } + td = nil t.Logf("failed to create tunnel server on port %d: %s", wireguardPort, err) } if td == nil {