shishantbiswas/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent/x/agentdesktop): flaky TestPortableDesktop_StopRecording_WithThumbnail (#24671)

Browse Source 
Fixes https://github.com/coder/internal/issues/1462
This commit is contained in:
Hugo Dutka
2026-04-23 14:54:05 +02:00
committed by GitHub
parent 95386f526a
commit 397c9fb76a
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agent/x/agentdesktop/portabledesktop_internal_test.go
+6 -2
View File
@@ -636,7 +636,9 @@ func TestPortableDesktop_StopRecording_ReturnsArtifact(t *testing.T) {
logger := slogtest.Make(t, nil)
rec := &recordedExecer{
scripts: map[string]string{
"record": `trap 'exit 0' INT; sleep 120 & wait`,
// Use exec so SIGINT is delivered directly to sleep
// and the process exits immediately. (See coder/internal#1462.)
"record": `exec sleep 120`,
"up": `printf '{"vncPort":5901,"geometry":"1920x1080"}\n' && sleep 120`,
},
}
@@ -680,7 +682,9 @@ func TestPortableDesktop_StopRecording_WithThumbnail(t *testing.T) {
logger := slogtest.Make(t, nil)
rec := &recordedExecer{
scripts: map[string]string{
"record": `trap 'exit 0' INT; sleep 120 & wait`,
// See TestPortableDesktop_StopRecording_ReturnsArtifact
// for why we use exec instead of trap+wait.
"record": `exec sleep 120`,
"up": `printf '{"vncPort":5901,"geometry":"1920x1080"}\n' && sleep 120`,
},
}