From 5ae0e08494ec60abf1fd9bbf1322eebddde47bf3 Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Thu, 29 Jan 2026 15:03:58 +0200 Subject: [PATCH] chore: ensure consistent YAML names for aibridge flags (#21751) Closes https://github.com/coder/internal/issues/1205 _Implemented by Claude Opus 4.5_ Signed-off-by: Danny Kopping --- cli/testdata/server-config.yaml.golden | 16 ++++++++-------- codersdk/deployment.go | 16 ++++++++-------- docs/reference/cli/server.md | 8 ++++---- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/cli/testdata/server-config.yaml.golden b/cli/testdata/server-config.yaml.golden index e497206d09..d19549f6eb 100644 --- a/cli/testdata/server-config.yaml.golden +++ b/cli/testdata/server-config.yaml.golden @@ -775,15 +775,15 @@ aibridge: # Maximum number of concurrent AI Bridge requests per replica. Set to 0 to disable # (unlimited). # (default: 0, type: int) - maxConcurrency: 0 + max_concurrency: 0 # Maximum number of AI Bridge requests per second per replica. Set to 0 to disable # (unlimited). # (default: 0, type: int) - rateLimit: 0 + rate_limit: 0 # Emit structured logs for AI Bridge interception records. Use this for exporting # these records to external SIEM or observability systems. # (default: false, type: bool) - structuredLogging: false + structured_logging: false # Once enabled, extra headers will be added to upstream requests to identify the # user (actor) making requests to AI Bridge. This is only needed if you are using # a proxy between AI Bridge and an upstream AI provider. This will send @@ -794,20 +794,20 @@ aibridge: # Enable the circuit breaker to protect against cascading failures from upstream # AI provider rate limits (429, 503, 529 overloaded). # (default: false, type: bool) - circuitBreakerEnabled: false + circuit_breaker_enabled: false # Number of consecutive failures that triggers the circuit breaker to open. # (default: 5, type: int) - circuitBreakerFailureThreshold: 5 + circuit_breaker_failure_threshold: 5 # Cyclic period of the closed state for clearing internal failure counts. # (default: 10s, type: duration) - circuitBreakerInterval: 10s + circuit_breaker_interval: 10s # How long the circuit breaker stays open before transitioning to half-open state. # (default: 30s, type: duration) - circuitBreakerTimeout: 30s + circuit_breaker_timeout: 30s # Maximum number of requests allowed in half-open state before deciding to close # or re-open the circuit. # (default: 3, type: int) - circuitBreakerMaxRequests: 3 + circuit_breaker_max_requests: 3 aibridgeproxy: # Enable the AI Bridge MITM Proxy for intercepting and decrypting AI provider # requests. diff --git a/codersdk/deployment.go b/codersdk/deployment.go index cebddc7b4a..4dcecb58c7 100644 --- a/codersdk/deployment.go +++ b/codersdk/deployment.go @@ -3616,7 +3616,7 @@ Write out the current server config as YAML to stdout.`, Value: &c.AI.BridgeConfig.MaxConcurrency, Default: "0", Group: &deploymentGroupAIBridge, - YAML: "maxConcurrency", + YAML: "max_concurrency", }, { Name: "AI Bridge Rate Limit", @@ -3626,7 +3626,7 @@ Write out the current server config as YAML to stdout.`, Value: &c.AI.BridgeConfig.RateLimit, Default: "0", Group: &deploymentGroupAIBridge, - YAML: "rateLimit", + YAML: "rate_limit", }, { Name: "AI Bridge Structured Logging", @@ -3636,7 +3636,7 @@ Write out the current server config as YAML to stdout.`, Value: &c.AI.BridgeConfig.StructuredLogging, Default: "false", Group: &deploymentGroupAIBridge, - YAML: "structuredLogging", + YAML: "structured_logging", }, { Name: "AI Bridge Send Actor Headers", @@ -3658,7 +3658,7 @@ Write out the current server config as YAML to stdout.`, Value: &c.AI.BridgeConfig.CircuitBreakerEnabled, Default: "false", Group: &deploymentGroupAIBridge, - YAML: "circuitBreakerEnabled", + YAML: "circuit_breaker_enabled", }, { Name: "AI Bridge Circuit Breaker Failure Threshold", @@ -3674,7 +3674,7 @@ Write out the current server config as YAML to stdout.`, Default: "5", Hidden: true, Group: &deploymentGroupAIBridge, - YAML: "circuitBreakerFailureThreshold", + YAML: "circuit_breaker_failure_threshold", }, { Name: "AI Bridge Circuit Breaker Interval", @@ -3685,7 +3685,7 @@ Write out the current server config as YAML to stdout.`, Default: "10s", Hidden: true, Group: &deploymentGroupAIBridge, - YAML: "circuitBreakerInterval", + YAML: "circuit_breaker_interval", Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"), }, { @@ -3697,7 +3697,7 @@ Write out the current server config as YAML to stdout.`, Default: "30s", Hidden: true, Group: &deploymentGroupAIBridge, - YAML: "circuitBreakerTimeout", + YAML: "circuit_breaker_timeout", Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"), }, { @@ -3714,7 +3714,7 @@ Write out the current server config as YAML to stdout.`, Default: "3", Hidden: true, Group: &deploymentGroupAIBridge, - YAML: "circuitBreakerMaxRequests", + YAML: "circuit_breaker_max_requests", }, // AI Bridge Proxy Options diff --git a/docs/reference/cli/server.md b/docs/reference/cli/server.md index 8ee415b425..312a9887f1 100644 --- a/docs/reference/cli/server.md +++ b/docs/reference/cli/server.md @@ -1830,7 +1830,7 @@ Length of time to retain data such as interceptions and all related records (tok |-------------|----------------------------------------------| | Type | int | | Environment | $CODER_AIBRIDGE_MAX_CONCURRENCY | -| YAML | aibridge.maxConcurrency | +| YAML | aibridge.max_concurrency | | Default | 0 | Maximum number of concurrent AI Bridge requests per replica. Set to 0 to disable (unlimited). @@ -1841,7 +1841,7 @@ Maximum number of concurrent AI Bridge requests per replica. Set to 0 to disable |-------------|-----------------------------------------| | Type | int | | Environment | $CODER_AIBRIDGE_RATE_LIMIT | -| YAML | aibridge.rateLimit | +| YAML | aibridge.rate_limit | | Default | 0 | Maximum number of AI Bridge requests per second per replica. Set to 0 to disable (unlimited). @@ -1852,7 +1852,7 @@ Maximum number of AI Bridge requests per second per replica. Set to 0 to disable |-------------|-------------------------------------------------| | Type | bool | | Environment | $CODER_AIBRIDGE_STRUCTURED_LOGGING | -| YAML | aibridge.structuredLogging | +| YAML | aibridge.structured_logging | | Default | false | Emit structured logs for AI Bridge interception records. Use this for exporting these records to external SIEM or observability systems. @@ -1874,7 +1874,7 @@ Once enabled, extra headers will be added to upstream requests to identify the u |-------------|------------------------------------------------------| | Type | bool | | Environment | $CODER_AIBRIDGE_CIRCUIT_BREAKER_ENABLED | -| YAML | aibridge.circuitBreakerEnabled | +| YAML | aibridge.circuit_breaker_enabled | | Default | false | Enable the circuit breaker to protect against cascading failures from upstream AI provider rate limits (429, 503, 529 overloaded).