From 5c4d2c29dafaf26f2c3e25ee1c6a6f9fe88506f7 Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Thu, 21 May 2026 11:30:36 -0400 Subject: [PATCH] test: dont assert websocket closes without error (#25573) fixes https://github.com/coder/internal/issues/1541 Closing websockets can race whether they return an error or not if the remote side closes too. Dropping some test assertions about this since it is not critical to what we are testing. --- coderd/workspaceconnwatcher/watcher_test.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/coderd/workspaceconnwatcher/watcher_test.go b/coderd/workspaceconnwatcher/watcher_test.go index 0fdab4fed1..beeb6c2594 100644 --- a/coderd/workspaceconnwatcher/watcher_test.go +++ b/coderd/workspaceconnwatcher/watcher_test.go @@ -277,8 +277,7 @@ func TestWatcher_LostAccess(t *testing.T) { dec, err := h.Dial(ctx, "wss://local.test/") require.NoError(t, err) defer func() { - err := dec.Close() - require.NoError(t, err) + _ = dec.Close() }() events := dec.Chan() e0 := testutil.RequireReceive(ctx, t, events) @@ -312,8 +311,7 @@ func TestWatcher_PublishChanges(t *testing.T) { dec, err := h.Dial(ctx, "wss://local.test/") require.NoError(t, err) defer func() { - err := dec.Close() - require.NoError(t, err) + _ = dec.Close() }() events := dec.Chan()