mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
chore: refactor to directly create Client in Command Handlers (#19760)
Refactors the CLI to create the `*codersdk.Client` in the handlers. This is groundwork for changing the `rootCmd.InitClient()` to use the new `ClientOption`s. It also improves variable locality, scoping the Client to the handler. This makes misuse less likely and reduces the memory allocations to just the command being executed, rather than allocating a Client for every command regardless of whether it is executed.
This commit is contained in:
+4
-2
@@ -23,13 +23,11 @@ func (r *RootCmd) templatePull() *serpent.Command {
|
||||
orgContext = NewOrganizationContext()
|
||||
)
|
||||
|
||||
client := new(codersdk.Client)
|
||||
cmd := &serpent.Command{
|
||||
Use: "pull <name> [destination]",
|
||||
Short: "Download the active, latest, or specified version of a template to a path.",
|
||||
Middleware: serpent.Chain(
|
||||
serpent.RequireRangeArgs(1, 2),
|
||||
r.InitClient(client),
|
||||
),
|
||||
Handler: func(inv *serpent.Invocation) error {
|
||||
var (
|
||||
@@ -37,6 +35,10 @@ func (r *RootCmd) templatePull() *serpent.Command {
|
||||
templateName = inv.Args[0]
|
||||
dest string
|
||||
)
|
||||
client, err := r.InitClient(inv)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if len(inv.Args) > 1 {
|
||||
dest = inv.Args[1]
|
||||
|
||||
Reference in New Issue
Block a user