shishantbiswas/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(site/src/pages/AgentsPage): stabilize settings story (#25899)

Browse Source 
I ran into the `SettingsViewResets` Storybook flake twice on my branch.
The story reopens Agents settings immediately after clicking `Back to
Agents`, but the helper was synchronously checking for the desktop
`Settings` link before React Router had finished rendering `/agents`; on
desktop it could then fall through to the mobile-only `More options`
menu and fail.

Use `findByRole` for the desktop `Settings` link so the helper waits for
the accessible sidebar link before clicking it, matching the existing
Storybook interaction pattern used elsewhere in Agents stories.
This commit is contained in:
Ethan
2026-06-01 23:36:39 +10:00
committed by GitHub
parent f9937a8931
commit 644820cb28
1 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/pages/AgentsPage/AgentsPageView.stories.tsx
+1 -17
View File
@@ -936,23 +936,7 @@ export const WithErrorReasons: Story = {
const openSettingsView = async (canvasElement: HTMLElement) => { const openSettingsView = async (canvasElement: HTMLElement) => {
const canvas = within(canvasElement); const canvas = within(canvasElement);
const settingsLink = canvas.queryByRole("link", { name: "Settings" }); await userEvent.click(await canvas.findByRole("link", { name: "Settings" }));
if (settingsLink) {
await userEvent.click(settingsLink);
return;
}
const mobileMoreOptionsButton = canvas
.getAllByRole("button", { name: "More options" })
.find((button) => button.getAttribute("aria-haspopup") === "menu");
if (!mobileMoreOptionsButton) {
throw new Error("Expected a mobile More options menu button.");
}
await userEvent.click(mobileMoreOptionsButton);
const body = within(canvasElement.ownerDocument.body);
await userEvent.click(
await body.findByRole("menuitem", { name: "Settings" }),
);
}; };
export const OpensAnalyticsForAdmins: Story = { export const OpensAnalyticsForAdmins: Story = {