shishantbiswas/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: reduce re-registration interval to 5s to prevent replica staleness flapping (#24597)

Browse Source
This commit is contained in:
Jon Ayers
2026-04-24 15:56:22 -05:00
committed by GitHub
parent a497d934db
commit 6ac25c9ece
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
enterprise/wsproxy/wsproxysdk/wsproxysdk.go
+4 -1
View File
@@ -313,8 +313,11 @@ func (l *RegisterWorkspaceProxyLoop) register(ctx context.Context) (RegisterWork
// Start starts the proxy registration loop. The provided context is only used
// for the initial registration. Use Close() to stop.
func (l *RegisterWorkspaceProxyLoop) Start(ctx context.Context) (RegisterWorkspaceProxyResponse, error) {
// Workspace proxy re-registrations should be on the same interval as the rest of the replicasync.
// If they differ significantly it can cause problems with meshing.
if l.opts.Interval == 0 {
l.opts.Interval = 15 * time.Second
// Default to the same interval as the rest of the replicasync.
l.opts.Interval = 5 * time.Second
}
if l.opts.MaxFailureCount == 0 {
l.opts.MaxFailureCount = 10