From 8a47262fafa0bf13e9d3545aae0db60fed1b18ba Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Tue, 10 Oct 2023 15:45:47 +0400 Subject: [PATCH] fix: ignore logged errors in TestWorkspaceAgent/Timeout fixes #10167 Annoyingly, there isn't a good way to stop the publish from being sent on shutdown, and subscribing to them in the test is too fragile because empty messages are sent in a bunch of places, so we can't reliably tell it's regarding timeouts. --- coderd/workspaceagents_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/coderd/workspaceagents_test.go b/coderd/workspaceagents_test.go index 8575bd16ee..05ab10cad4 100644 --- a/coderd/workspaceagents_test.go +++ b/coderd/workspaceagents_test.go @@ -124,8 +124,11 @@ func TestWorkspaceAgent(t *testing.T) { }) t.Run("Timeout", func(t *testing.T) { t.Parallel() + // timeouts can cause error logs to be dropped on shutdown + logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug) client := coderdtest.New(t, &coderdtest.Options{ IncludeProvisionerDaemon: true, + Logger: &logger, }) user := coderdtest.CreateFirstUser(t, client) authToken := uuid.NewString()