diff --git a/coderd/agentapi/subagent_test.go b/coderd/agentapi/subagent_test.go index 2c5bc844f2..5fe78aa9c3 100644 --- a/coderd/agentapi/subagent_test.go +++ b/coderd/agentapi/subagent_test.go @@ -1320,7 +1320,6 @@ func TestSubAgentAPI(t *testing.T) { } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/coderd/aitasks_test.go b/coderd/aitasks_test.go index 7803ae1587..e841713ce8 100644 --- a/coderd/aitasks_test.go +++ b/coderd/aitasks_test.go @@ -2567,7 +2567,6 @@ func TestPauseTask(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.name, func(t *testing.T) { task, _ := setupWorkspaceTask(t, db, owner) userClient, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID, tc.roles...) diff --git a/coderd/database/migrations/migrate_test.go b/coderd/database/migrations/migrate_test.go index 7bab30c0d4..0260bbc10c 100644 --- a/coderd/database/migrations/migrate_test.go +++ b/coderd/database/migrations/migrate_test.go @@ -138,7 +138,6 @@ func TestCheckLatestVersion(t *testing.T) { } for i, tc := range tests { - i, tc := i, tc t.Run(fmt.Sprintf("entry %d", i), func(t *testing.T) { t.Parallel() diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go index 80431dbd23..e61f2f135a 100644 --- a/coderd/database/querier_test.go +++ b/coderd/database/querier_test.go @@ -6646,7 +6646,6 @@ func TestUserSecretsAuthorization(t *testing.T) { } for _, tc := range testCases { - tc := tc // capture range variable t.Run(tc.name, func(t *testing.T) { t.Parallel() ctx := testutil.Context(t, testutil.WaitMedium) @@ -7460,7 +7459,6 @@ func TestGetTaskByWorkspaceID(t *testing.T) { db, _ := dbtestutil.NewDB(t) for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -8000,7 +7998,6 @@ func TestUpdateTaskWorkspaceID(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/coderd/devtunnel/servers.go b/coderd/devtunnel/servers.go index 79be97db87..3d4e1a3229 100644 --- a/coderd/devtunnel/servers.go +++ b/coderd/devtunnel/servers.go @@ -86,7 +86,6 @@ func FindClosestNode(nodes []Node) (Node, error) { eg = errgroup.Group{} ) for i, node := range nodes { - i, node := i, node eg.Go(func() error { pinger, err := ping.NewPinger(node.HostnameHTTPS) if err != nil { diff --git a/coderd/httpmw/httpmw_internal_test.go b/coderd/httpmw/httpmw_internal_test.go index 7519fe770d..bf10f26551 100644 --- a/coderd/httpmw/httpmw_internal_test.go +++ b/coderd/httpmw/httpmw_internal_test.go @@ -106,7 +106,6 @@ func TestNormalizeAudienceURI(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() result := normalizeAudienceURI(tc.input) @@ -157,7 +156,6 @@ func TestNormalizeHost(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() result := normalizeHost(tc.input) @@ -203,7 +201,6 @@ func TestNormalizePathSegments(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() result := normalizePathSegments(tc.input) @@ -247,7 +244,6 @@ func TestExtractExpectedAudience(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() var req *http.Request diff --git a/coderd/oauth2provider/pkce_test.go b/coderd/oauth2provider/pkce_test.go index c854c87e62..da0ff3a9d2 100644 --- a/coderd/oauth2provider/pkce_test.go +++ b/coderd/oauth2provider/pkce_test.go @@ -53,7 +53,6 @@ func TestVerifyPKCE(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() result := oauth2provider.VerifyPKCE(tt.challenge, tt.verifier) diff --git a/coderd/oauth2provider/provider_test.go b/coderd/oauth2provider/provider_test.go index 8848a6ff18..2a95438dcc 100644 --- a/coderd/oauth2provider/provider_test.go +++ b/coderd/oauth2provider/provider_test.go @@ -217,7 +217,6 @@ func TestOAuth2ClientRegistrationValidation(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/coderd/prebuilds/parameters_test.go b/coderd/prebuilds/parameters_test.go index e9366bb1da..50352ca3b3 100644 --- a/coderd/prebuilds/parameters_test.go +++ b/coderd/prebuilds/parameters_test.go @@ -128,7 +128,6 @@ func TestFindMatchingPresetID(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/coderd/prebuilds/preset_snapshot_test.go b/coderd/prebuilds/preset_snapshot_test.go index 4e0c9add23..6cafb2475f 100644 --- a/coderd/prebuilds/preset_snapshot_test.go +++ b/coderd/prebuilds/preset_snapshot_test.go @@ -1193,7 +1193,6 @@ func TestMatchesCron(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1518,7 +1517,6 @@ func TestCalculateDesiredInstances(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() desiredInstances := tc.snapshot.CalculateDesiredInstances(tc.at) diff --git a/coderd/presets_test.go b/coderd/presets_test.go index 99472a0136..6ae2ea9b5b 100644 --- a/coderd/presets_test.go +++ b/coderd/presets_test.go @@ -190,7 +190,6 @@ func TestTemplateVersionPresetsDefault(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() ctx := testutil.Context(t, testutil.WaitShort) diff --git a/coderd/schedule/cron/cron_test.go b/coderd/schedule/cron/cron_test.go index 05e8ac21af..4c7312eb80 100644 --- a/coderd/schedule/cron/cron_test.go +++ b/coderd/schedule/cron/cron_test.go @@ -253,7 +253,6 @@ func TestIsWithinRange(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() sched, err := cron.Weekly(testCase.spec) diff --git a/coderd/workspaceagents_test.go b/coderd/workspaceagents_test.go index 00357b2bdd..3ce2389ef2 100644 --- a/coderd/workspaceagents_test.go +++ b/coderd/workspaceagents_test.go @@ -606,7 +606,6 @@ func TestWorkspaceAgentAppStatus_ActivityBump(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() @@ -1920,7 +1919,6 @@ func TestWorkspaceAgentDeleteDevcontainer(t *testing.T) { } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/codersdk/deployment_test.go b/codersdk/deployment_test.go index 38f0ecbdac..11f6734b3a 100644 --- a/codersdk/deployment_test.go +++ b/codersdk/deployment_test.go @@ -747,7 +747,6 @@ func TestRetentionConfigParsing(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() diff --git a/enterprise/cli/prebuilds_test.go b/enterprise/cli/prebuilds_test.go index c5b755c7fc..2ea0f6a895 100644 --- a/enterprise/cli/prebuilds_test.go +++ b/enterprise/cli/prebuilds_test.go @@ -390,7 +390,6 @@ func TestSchedulePrebuilds(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/enterprise/coderd/prebuilds/membership_test.go b/enterprise/coderd/prebuilds/membership_test.go index ed8a6adecd..d148db6fdc 100644 --- a/enterprise/coderd/prebuilds/membership_test.go +++ b/enterprise/coderd/prebuilds/membership_test.go @@ -60,14 +60,10 @@ func TestReconcileAll(t *testing.T) { } for _, tc := range tests { - tc := tc includePreset := tc.includePreset for _, preExistingOrgMembership := range tc.preExistingOrgMembership { - preExistingOrgMembership := preExistingOrgMembership for _, preExistingGroup := range tc.preExistingGroup { - preExistingGroup := preExistingGroup for _, preExistingGroupMembership := range tc.preExistingGroupMembership { - preExistingGroupMembership := preExistingGroupMembership t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/enterprise/coderd/schedule/template_test.go b/enterprise/coderd/schedule/template_test.go index 6c6a6c6a18..ab4a58f8cf 100644 --- a/enterprise/coderd/schedule/template_test.go +++ b/enterprise/coderd/schedule/template_test.go @@ -1268,7 +1268,6 @@ func TestTemplateUpdatePrebuilds(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/enterprise/coderd/workspaces_test.go b/enterprise/coderd/workspaces_test.go index 49d5694a5c..0172faf712 100644 --- a/enterprise/coderd/workspaces_test.go +++ b/enterprise/coderd/workspaces_test.go @@ -2750,7 +2750,6 @@ func TestPrebuildUpdateLifecycleParams(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/enterprise/wsproxy/wsproxy_test.go b/enterprise/wsproxy/wsproxy_test.go index 9e206a1cdc..3cb51e320c 100644 --- a/enterprise/wsproxy/wsproxy_test.go +++ b/enterprise/wsproxy/wsproxy_test.go @@ -525,7 +525,6 @@ func TestDERPMesh(t *testing.T) { require.Len(t, cases, (len(proxies)*(len(proxies)+1))/2) // triangle number for i, c := range cases { - i, c := i, c t.Run(fmt.Sprintf("Proxy%d", i), func(t *testing.T) { t.Parallel() diff --git a/provisioner/terraform/resources_test.go b/provisioner/terraform/resources_test.go index 1015b06606..b396c99af9 100644 --- a/provisioner/terraform/resources_test.go +++ b/provisioner/terraform/resources_test.go @@ -1472,7 +1472,6 @@ func TestDefaultPresets(t *testing.T) { } for name, tc := range cases { - tc := tc t.Run(name, func(t *testing.T) { t.Parallel() ctx, logger := ctxAndLogger(t) diff --git a/scaletest/agentconn/run.go b/scaletest/agentconn/run.go index 4375455c08..4a4587e478 100644 --- a/scaletest/agentconn/run.go +++ b/scaletest/agentconn/run.go @@ -297,7 +297,6 @@ func holdConnection(ctx context.Context, logs io.Writer, conn workspacesdk.Agent _, _ = fmt.Fprintln(logs, "\nStarting connection loops...") } for i, connSpec := range specs { - i, connSpec := i, connSpec if connSpec.Interval <= 0 { continue } diff --git a/scaletest/dynamicparameters/template_internal_test.go b/scaletest/dynamicparameters/template_internal_test.go index c43665e7b7..f58f91f271 100644 --- a/scaletest/dynamicparameters/template_internal_test.go +++ b/scaletest/dynamicparameters/template_internal_test.go @@ -46,7 +46,6 @@ func TestPartitionEvaluations(t *testing.T) { } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() got := partitionEvaluations(tc.input) diff --git a/scaletest/harness/strategies.go b/scaletest/harness/strategies.go index 7d5067a4e1..b16baade7c 100644 --- a/scaletest/harness/strategies.go +++ b/scaletest/harness/strategies.go @@ -89,8 +89,6 @@ func (p ParallelExecutionStrategy) Run(ctx context.Context, fns []TestFn) ([]err defer close(sem) for i, fn := range fns { - i, fn := i, fn - wg.Add(1) go func() { defer func() { diff --git a/scaletest/taskstatus/run_internal_test.go b/scaletest/taskstatus/run_internal_test.go index 47914f7323..694331fffc 100644 --- a/scaletest/taskstatus/run_internal_test.go +++ b/scaletest/taskstatus/run_internal_test.go @@ -637,7 +637,6 @@ func TestParseStatusMessage(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() gotNum, gotOk := parseStatusMessage(tt.message) diff --git a/support/support.go b/support/support.go index 4b216228ce..cb7b2e1c36 100644 --- a/support/support.go +++ b/support/support.go @@ -715,7 +715,6 @@ func PprofInfo(ctx context.Context, client *codersdk.Client, log slog.Logger) *P } for endpoint, setter := range endpoints { - endpoint, setter := endpoint, setter eg.Go(func() error { timeout := 10 * time.Second if strings.Contains(endpoint, "seconds=30") { @@ -822,7 +821,6 @@ func PprofInfoFromAgent(ctx context.Context, conn workspacesdk.AgentConn, log sl // Collect each endpoint in parallel for endpoint, setter := range endpoints { - endpoint, setter := endpoint, setter // capture loop variables eg.Go(func() error { // Set longer timeout for profile and trace endpoints (they take 30 seconds) timeout := 10 * time.Second