From 9e7125f852854d0d7c1dd8ba42dba84dfdbb42d5 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Mon, 9 Mar 2026 19:03:06 +0200 Subject: [PATCH] fix(scripts): handle ignored enc.Encode error in telemetry server (#22855) Check the `json.Encoder.Encode` error and print to stderr. Part of the effort to enable `errcheck.check-blank` in golangci-lint. --- scripts/telemetry-server/main.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/telemetry-server/main.go b/scripts/telemetry-server/main.go index 4fccf592b3..6a79aba596 100644 --- a/scripts/telemetry-server/main.go +++ b/scripts/telemetry-server/main.go @@ -43,7 +43,9 @@ func main() { "version": r.Header.Get("X-Telemetry-Version"), "data": json.RawMessage(body), } - _ = enc.Encode(output) + if err := enc.Encode(output); err != nil { + _, _ = fmt.Fprintf(os.Stderr, "Error encoding telemetry output: %v\n", err) + } w.WriteHeader(http.StatusAccepted) }