From b9c7bc4d3ca267895fbc1ac13af4ec133d34a49d Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Mon, 9 Oct 2023 22:12:28 +0400 Subject: [PATCH] fix: check for nil pointer in AwaitWorkspaceAgents CompletedAt is a pointer and can be nil, need to check before calling IsZero() on it c.f. https://github.com/coder/coder/runs/17534657301 --- coderd/coderdtest/coderdtest.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go index f78a5f1382..2f58fa1209 100644 --- a/coderd/coderdtest/coderdtest.go +++ b/coderd/coderdtest/coderdtest.go @@ -857,6 +857,9 @@ func AwaitWorkspaceAgents(t testing.TB, client *codersdk.Client, workspaceID uui if !assert.NoError(t, err) { return false } + if workspace.LatestBuild.Job.CompletedAt == nil { + return false + } if workspace.LatestBuild.Job.CompletedAt.IsZero() { return false }