From ce125831d3fd29e24c906ab390abc357612ec8e3 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Fri, 24 Apr 2026 13:40:37 +0300 Subject: [PATCH] fix(Makefile): run storybook tests after Go tests in pre-push (#24703) Rolldown's tokio workers stall when competing with Go compilation and the production site build for CPU, causing Vite transform requests to hang. Vitest browser mode has no import-phase timeout, so a stalled browser import() blocks the run indefinitely. --- Makefile | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bb70709683..6d6b929bc5 100644 --- a/Makefile +++ b/Makefile @@ -881,8 +881,15 @@ pre-push: $(MAKE) --no-print-directory -j$(PARALLEL_JOBS) MAKE_TIMED=1 MAKE_LOGDIR=$$logdir \ test \ test-js \ - test-storybook \ site/out/index.html + # Storybook tests run after Go tests and the site build to avoid + # CPU starvation. Rolldown's tokio workers in Vite's transform + # pipeline stall when competing with Go compilation and the + # production build, causing browser import() calls to hang + # indefinitely (vitest has no import-phase timeout). + echo "test storybook:" + $(MAKE) --no-print-directory MAKE_TIMED=1 MAKE_LOGDIR=$$logdir \ + test-storybook rm -rf $$logdir echo "$(GREEN)✓ pre-push passed$(RESET) ($$(( $$(date +%s) - $$start ))s)" .PHONY: pre-push