From d306a2d7e571ff68d58384a0a697480a394b55e9 Mon Sep 17 00:00:00 2001 From: Asher Date: Thu, 30 Oct 2025 10:23:52 -0800 Subject: [PATCH] chore: log with %s on unexpected non-sdk err (#20570) With `%w` it prints an address instead of the error, like ` 0xc001329370` instead of ` : some error`, honestly idk why you even can log with `%w` it seems like it makes no sense to use `%w` outside of `fmt.Errorf`. This is to help debug https://github.com/coder/internal/issues/1010. --- coderd/coderdtest/coderdtest.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go index 463ee888f6..ac362295f0 100644 --- a/coderd/coderdtest/coderdtest.go +++ b/coderd/coderdtest/coderdtest.go @@ -1604,7 +1604,7 @@ func (nopcloser) Close() error { return nil } // SDKError coerces err into an SDK error. func SDKError(t testing.TB, err error) *codersdk.Error { var cerr *codersdk.Error - require.True(t, errors.As(err, &cerr), "should be SDK error, got %w", err) + require.True(t, errors.As(err, &cerr), "should be SDK error, got %s", err) return cerr }