Ethan
dae19039d7
test: fix TestCache_DeploymentStats flake ( #19683 )
...
Closes https://github.com/coder/internal/issues/961
Likely the same deal as in #19599 , the body of `require.Eventually` now fires immediately, when it used to fire after 250ms (the interval). Presumably, the deployment stats become ready before the vs code session count gets incremented. This was never an issue with the 250ms delay, as this flake has only cropped up after the testify version bump.
We'll fix the issue by making it possible to wait for a full metrics cache refresh, i.e. removing `require.Eventually` in this test altogether.
2025-09-08 12:07:38 +10:00
dependabot[bot]
519812776e
chore: bump github.com/stretchr/testify from 1.10.0 to 1.11.1 ( #19599 )
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify )
from 1.10.0 to 1.11.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/stretchr/testify/releases ">github.com/stretchr/testify's
releases</a>.</em></p>
<blockquote>
<h2>v1.11.1</h2>
<p>This release fixes <a
href="https://redirect.github.com/stretchr/testify/issues/1785 ">#1785</a>
introduced in v1.11.0 where expected argument values implementing the
stringer interface (<code>String() string</code>) with a method which
mutates their value, when passed to mock.Mock.On
(<code>m.On("Method", <expected>).Return()</code>) or
actual argument values passed to mock.Mock.Called may no longer match
one another where they previously did match. The behaviour prior to
v1.11.0 where the stringer is always called is restored. Future testify
releases may not call the stringer method at all in this case.</p>
<h2>What's Changed</h2>
<ul>
<li>Backport <a
href="https://redirect.github.com/stretchr/testify/issues/1786 ">#1786</a>
to release/1.11: mock: revert to pre-v1.11.0 argument matching behavior
for mutating stringers by <a
href="https://github.com/brackendawson "><code>@brackendawson</code></a>
in <a
href="https://redirect.github.com/stretchr/testify/pull/1788 ">stretchr/testify#1788</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/stretchr/testify/compare/v1.11.0...v1.11.1 ">https://github.com/stretchr/testify/compare/v1.11.0...v1.11.1 </a></p>
<h2>v1.11.0</h2>
<h2>What's Changed</h2>
<h3>Functional Changes</h3>
<p>v1.11.0 Includes a number of performance improvements.</p>
<ul>
<li>Call stack perf change for CallerInfo by <a
href="https://github.com/mikeauclair "><code>@mikeauclair</code></a> in
<a
href="https://redirect.github.com/stretchr/testify/pull/1614 ">stretchr/testify#1614</a></li>
<li>Lazily render mock diff output on successful match by <a
href="https://github.com/mikeauclair "><code>@mikeauclair</code></a> in
<a
href="https://redirect.github.com/stretchr/testify/pull/1615 ">stretchr/testify#1615</a></li>
<li>assert: check early in Eventually, EventuallyWithT, and Never by <a
href="https://github.com/cszczepaniak "><code>@cszczepaniak</code></a>
in <a
href="https://redirect.github.com/stretchr/testify/pull/1427 ">stretchr/testify#1427</a></li>
<li>assert: add IsNotType by <a
href="https://github.com/bartventer "><code>@bartventer</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1730 ">stretchr/testify#1730</a></li>
<li>assert.JSONEq: shortcut if same strings by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1754 ">stretchr/testify#1754</a></li>
<li>assert.YAMLEq: shortcut if same strings by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1755 ">stretchr/testify#1755</a></li>
<li>assert: faster and simpler isEmpty using reflect.Value.IsZero by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1761 ">stretchr/testify#1761</a></li>
<li>suite: faster methods filtering (internal refactor) by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1758 ">stretchr/testify#1758</a></li>
</ul>
<h3>Fixes</h3>
<ul>
<li>assert.ErrorAs: log target type by <a
href="https://github.com/craig65535 "><code>@craig65535</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1345 ">stretchr/testify#1345</a></li>
<li>Fix failure message formatting for Positive and Negative asserts in
<a
href="https://redirect.github.com/stretchr/testify/pull/1062 ">stretchr/testify#1062</a></li>
<li>Improve ErrorIs message when error is nil but an error was expected
by <a href="https://github.com/tsioftas "><code>@tsioftas</code></a> in
<a
href="https://redirect.github.com/stretchr/testify/pull/1681 ">stretchr/testify#1681</a></li>
<li>fix Subset/NotSubset when calling with mixed input types by <a
href="https://github.com/siliconbrain "><code>@siliconbrain</code></a>
in <a
href="https://redirect.github.com/stretchr/testify/pull/1729 ">stretchr/testify#1729</a></li>
<li>Improve ErrorAs failure message when error is nil by <a
href="https://github.com/ccoVeille "><code>@ccoVeille</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1734 ">stretchr/testify#1734</a></li>
<li>mock.AssertNumberOfCalls: improve error msg by <a
href="https://github.com/3scalation "><code>@3scalation</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1743 ">stretchr/testify#1743</a></li>
</ul>
<h3>Documentation, Build & CI</h3>
<ul>
<li>docs: Fix typo in README by <a
href="https://github.com/alexandear "><code>@alexandear</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1688 ">stretchr/testify#1688</a></li>
<li>Replace deprecated io/ioutil with io and os by <a
href="https://github.com/alexandear "><code>@alexandear</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1684 ">stretchr/testify#1684</a></li>
<li>Document consequences of calling t.FailNow() by <a
href="https://github.com/greg0ire "><code>@greg0ire</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1710 ">stretchr/testify#1710</a></li>
<li>chore: update docs for Unset <a
href="https://redirect.github.com/stretchr/testify/issues/1621 ">#1621</a>
by <a href="https://github.com/techfg "><code>@techfg</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1709 ">stretchr/testify#1709</a></li>
<li>README: apply gofmt to examples by <a
href="https://github.com/alexandear "><code>@alexandear</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1687 ">stretchr/testify#1687</a></li>
<li>refactor: use %q and %T to simplify fmt.Sprintf by <a
href="https://github.com/alexandear "><code>@alexandear</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1674 ">stretchr/testify#1674</a></li>
<li>Propose Christophe Colombier (ccoVeille) as approver by <a
href="https://github.com/brackendawson "><code>@brackendawson</code></a>
in <a
href="https://redirect.github.com/stretchr/testify/pull/1716 ">stretchr/testify#1716</a></li>
<li>Update documentation for the Error function in assert or require
package by <a
href="https://github.com/architagr "><code>@architagr</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1675 ">stretchr/testify#1675</a></li>
<li>assert: remove deprecated build constraints by <a
href="https://github.com/alexandear "><code>@alexandear</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1671 ">stretchr/testify#1671</a></li>
<li>assert: apply gofumpt to internal test suite by <a
href="https://github.com/ccoVeille "><code>@ccoVeille</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1739 ">stretchr/testify#1739</a></li>
<li>CI: fix shebang in .ci.*.sh scripts by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1746 ">stretchr/testify#1746</a></li>
<li>assert,require: enable parallel testing on (almost) all top tests by
<a href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1747 ">stretchr/testify#1747</a></li>
<li>suite.Passed: add one more status test report by <a
href="https://github.com/Ararsa-Derese "><code>@Ararsa-Derese</code></a>
in <a
href="https://redirect.github.com/stretchr/testify/pull/1706 ">stretchr/testify#1706</a></li>
<li>Add Helper() method in internal mocks and assert.CollectT by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1423 ">stretchr/testify#1423</a></li>
<li>assert.Same/NotSame: improve usage of Sprintf by <a
href="https://github.com/ccoVeille "><code>@ccoVeille</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1742 ">stretchr/testify#1742</a></li>
<li>mock: enable parallel testing on internal testsuite by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1756 ">stretchr/testify#1756</a></li>
<li>suite: cleanup use of 'testing' internals at runtime by <a
href="https://github.com/dolmen "><code>@dolmen</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1751 ">stretchr/testify#1751</a></li>
<li>assert: check test failure message for Empty and NotEmpty by <a
href="https://github.com/ccoVeille "><code>@ccoVeille</code></a> in <a
href="https://redirect.github.com/stretchr/testify/pull/1745 ">stretchr/testify#1745</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/stretchr/testify/commit/2a57335dc9cd6833daa820bc94d9b40c26a7917d "><code>2a57335</code></a>
Merge pull request <a
href="https://redirect.github.com/stretchr/testify/issues/1788 ">#1788</a>
from brackendawson/1785-backport-1.11</li>
<li><a
href="https://github.com/stretchr/testify/commit/af8c91234f184009f57ef29027b39ca89cb00100 "><code>af8c912</code></a>
Backport <a
href="https://redirect.github.com/stretchr/testify/issues/1786 ">#1786</a>
to release/1.11</li>
<li><a
href="https://github.com/stretchr/testify/commit/b7801fbf5cd58d201296d5d0e132d1849966dbd4 "><code>b7801fb</code></a>
Merge pull request <a
href="https://redirect.github.com/stretchr/testify/issues/1778 ">#1778</a>
from stretchr/dependabot/github_actions/actions/chec...</li>
<li><a
href="https://github.com/stretchr/testify/commit/69831f3b08c40d56a09d0be93e9d5ae034f1590b "><code>69831f3</code></a>
build(deps): bump actions/checkout from 4 to 5</li>
<li><a
href="https://github.com/stretchr/testify/commit/a53be35c3b0cfcd5189cffcfd75df60ea581104c "><code>a53be35</code></a>
Improve captureTestingT helper</li>
<li><a
href="https://github.com/stretchr/testify/commit/aafb604176db7e1f2c9810bc90d644291d057687 "><code>aafb604</code></a>
mock: improve formatting of error message</li>
<li><a
href="https://github.com/stretchr/testify/commit/7218e0390acd2aea3edb18574110ec2753c0aeef "><code>7218e03</code></a>
improve error msg</li>
<li><a
href="https://github.com/stretchr/testify/commit/929a2126c2702df436312656a0304580b526c6e9 "><code>929a212</code></a>
Merge pull request <a
href="https://redirect.github.com/stretchr/testify/issues/1758 ">#1758</a>
from stretchr/dolmen/suite-faster-method-filtering</li>
<li><a
href="https://github.com/stretchr/testify/commit/bc7459ec38128532ff32f23cfab4ea0b725210f2 "><code>bc7459e</code></a>
suite: faster filtering of methods (-testify.m)</li>
<li><a
href="https://github.com/stretchr/testify/commit/7d37b5c962954410bcd7a71ff3a77c79514056d1 "><code>7d37b5c</code></a>
suite: refactor methodFilter</li>
<li>Additional commits viewable in <a
href="https://github.com/stretchr/testify/compare/v1.10.0...v1.11.1 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ethan Dickson <ethan@coder.com >
2025-09-02 03:12:37 +00:00
Callum Styan
4fab14b40b
fix: limit the scope of the template average build time query to the last 100 ( #19648 )
...
This PR should resolve https://github.com/coder/internal/issues/719 by
limiting the `workspace_builds` rows selected by the query to the most
recent 100 builds of a template, as opposed to all builds in the last
30d. For our own internal templates with the most builds (1700-2000 in a
30d period) this should cut the query execution time by about 80%.
Unless we have some restriction on keeping the 30d period, contract
related or otherwise, this seems like a safe change to make. In addition
to the execution speed improvements it also means the memory for the
query is bounded as well.
If we want to keep a 30d time period for the avg build time value I
think it's worth exploring a purpose built solution such as histogram
structures where the build times could be bucketized by template ID as
they're observed.
---------
Signed-off-by: Callum Styan <callumstyan@gmail.com >
2025-09-01 09:31:21 -07:00
ケイラ
fae30a00fd
chore: remove unnecessary redeclarations in for loops ( #18440 )
2025-06-20 13:16:55 -06:00
Cian Johnston
e8b7ce80de
ci: re-enable revive and gosec linters ( #17225 )
...
* Reenables revive linter for test files (with an exception for the
`unused-parameter` rule)
* Reenables gosec linter for test files
2025-04-02 16:19:23 +01:00
Danielle Maywood
6dd51f92fb
chore: test metricscache on postgres ( #16711 )
...
metricscache_test has been running tests against dbmem only, instead of
against postgres. Unfortunately the implementations of
GetTemplateAverageBuildTime have diverged between dbmem and postgres.
This change gets the tests working on Postgres and test for the
behaviour postgres provides.
2025-02-27 09:43:51 +00:00
Spike Curtis
5861e516b9
chore: add standard test logger ignoring db canceled ( #15556 )
...
Refactors our use of `slogtest` to instantiate a "standard logger" across most of our tests. This standard logger incorporates https://github.com/coder/slog/pull/217 to also ignore database query canceled errors by default, which are a source of low-severity flakes.
Any test that has set non-default `slogtest.Options` is left alone. In particular, `coderdtest` defaults to ignoring all errors. We might consider revisiting that decision now that we have better tools to target the really common flaky Error logs on shutdown.
2024-11-18 14:09:22 +04:00
Steven Masley
343f8ec9ab
chore: join owner, template, and org in new workspace view ( #15116 )
...
Joins in fields like `username`, `avatar_url`, `organization_name`,
`template_name` to `workspaces` via a **view**.
The view must be maintained moving forward, but this prevents needing to
add RBAC permissions to fetch related workspace fields.
2024-10-22 09:20:54 -05:00
Garrett Delfosse
922f4c545f
fix: handle new agent stat format correctly ( #14576 )
...
---------
Co-authored-by: Ethan Dickson <ethan@coder.com >
2024-09-20 01:52:14 +10:00
Danny Kopping
8b1c46fbe0
fix: analyze build times over 30 days not 30 months ( #14584 )
2024-09-06 17:03:01 +02:00
Mathias Fredriksson
92190443ff
fix(coderd/metricscache): avoid logging error for no rows ( #12988 )
...
Fixes #12938
2024-04-17 20:43:13 +03:00
Steven Masley
0a8c8ce5cc
chore: remove InsertWorkspaceAgentStat query ( #12869 )
...
* chore: remove InsertWorkspaceAgentStat query
InsertWorkspaceAgentStats (batch) exists. We only used the singular in
a single unit test place. Removing the single for the batch, reducing
the interface size.
2024-04-09 12:35:27 -05:00
Mathias Fredriksson
421bf7e785
fix(coderd): use insights for DAUs, simplify metricscache ( #12775 )
...
Fixes #12134
Fixes https://github.com/coder/customers/issues/384
Refs #12122
2024-03-27 18:10:14 +02:00
Garrett Delfosse
3ab3a62bef
feat: add port-sharing backend ( #11939 )
2024-02-13 09:31:20 -05:00
Steven Masley
ac64155282
fix: strip timezone information from a date in dau response ( #11962 )
...
* fix: strip timezone information from a date in dau response
Timezone information is lost, so do not forward it to the client.
* fix: timezone offset should be flipped
* Make tests deterministic
2024-01-31 16:01:50 -06:00
Colin Adler
eb81fcf1e1
fix: lower amount of cached timezones for deployment daus ( #11196 )
...
Updates https://github.com/coder/customers/issues/384
This should help alleviate some pressure, but doesn't really fix the
root cause. See above issue for more details.
2023-12-13 16:50:29 -06:00
Cian Johnston
197cd935cf
chore(Makefile): use linter version from dogfood Dockerfile ( #11147 )
...
* chore(Makefile): use golangci-lint version from dogfood Dockerfile
* chore(dogfood/Dockerfile): update golangci-lint to latest version
* chore(coderd): address linter complaints
2023-12-12 10:02:32 +00:00
Garrett Delfosse
8aea6040c8
fix: use unique workspace owners over unique users ( #11044 )
2023-12-07 10:53:15 -05:00
Kyle Carberry
5abfe5afd0
chore: rename dbfake to dbmem ( #10432 )
2023-10-30 17:42:20 +00:00
Mathias Fredriksson
19d7da3d24
refactor(coderd/database): split Time and Now into dbtime package ( #9482 )
...
Ref: #9380
2023-09-01 16:50:12 +00:00
Kyle Carberry
22e781eced
chore: add /v2 to import module path ( #9072 )
...
* chore: add /v2 to import module path
go mod requires semantic versioning with versions greater than 1.x
This was a mechanical update by running:
```
go install github.com/marwan-at-work/mod/cmd/mod@latest
mod upgrade
```
Migrate generated files to import /v2
* Fix gen
2023-08-18 18:55:43 +00:00
Colin Adler
bc862fa493
chore: upgrade tailscale to v1.46.1 ( #8913 )
2023-08-09 19:50:26 +00:00
Steven Masley
de1a7a9210
chore: join user information to workspace_build and template_version ( #8625 )
...
* include minimial user on template version and build
* Add unit test to ensure join is superset
2023-07-25 09:14:38 -04:00
Steven Masley
aceedefce3
chore: add template_with_user view to include user contextual data ( #8568 )
...
* chore: Refactor template sql queries to use new view
* TemplateWithUser -> Template
* Add unit test to enforce good view
2023-07-19 16:07:33 -04:00
Mathias Fredriksson
51226c55ab
test(coderd): close metricscache and avoid background context ( #7996 )
2023-06-13 20:18:31 +03:00
Steven Masley
cf8d2bc096
feat: use tz_offset when doing deployment dau query ( #7736 )
...
* Have FE query correct tz_offset data
2023-06-01 09:23:50 -04:00
Steven Masley
73d795f426
chore: Revert to only using 1 timezone support for template DAUs ( #7721 )
...
* chore: Revert to only using 1 timezone support for template DAUs
Keeping the logic to support more in case we optimize later
2023-05-30 15:37:07 -04:00
Steven Masley
c795a0e500
feat: Fix Deployment DAUs to work with local timezones ( #7647 )
...
* chore: Add timezone param to DAU SQL query
* Merge DAUs response
* Pass time offsets to metricscache
2023-05-30 13:18:27 -04:00
Kyle Carberry
cb7375450b
feat: add startup script logs to the ui ( #6558 )
...
* Add startup script logs to the database
* Add coderd endpoints for startup script logs
* Push startup script logs from agent
* Pull startup script logs on frontend
* Rename queries
* Add constraint
* Start creating log sending loop
* Add log sending to the agent
* Add tests for streaming logs
* Shorten notify channel name
* Add FE
* Improve bulk log performance
* Finish UI display
* Fix startup log visibility
* Add warning for overflow
* Fix agent queue logs overflow
* Display staartup logs in a virtual DOM for performance
* Fix agent queue with loads of logs
* Fix authorize test
* Remove faulty test
* Fix startup and shutdown reporting error
* Fix gen
* Fix comments
* Periodically purge old database entries
* Add test fixture for migration
* Add Storybook
* Check if there are logs when displaying features
* Fix startup component overflow gap
* Fix startup log wrapping
---------
Co-authored-by: Asher <ash@coder.com >
2023-03-23 14:09:13 -05:00
Kyle Carberry
5304b4e483
feat: add connection statistics for workspace agents ( #6469 )
...
* fix: don't make session counts cumulative
This made for some weird tracking... we want the point-in-time
number of counts!
* Add databasefake query for getting agent stats
* Add deployment stats endpoint
* The query... works?!?
* Fix aggregation query
* Select from multiple tables instead
* Fix continuous stats
* Increase period of stat refreshes
* Add workspace counts to deployment stats
* fmt
* Add a slight bit of responsiveness
* Fix template version editor overflow
* Add refresh button
* Fix font family on button
* Fix latest stat being reported
* Revert agent conn stats
* Fix linting error
* Fix tests
* Fix gen
* Fix migrations
* Block on sending stat updates
* Add test fixtures
* Fix response structure
* make gen
2023-03-08 21:05:45 -06:00
Kyle Carberry
87ed7a7dba
chore: use nil map on agent stats to check if report interval should be returned ( #6479 )
...
See https://github.com/coder/coder/actions/runs/4350638262/jobs/7601537088
2023-03-07 14:25:04 +00:00
Kyle Carberry
09f87d1df1
chore: remove empty case for metricscache ( #6473 )
...
This wasn't necessary to test and just caused flakes.
See: https://github.com/coder/coder/actions/runs/4350034299/jobs/7600340648
2023-03-06 21:13:08 -06:00
Kyle Carberry
05e449943d
chore: convert agent stats to use a table ( #6374 )
...
* chore: convert workspace agent stats from json to table
* chore: convert agent stats to use a table
Backwards compatibility becomes hard when all agent stats are in a JSON blob.
We also want to query this table for new agents that are failing health checks
so we can display it in the UI.
* Fix migration using default values
2023-02-28 13:33:33 -06:00
Ammar Bandukwala
f05609b4da
chore: format Go more aggressively
2023-02-18 18:32:09 -06:00
Cian Johnston
f0f39b4892
chore: break down dbauthz.System into smaller roles ( #6218 )
...
- rbac: export rbac.Permissions
- dbauthz: move GetDeploymentDAUs, GetTemplateDAUs,
GetTemplateAverageBuildTime from querier.go to system.go
and removes auth checks
- dbauthz: remove AsSystem(), add individual roles for
autostart, provisionerd, add restricted system role for
everything else
2023-02-15 16:14:37 +00:00
Steven Masley
6fb8aff6d0
feat: Add initial AuthzQuerier implementation ( #5919 )
...
feat: Add initial AuthzQuerier implementation
- Adds package database/dbauthz that adds a database.Store implementation where each method goes through AuthZ checks
- Implements all database.Store methods on AuthzQuerier
- Updates and fixes unit tests where required
- Updates coderd initialization to use AuthzQuerier if codersdk.ExperimentAuthzQuerier is enabled
2023-02-14 14:27:06 +00:00
Steven Masley
8dba66c535
chore: Use dbgen in unit test ( #6111 )
...
* chore: Use dbgen in unit test
- organizationparam_test
- templateparam_test
* Use dbgen in all unit tests vs insert methods
* fixup! Use dbgen in all unit tests vs insert methods
---------
Co-authored-by: Cian Johnston <cian@coder.com >
2023-02-08 13:47:05 -06:00
Steven Masley
8b424f03c2
chore: Rename databasefake --> dbfake ( #6011 )
2023-02-02 19:28:55 -06:00
Presley Pizzo
16d8cc4176
feat(site): Add deployment-wide DAU chart ( #5810 )
2023-01-25 22:03:47 -03:00
Mathias Fredriksson
8afdf24d10
chore: Update sqlc to v1.16.0 ( #5788 )
...
* chore: Update sqlc to v1.16.0
* chore: Fix cases where types became Null-types
* chore: Set parameter_schemas default_destination_scheme and default_source_scheme to NOT NULL
* chore: Add enum validation to database fake
* chore: Fix all tests that skipping enum values
* fix: Use correct err in providionerdserver audit log failure log
2023-01-23 13:14:47 +02:00
Ammar Bandukwala
acf34d4295
site: support high build time variation in progress bar ( #4941 )
2022-11-17 16:56:56 +00:00
Ammar Bandukwala
fa49ccd058
coderd/metricscache: fix test race ( #4662 )
2022-10-20 02:36:00 +00:00
Ammar Bandukwala
1984932dc9
coderd/metricscache: attempt to fix macOS race ( #4622 )
2022-10-18 17:28:40 +00:00
Ammar Bandukwala
dc3519e973
Support all transitions in build progress bar ( #4575 )
...
* Use null types instead of -1 for simplicity
* Fix pgcrypto bug in migration 59
* Add stories
* Fix visual stutter
2022-10-16 23:34:03 -05:00
Ammar Bandukwala
e456799f1a
Add template build time stats ( #4557 )
...
- Expose time in Template pages
- Show progress bar when building a workspace
2022-10-15 20:36:50 +00:00
Ammar Bandukwala
f6aa025a01
feat: use active users instead of total users in Template views ( #3900 )
2022-09-09 19:30:31 +00:00
Ammar Bandukwala
30f8fd9b95
Daily Active User Metrics ( #3735 )
...
* agent: add StatsReporter
* Stabilize protoc
2022-09-01 14:58:23 -05:00