3 Commits

Author	SHA1	Message	Date
Cian Johnston	da2fa082bb	fix(coderd/httpapi): CloseRead on test conns to ensure pings pong (#25184) ... The `websocketPair` test helper was not calling `CloseRead` on either side of the connection. Without `CloseRead`, the websocket library does not process control frames (ping/pong), so the heartbeat tests were passing only because no pings had yet failed, not because pings were actually succeeding. Add `CloseRead` on both the client and server connections so that pong frames are delivered in response to pings. Split out from #25012. > 🤖 Generated with [Coder Agents](https://coder.com)	2026-05-14 13:54:59 +01:00
Cian Johnston	65b7658568	chore: extract testutil.FakeSink for slog test assertions (#23208) ... Follow-up to [review comment on #23025](https://github.com/coder/coder/pull/23025#discussion_r2930309487) from @mafredri. Extracts the repeated `logSink` / `fakeSink` test pattern into a shared `testutil.FakeSink` and migrates all existing call sites. > 🤖 This PR was created with the help of Coder Agents, and will be reviewed by my human. 🧑‍💻 --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>	2026-03-18 17:02:38 +00:00
Cian Johnston	8714aa4637	fix(coderd): downgrade heartbeat ping errors for closed connections to debug (#23025) ... - `coderd/httpapi/websocket.go`: add `net.ErrClosed` + `websocket.CloseStatus` checks; extract `heartbeatCloseWith` with `quartz.Clock` parameter for testability - `coderd/httpapi/websocket_internal_test.go`: new test file	2026-03-13 10:38:39 +00:00