mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
3a9080fff6
Workspace-agent logs emitted while serving chatd-driven requests were not correlated with the originating chat, making agent logs hard to attribute to the corresponding/originating chat. This adds agent-side chat context middleware that parses `Coder-Chat-Id` once, enriches agent access logs and structured handler/background logs, and adds a chatd bridge log when chat headers are attached to an agent connection. Closes CODAGT-324
162 lines
4.3 KiB
Go
162 lines
4.3 KiB
Go
package agentchat_test
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/agent/agentchat"
|
|
"github.com/coder/coder/v2/codersdk/workspacesdk"
|
|
)
|
|
|
|
func TestExtractContext(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
validID := uuid.MustParse("aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee")
|
|
ancestor1 := uuid.MustParse("11111111-2222-3333-4444-555555555555")
|
|
ancestor2 := uuid.MustParse("66666666-7777-8888-9999-aaaaaaaaaaaa")
|
|
|
|
tests := []struct {
|
|
name string
|
|
chatID string // empty means header not set
|
|
setChatID bool // whether to set the chat ID header at all
|
|
ancestors string // empty means header not set
|
|
setAncestors bool // whether to set the ancestor header at all
|
|
wantChatID uuid.UUID
|
|
wantAncestorIDs []uuid.UUID
|
|
wantOK bool
|
|
}{
|
|
{
|
|
name: "NoHeadersPresent",
|
|
setChatID: false,
|
|
setAncestors: false,
|
|
wantChatID: uuid.Nil,
|
|
wantAncestorIDs: nil,
|
|
wantOK: false,
|
|
},
|
|
{
|
|
name: "ValidChatID_NoAncestors",
|
|
chatID: validID.String(),
|
|
setChatID: true,
|
|
setAncestors: false,
|
|
wantChatID: validID,
|
|
wantAncestorIDs: []uuid.UUID{},
|
|
wantOK: true,
|
|
},
|
|
{
|
|
name: "ValidChatID_ValidAncestors",
|
|
chatID: validID.String(),
|
|
setChatID: true,
|
|
ancestors: mustMarshalJSON(t, []string{
|
|
ancestor1.String(),
|
|
ancestor2.String(),
|
|
}),
|
|
setAncestors: true,
|
|
wantChatID: validID,
|
|
wantAncestorIDs: []uuid.UUID{ancestor1, ancestor2},
|
|
wantOK: true,
|
|
},
|
|
{
|
|
name: "MalformedChatID",
|
|
chatID: "not-a-uuid",
|
|
setChatID: true,
|
|
setAncestors: false,
|
|
wantChatID: uuid.Nil,
|
|
wantAncestorIDs: nil,
|
|
wantOK: false,
|
|
},
|
|
{
|
|
name: "ValidChatID_MalformedAncestorJSON",
|
|
chatID: validID.String(),
|
|
setChatID: true,
|
|
ancestors: `{this is not json}`,
|
|
setAncestors: true,
|
|
wantChatID: validID,
|
|
wantAncestorIDs: []uuid.UUID{},
|
|
wantOK: true,
|
|
},
|
|
{
|
|
// Only valid UUIDs in the array are returned; invalid
|
|
// entries are silently skipped.
|
|
name: "ValidChatID_PartialValidAncestorUUIDs",
|
|
chatID: validID.String(),
|
|
setChatID: true,
|
|
ancestors: mustMarshalJSON(t, []string{
|
|
ancestor1.String(),
|
|
"bad-uuid",
|
|
ancestor2.String(),
|
|
}),
|
|
setAncestors: true,
|
|
wantChatID: validID,
|
|
wantAncestorIDs: []uuid.UUID{ancestor1, ancestor2},
|
|
wantOK: true,
|
|
},
|
|
{
|
|
// Header is explicitly set to an empty string, which
|
|
// Header.Get returns as "".
|
|
name: "EmptyChatIDHeader",
|
|
chatID: "",
|
|
setChatID: true,
|
|
setAncestors: false,
|
|
wantChatID: uuid.Nil,
|
|
wantAncestorIDs: nil,
|
|
wantOK: false,
|
|
},
|
|
{
|
|
name: "ValidChatID_EmptyAncestorHeader",
|
|
chatID: validID.String(),
|
|
setChatID: true,
|
|
ancestors: "",
|
|
setAncestors: true,
|
|
wantChatID: validID,
|
|
wantAncestorIDs: []uuid.UUID{},
|
|
wantOK: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
r := httptest.NewRequest("GET", "/", nil)
|
|
if tt.setChatID {
|
|
r.Header.Set(workspacesdk.CoderChatIDHeader, tt.chatID)
|
|
}
|
|
if tt.setAncestors {
|
|
r.Header.Set(workspacesdk.CoderAncestorChatIDsHeader, tt.ancestors)
|
|
}
|
|
|
|
chatID, ancestorIDs, ok := extractContextForTest(r)
|
|
|
|
require.Equal(t, tt.wantOK, ok, "ok mismatch")
|
|
require.Equal(t, tt.wantChatID, chatID, "chatID mismatch")
|
|
require.Equal(t, tt.wantAncestorIDs, ancestorIDs, "ancestorIDs mismatch")
|
|
})
|
|
}
|
|
}
|
|
|
|
func extractContextForTest(r *http.Request) (uuid.UUID, []uuid.UUID, bool) {
|
|
var chatContext agentchat.Context
|
|
var ok bool
|
|
agentchat.Middleware(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
|
|
chatContext, ok = agentchat.FromContext(r.Context())
|
|
})).ServeHTTP(httptest.NewRecorder(), r)
|
|
if !ok {
|
|
return uuid.Nil, nil, false
|
|
}
|
|
return chatContext.ID, chatContext.AncestorIDs, true
|
|
}
|
|
|
|
// mustMarshalJSON marshals v to a JSON string, failing the test on error.
|
|
func mustMarshalJSON(t *testing.T, v any) string {
|
|
t.Helper()
|
|
b, err := json.Marshal(v)
|
|
require.NoError(t, err)
|
|
return string(b)
|
|
}
|