mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
22109a54ad
## Description Cleans up how key pool errors are represented and how they get turned into HTTP responses. Consolidates two error types into a single type with a kind tag, and gives the response helpers in both providers consistent names. ## Changes - Replaced the keypool sentinel and transient error struct with one error type that carries a kind and a retry-after duration. - Updated `KeyFailoverConfig.BuildKeyPoolResponse` to take the typed key pool error, so each provider can shape the exhaustion response in its own format. - Removed the per-provider `MarkKey` callback from `KeyFailoverConfig` since providers can rely on the shared `MarkKeyOnStatus` helper. - Renamed the response-error helpers so OpenAI and Anthropic use the same naming. Related to: https://linear.app/codercom/issue/AIGOV-334/aibridge-follow-ups-from-key-failover-prs > [!NOTE] > Initially generated by Claude Opus 4.7, modified and reviewed by @ssncferreira
128 lines
3.3 KiB
Go
128 lines
3.3 KiB
Go
package keypool_test
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"cdr.dev/slog/v3/sloggers/slogtest"
|
|
"github.com/coder/coder/v2/aibridge/keypool"
|
|
"github.com/coder/quartz"
|
|
)
|
|
|
|
func TestMarkKeyOnStatus(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
statusCode int
|
|
headers map[string]string
|
|
expectedReturn bool
|
|
expectedState keypool.KeyState
|
|
expectedCooldown time.Duration
|
|
}{
|
|
{
|
|
// 429 with standard Retry-After header (seconds).
|
|
name: "429_with_retry_after_seconds",
|
|
statusCode: http.StatusTooManyRequests,
|
|
headers: map[string]string{"Retry-After": "5"},
|
|
expectedReturn: true,
|
|
expectedState: keypool.KeyStateTemporary,
|
|
expectedCooldown: 5 * time.Second,
|
|
},
|
|
{
|
|
// 429 with retry-after-ms header (milliseconds).
|
|
name: "429_with_retry_after_ms",
|
|
statusCode: http.StatusTooManyRequests,
|
|
headers: map[string]string{"retry-after-ms": "1500"},
|
|
expectedReturn: true,
|
|
expectedState: keypool.KeyStateTemporary,
|
|
expectedCooldown: 1500 * time.Millisecond,
|
|
},
|
|
{
|
|
// 429 without headers falls back to default cooldown.
|
|
name: "429_no_headers_uses_default",
|
|
statusCode: http.StatusTooManyRequests,
|
|
expectedReturn: true,
|
|
expectedState: keypool.KeyStateTemporary,
|
|
expectedCooldown: 60 * time.Second,
|
|
},
|
|
{
|
|
name: "401_marks_permanent",
|
|
statusCode: http.StatusUnauthorized,
|
|
expectedReturn: true,
|
|
expectedState: keypool.KeyStatePermanent,
|
|
},
|
|
{
|
|
name: "403_marks_permanent",
|
|
statusCode: http.StatusForbidden,
|
|
expectedReturn: true,
|
|
expectedState: keypool.KeyStatePermanent,
|
|
},
|
|
{
|
|
name: "200_does_not_mark",
|
|
statusCode: http.StatusOK,
|
|
expectedReturn: false,
|
|
expectedState: keypool.KeyStateValid,
|
|
},
|
|
{
|
|
name: "500_does_not_mark",
|
|
statusCode: http.StatusInternalServerError,
|
|
expectedReturn: false,
|
|
expectedState: keypool.KeyStateValid,
|
|
},
|
|
{
|
|
// 529 is the Anthropic overloaded status, handled by
|
|
// the circuit breaker, not key failover.
|
|
name: "529_does_not_mark",
|
|
statusCode: 529,
|
|
expectedReturn: false,
|
|
expectedState: keypool.KeyStateValid,
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
clk := quartz.NewMock(t)
|
|
pool, err := keypool.New([]string{"key-0"}, clk)
|
|
require.NoError(t, err)
|
|
key, keyPoolErr := pool.Walker().Next()
|
|
require.Nil(t, keyPoolErr)
|
|
|
|
resp := &http.Response{
|
|
StatusCode: tc.statusCode,
|
|
Header: make(http.Header),
|
|
}
|
|
for k, v := range tc.headers {
|
|
resp.Header.Set(k, v)
|
|
}
|
|
|
|
got := keypool.MarkKeyOnStatus(
|
|
context.Background(),
|
|
key,
|
|
resp,
|
|
// 401 and 403 cases legitimately log at error
|
|
// level when marking a key permanent.
|
|
slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}),
|
|
"test",
|
|
)
|
|
|
|
assert.Equal(t, tc.expectedReturn, got)
|
|
assert.Equal(t, tc.expectedState, key.State())
|
|
|
|
// Verify cooldown was set to the expected duration:
|
|
// advancing by exactly that amount returns the key
|
|
// to valid.
|
|
if tc.expectedCooldown > 0 {
|
|
clk.Advance(tc.expectedCooldown)
|
|
assert.Equal(t, keypool.KeyStateValid, key.State())
|
|
}
|
|
})
|
|
}
|
|
}
|