mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
Ethan
ef6969dd70
Agents can already see workspace files and take screenshots, but users could not download those artifacts from chat. This PR adds durable chat attachments to chatd. `attach_file`, explicit `computer` screenshot actions (not the automatic post-action screenshots), and `propose_plan` now fetch bytes over the agent connection, store them in `chat_files`, link them to the chat, and carry attachment metadata in tool responses so `buildAssistantPartsForPersist` can materialize ordinary `type:"file"` assistant parts that the chat file APIs serve. The same storage helpers are reused for other artifact-producing paths. `wait_agent` recordings and thumbnails are stored as chat files and linked back to the parent chat, with best-effort relinking so parent chats retain those artifacts without leaving orphaned rows when chat-file caps reject links. `storeChatAttachment` wraps insert + link in one transaction, files are capped at 10 MB each and 20 per chat, and serving defaults to `Content-Disposition: attachment` with an explicit inline-safe allowlist. This PR also consolidates chat-file media policy in `coderd/chatfiles`. Uploads and tool-generated attachments share byte-based MIME detection, SVG blocking, inline-safety rules, and compatible `text/plain` refinement for JSON, CSV, and Markdown. Prompt construction still only inlines synthetic pasted text for model consumption; assistant-created attachments are persisted for the user and intentionally not replayed into later LLM turns. UI follow-up lives in #24281. Relates to CODAGT-91
655 lines
20 KiB
Go
655 lines
20 KiB
Go
package chattool_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"io"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
"testing/iotest"
|
|
|
|
"charm.land/fantasy"
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/mock/gomock"
|
|
"golang.org/x/xerrors"
|
|
|
|
"github.com/coder/coder/v2/coderd/x/chatd/chattool"
|
|
"github.com/coder/coder/v2/codersdk/workspacesdk"
|
|
"github.com/coder/coder/v2/codersdk/workspacesdk/agentconnmock"
|
|
)
|
|
|
|
type proposePlanResponse struct {
|
|
OK bool `json:"ok"`
|
|
Path string `json:"path"`
|
|
Kind string `json:"kind"`
|
|
FileID string `json:"file_id"`
|
|
MediaType string `json:"media_type"`
|
|
}
|
|
|
|
func TestProposePlan(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("EmptyPathReturnsError", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":""}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, "path is required (use the chat-specific absolute plan path)", resp.Content)
|
|
})
|
|
|
|
t.Run("WhitespaceOnlyPathReturnsError", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":" "}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, "path is required (use the chat-specific absolute plan path)", resp.Content)
|
|
})
|
|
|
|
t.Run("NonMdPathReturnsError", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/plan.txt"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, "path must end with .md", resp.Content)
|
|
})
|
|
|
|
t.Run("RelativePlanPathReturnsError", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
resolvePlanPathCalled := false
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
resolvePlanPathCalled = true
|
|
return "/home/coder/.coder/plans/PLAN-chat.md", "/home/coder", nil
|
|
},
|
|
)
|
|
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"plan.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.False(t, resolvePlanPathCalled)
|
|
assert.Equal(t, relativePlanPathMessage(), resp.Content)
|
|
})
|
|
|
|
t.Run("OversizedFileRejected", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
largeContent := strings.Repeat("x", 32*1024+1)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/PLAN.md", int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader(largeContent)), "text/markdown", nil)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, "plan file exceeds 32 KiB size limit", resp.Content)
|
|
})
|
|
|
|
t.Run("ExactBoundaryFileSucceeds", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
content := strings.Repeat("x", 32*1024)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/PLAN.md", int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader(content)), "text/markdown", nil)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.False(t, resp.IsError)
|
|
})
|
|
|
|
t.Run("ValidPlanReadsFile", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/docs/PLAN.md", int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader("# Plan\n\nContent")), "text/markdown", nil)
|
|
|
|
storeFile, stored := fakeStoreFile(t)
|
|
planPathCalled := false
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
planPathCalled = true
|
|
return "/home/coder/.coder/plans/PLAN-xxx.md", "/home/coder", nil
|
|
},
|
|
)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/docs/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.False(t, resp.IsError)
|
|
assert.True(t, planPathCalled)
|
|
|
|
result := decodeProposePlanResponse(t, resp)
|
|
assert.True(t, result.OK)
|
|
assert.Equal(t, "/home/coder/docs/PLAN.md", result.Path)
|
|
assert.Equal(t, "plan", result.Kind)
|
|
assert.Equal(t, "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee", result.FileID)
|
|
assert.Equal(t, "text/markdown", result.MediaType)
|
|
assert.Equal(t, []byte("# Plan\n\nContent"), *stored)
|
|
assert.NotContains(t, resp.Content, "content")
|
|
|
|
attachments, err := chattool.AttachmentsFromMetadata(resp.Metadata)
|
|
require.NoError(t, err)
|
|
require.Len(t, attachments, 1)
|
|
assert.Equal(t, uuid.MustParse(result.FileID), attachments[0].FileID)
|
|
assert.Equal(t, result.MediaType, attachments[0].MediaType)
|
|
assert.Equal(t, filepath.Base(result.Path), attachments[0].Name)
|
|
})
|
|
|
|
t.Run("NestedPlanPathUnderHomeIsAllowed", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/myproject/plan.md", int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader("# Nested Plan")), "text/markdown", nil)
|
|
|
|
storeFile, stored := fakeStoreFile(t)
|
|
planPathCalled := false
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
planPathCalled = true
|
|
return "/home/coder/.coder/plans/PLAN-chat.md", "/home/coder", nil
|
|
},
|
|
)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/myproject/plan.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.False(t, resp.IsError)
|
|
assert.True(t, planPathCalled)
|
|
|
|
result := decodeProposePlanResponse(t, resp)
|
|
assert.True(t, result.OK)
|
|
assert.Equal(t, "/home/coder/myproject/plan.md", result.Path)
|
|
assert.Equal(t, []byte("# Nested Plan"), *stored)
|
|
})
|
|
|
|
t.Run("FileNotFound", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/PLAN.md", int64(0), int64(32*1024+1)).
|
|
Return(nil, "", xerrors.New("file not found"))
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Contains(t, resp.Content, "file not found")
|
|
})
|
|
|
|
t.Run("ReadFileError", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/PLAN.md", int64(0), int64(32*1024+1)).
|
|
Return(nil, "", xerrors.New("read failed"))
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, "read failed", resp.Content)
|
|
})
|
|
|
|
t.Run("ReadAllError", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/PLAN.md", int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(iotest.ErrReader(xerrors.New("connection reset"))), "text/markdown", nil)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanTool(t, mockConn, storeFile)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Contains(t, resp.Content, "connection reset")
|
|
})
|
|
|
|
t.Run("StoreFileError", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/PLAN.md", int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader("# Plan")), "text/markdown", nil)
|
|
|
|
tool := newProposePlanTool(t, mockConn, func(_ context.Context, _ string, _ string, _ []byte) (chattool.AttachmentMetadata, error) {
|
|
return chattool.AttachmentMetadata{}, xerrors.New("storage unavailable")
|
|
})
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, "failed to store plan file: storage unavailable", resp.Content)
|
|
})
|
|
|
|
t.Run("RejectsSharedPlanPathWithResolvedPath", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
return "/home/coder/.coder/plans/PLAN-chat.md", "/home/coder", nil
|
|
},
|
|
)
|
|
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"` + chattool.LegacySharedPlanPath + `"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(
|
|
t,
|
|
sharedPlanPathResolvedMessage(chattool.LegacySharedPlanPath, "/home/coder/.coder/plans/PLAN-chat.md"),
|
|
resp.Content,
|
|
)
|
|
})
|
|
|
|
t.Run("RejectsSharedPlanPathWhenResolverFails", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
return "", "", xerrors.New("workspace unavailable")
|
|
},
|
|
)
|
|
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"` + chattool.LegacySharedPlanPath + `"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, planPathVerificationMessage(chattool.LegacySharedPlanPath), resp.Content)
|
|
})
|
|
|
|
t.Run("PerChatPlanPathIsAllowed", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
chatPlanPath := "/home/coder/.coder/plans/PLAN-123e4567-e89b-12d3-a456-426614174000.md"
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), chatPlanPath, int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader("# Per-Chat Plan")), "text/markdown", nil)
|
|
|
|
storeFile, stored := fakeStoreFile(t)
|
|
resolvePlanPathCalled := false
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
resolvePlanPathCalled = true
|
|
return chatPlanPath, "/home/coder", nil
|
|
},
|
|
)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"` + chatPlanPath + `"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.False(t, resp.IsError)
|
|
assert.False(t, resolvePlanPathCalled)
|
|
|
|
result := decodeProposePlanResponse(t, resp)
|
|
assert.True(t, result.OK)
|
|
assert.Equal(t, chatPlanPath, result.Path)
|
|
assert.Equal(t, []byte("# Per-Chat Plan"), *stored)
|
|
})
|
|
|
|
t.Run("NestedPlanPathAllowedWhenResolverFails", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), "/home/coder/myproject/plan.md", int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader("# Nested Plan")), "text/markdown", nil)
|
|
|
|
storeFile, stored := fakeStoreFile(t)
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
return "", "", xerrors.New("workspace unavailable")
|
|
},
|
|
)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/myproject/plan.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.False(t, resp.IsError)
|
|
|
|
result := decodeProposePlanResponse(t, resp)
|
|
assert.True(t, result.OK)
|
|
assert.Equal(t, "/home/coder/myproject/plan.md", result.Path)
|
|
assert.Equal(t, []byte("# Nested Plan"), *stored)
|
|
})
|
|
|
|
t.Run("PlanTurnDefaultsEmptyPathToResolvedPath", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
chatPlanPath := "/home/coder/.coder/plans/PLAN-chat.md"
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), chatPlanPath, int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader("# Plan")), "text/markdown", nil)
|
|
|
|
storeFile, stored := fakeStoreFile(t)
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
return chatPlanPath, "/home/coder", nil
|
|
},
|
|
true,
|
|
)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":""}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.False(t, resp.IsError)
|
|
|
|
result := decodeProposePlanResponse(t, resp)
|
|
assert.True(t, result.OK)
|
|
assert.Equal(t, chatPlanPath, result.Path)
|
|
assert.Equal(t, "plan", result.Kind)
|
|
assert.Equal(t, "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee", result.FileID)
|
|
assert.Equal(t, "text/markdown", result.MediaType)
|
|
assert.Equal(t, "# Plan", string(*stored))
|
|
})
|
|
|
|
t.Run("PlanTurnRejectsWrongPath", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
chatPlanPath := "/home/coder/.coder/plans/PLAN-chat.md"
|
|
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
storeFile,
|
|
func(context.Context) (string, string, error) {
|
|
return chatPlanPath, "/home/coder", nil
|
|
},
|
|
true,
|
|
)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/README.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Equal(t, "during plan turns, propose_plan path must be "+chatPlanPath, resp.Content)
|
|
})
|
|
|
|
t.Run("PlanTurnRejectsEmptyPlan", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
chatPlanPath := "/home/coder/.coder/plans/PLAN-chat.md"
|
|
|
|
mockConn.EXPECT().
|
|
ReadFile(gomock.Any(), chatPlanPath, int64(0), int64(32*1024+1)).
|
|
Return(io.NopCloser(strings.NewReader("")), "text/markdown", nil)
|
|
|
|
storeFile, stored := fakeStoreFile(t)
|
|
storeCalled := false
|
|
tool := newProposePlanToolWithPlanPath(
|
|
t,
|
|
mockConn,
|
|
func(ctx context.Context, name string, detectName string, data []byte) (chattool.AttachmentMetadata, error) {
|
|
storeCalled = true
|
|
return storeFile(ctx, name, detectName, data)
|
|
},
|
|
func(context.Context) (string, string, error) {
|
|
return chatPlanPath, "/home/coder", nil
|
|
},
|
|
true,
|
|
)
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"` + chatPlanPath + `"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Contains(t, resp.Content, "plan file is empty")
|
|
assert.Contains(t, resp.Content, chatPlanPath)
|
|
assert.False(t, storeCalled)
|
|
assert.Nil(t, *stored)
|
|
})
|
|
|
|
t.Run("WorkspaceConnectionError", func(t *testing.T) {
|
|
t.Parallel()
|
|
storeFile, _ := fakeStoreFile(t)
|
|
tool := chattool.ProposePlan(chattool.ProposePlanOptions{
|
|
GetWorkspaceConn: func(context.Context) (workspacesdk.AgentConn, error) {
|
|
return nil, xerrors.New("connection failed")
|
|
},
|
|
StoreFile: storeFile,
|
|
})
|
|
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Contains(t, resp.Content, "connection failed")
|
|
})
|
|
|
|
t.Run("NilWorkspaceResolver", func(t *testing.T) {
|
|
t.Parallel()
|
|
tool := chattool.ProposePlan(chattool.ProposePlanOptions{})
|
|
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Contains(t, resp.Content, "workspace connection resolver is not configured")
|
|
})
|
|
|
|
t.Run("NilStoreFile", func(t *testing.T) {
|
|
t.Parallel()
|
|
ctrl := gomock.NewController(t)
|
|
mockConn := agentconnmock.NewMockAgentConn(ctrl)
|
|
|
|
tool := chattool.ProposePlan(chattool.ProposePlanOptions{
|
|
GetWorkspaceConn: func(_ context.Context) (workspacesdk.AgentConn, error) {
|
|
return mockConn, nil
|
|
},
|
|
})
|
|
|
|
resp, err := tool.Run(context.Background(), fantasy.ToolCall{
|
|
ID: "call-1",
|
|
Name: "propose_plan",
|
|
Input: `{"path":"/home/coder/PLAN.md"}`,
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, resp.IsError)
|
|
assert.Contains(t, resp.Content, "file storage is not configured")
|
|
})
|
|
}
|
|
|
|
func newProposePlanTool(
|
|
t *testing.T,
|
|
mockConn *agentconnmock.MockAgentConn,
|
|
storeFile chattool.StoreFileFunc,
|
|
) fantasy.AgentTool {
|
|
t.Helper()
|
|
return newProposePlanToolWithPlanPath(t, mockConn, storeFile, nil)
|
|
}
|
|
|
|
func newProposePlanToolWithPlanPath(
|
|
t *testing.T,
|
|
mockConn *agentconnmock.MockAgentConn,
|
|
storeFile chattool.StoreFileFunc,
|
|
resolvePlanPath func(context.Context) (string, string, error),
|
|
isPlanTurn ...bool,
|
|
) fantasy.AgentTool {
|
|
t.Helper()
|
|
enabled := false
|
|
if len(isPlanTurn) > 0 {
|
|
enabled = isPlanTurn[0]
|
|
}
|
|
return chattool.ProposePlan(chattool.ProposePlanOptions{
|
|
GetWorkspaceConn: func(_ context.Context) (workspacesdk.AgentConn, error) {
|
|
return mockConn, nil
|
|
},
|
|
ResolvePlanPath: resolvePlanPath,
|
|
StoreFile: storeFile,
|
|
IsPlanTurn: enabled,
|
|
})
|
|
}
|
|
|
|
func fakeStoreFile(t *testing.T) (chattool.StoreFileFunc, *[]byte) {
|
|
t.Helper()
|
|
|
|
var stored []byte
|
|
return func(_ context.Context, name string, detectName string, data []byte) (chattool.AttachmentMetadata, error) {
|
|
assert.NotEmpty(t, name)
|
|
assert.NotEmpty(t, detectName)
|
|
stored = append([]byte(nil), data...)
|
|
return chattool.AttachmentMetadata{
|
|
FileID: uuid.MustParse("aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee"),
|
|
MediaType: "text/markdown",
|
|
Name: name,
|
|
}, nil
|
|
}, &stored
|
|
}
|
|
|
|
func decodeProposePlanResponse(t *testing.T, resp fantasy.ToolResponse) proposePlanResponse {
|
|
t.Helper()
|
|
|
|
var result proposePlanResponse
|
|
require.NoError(t, json.Unmarshal([]byte(resp.Content), &result))
|
|
return result
|
|
}
|