mirror of
https://github.com/coder/coder.git
synced 2026-06-04 13:38:21 +00:00
Michael Suchacz
a554de372a
> This PR was authored by Mux on behalf of Mike. Chats sharing one workspace (e.g. sibling subagents) all wrote to `/home/coder/PLAN.md`, causing plan file collisions. This change derives a unique plan path per chat from the workspace home directory and chat ID. ## Changes * `write_file`, `edit_files`, and `propose_plan` reject any `plan.md` variant (case-insensitive) at the workspace home root, with a clear error pointing to the chat-specific path. * Root chats receive a `<plan-file-path>` block inlined in the main system prompt with the concrete path. * Prompt and tool descriptions no longer hardcode `/home/coder/PLAN.md`. * Plan path handling is POSIX-only (forward-slash), relying on the contract that workspace agent paths are normalized before reaching chatd. * Updated `ProposePlanTool.stories.tsx` to use per-chat path examples. * Full test coverage for plan path detection, legacy-path rejection in all three tools, inline prompt rendering, and fallback behavior.
69 lines
2.0 KiB
Go
69 lines
2.0 KiB
Go
package chattool
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
|
|
"charm.land/fantasy"
|
|
|
|
"github.com/coder/coder/v2/codersdk/workspacesdk"
|
|
)
|
|
|
|
type WriteFileOptions struct {
|
|
GetWorkspaceConn func(context.Context) (workspacesdk.AgentConn, error)
|
|
ResolvePlanPath func(context.Context) (chatPath string, home string, err error)
|
|
}
|
|
|
|
type WriteFileArgs struct {
|
|
Path string `json:"path"`
|
|
Content string `json:"content"`
|
|
}
|
|
|
|
func WriteFile(options WriteFileOptions) fantasy.AgentTool {
|
|
return fantasy.NewAgentTool(
|
|
"write_file",
|
|
"Write a file to the workspace.",
|
|
func(ctx context.Context, args WriteFileArgs, _ fantasy.ToolCall) (fantasy.ToolResponse, error) {
|
|
if options.GetWorkspaceConn == nil {
|
|
return fantasy.NewTextErrorResponse("workspace connection resolver is not configured"), nil
|
|
}
|
|
conn, err := options.GetWorkspaceConn(ctx)
|
|
if err != nil {
|
|
return fantasy.NewTextErrorResponse(err.Error()), nil
|
|
}
|
|
return executeWriteFileTool(ctx, conn, args, options.ResolvePlanPath)
|
|
},
|
|
)
|
|
}
|
|
|
|
func executeWriteFileTool(
|
|
ctx context.Context,
|
|
conn workspacesdk.AgentConn,
|
|
args WriteFileArgs,
|
|
resolvePlanPath func(context.Context) (chatPath string, home string, err error),
|
|
) (fantasy.ToolResponse, error) {
|
|
requestedPath := strings.TrimSpace(args.Path)
|
|
if requestedPath == "" {
|
|
return fantasy.NewTextErrorResponse("path is required"), nil
|
|
}
|
|
|
|
hasPlanFileName := looksLikePlanFileName(requestedPath)
|
|
if hasPlanFileName && !isAbsolutePath(requestedPath) {
|
|
return fantasy.NewTextErrorResponse(
|
|
"plan files must use absolute paths; use the chat-specific absolute plan path",
|
|
), nil
|
|
}
|
|
|
|
if resolvePlanPath != nil && hasPlanFileName {
|
|
chatPath, home, err := resolvePlanPath(ctx)
|
|
if resp, rejected := rejectSharedPlanPath(requestedPath, home, chatPath, err); rejected {
|
|
return resp, nil
|
|
}
|
|
}
|
|
|
|
if err := conn.WriteFile(ctx, requestedPath, strings.NewReader(args.Content)); err != nil {
|
|
return fantasy.NewTextErrorResponse(err.Error()), nil
|
|
}
|
|
return toolResponse(map[string]any{"ok": true}), nil
|
|
}
|