mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
cd54861e4f
> Mux is updating this PR on behalf of Mike. ## Summary - Set a UTF-8 `LC_CTYPE` fallback for reconnecting PTYs when no effective UTF-8 locale is present. - Preserve non-empty `LC_ALL` so explicit user locale choices still win. - Add tmux glyph regression coverage for reconnecting PTYs, plus unit coverage for the env helper. - Stabilize the tmux regression by keeping the pane alive until the glyph output is observed. - Keep the env helper unit test expectations OS-aware for Windows and cover unhyphenated UTF8 locales. ## Validation - `go test ./agent/reconnectingpty -run TestWithTerminalEnv -count=1` - `go test ./agent -run '^TestAgent_ReconnectingPTY$/Buffered$' -count=1` - `go test ./agent -run '^TestAgent_ReconnectingPTY$' -count=1` - `make lint` - `git commit` pre-commit hook - `git push` pre-push hook