Cian Johnston 2f55e29466 fix: complete job and mark workspace as deleted when no provisioners are available (#18465) ...

Alternate fix for https://github.com/coder/coder/issues/18080

Modifies wsbuilder to complete the provisioner job and mark the
workspace as deleted if it is clear that no provisioner will be able to
pick up the delete build.

This has a significant advantage of not deviating too much from the
current semantics of `POST /api/v2/workspacebuilds`.
https://github.com/coder/coder/pull/18460 ends up returning a 204 on
orphan delete due to no build being created.

Downside is that we have to duplicate some responsibilities of
provisionerdserver in wsbuilder.

There is a slight gotcha to this approach though: if you stop a
provisioner and then immediately try to orphan-delete, the job will
still be created because of the provisioner heartbeat interval. However
you can cancel it and try again.

2025-06-23 14:07:42 +01:00

..

clilog

test: fix use of t.Logf where t.Log would suffice (#16328)

2025-01-29 14:35:04 +00:00

clitest

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

cliui

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

cliutil

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

config

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

exptest

test(cli/exptest): fix context in TestScaleTestWorkspaceTraffic_UseHostLogin (#16171)

2025-01-17 14:51:24 +02:00

gitauth

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

telemetry

refactor(coderd/telemetry): move CLI telemetry to cli/telemetry (#9517)

2023-09-04 21:42:45 +03:00

testdata

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

agent_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

agent_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

agent.go

feat(agent/agentcontainers): implement sub agent injection (#18245)

2025-06-10 12:37:54 +03:00

autoupdate_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

autoupdate.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

completion.go

chore: skip completion install prompts in non-interactive shells (#14391)

2024-08-22 15:40:53 +10:00

configssh_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

configssh_other.go

fix: handle paths with spaces in Match exec clause of SSH config (#18266)

2025-06-06 16:44:25 +04:00

configssh_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

configssh_windows.go

fix: handle paths with spaces in Match exec clause of SSH config (#18266)

2025-06-06 16:44:25 +04:00

configssh.go

fix: handle paths with spaces in Match exec clause of SSH config (#18266)

2025-06-06 16:44:25 +04:00

connect_test.go

feat: add coder connect exists hidden subcommand (#17418)

2025-04-17 11:23:24 +04:00

connect.go

feat: add coder connect exists hidden subcommand (#17418)

2025-04-17 11:23:24 +04:00

create_test.go

test(cli): fix data race in TestCreateWithRichParameters (#17128)

2025-03-28 14:02:58 +00:00

create.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

delete_test.go

fix: complete job and mark workspace as deleted when no provisioners are available (#18465)

2025-06-23 14:07:42 +01:00

delete.go

fix: unify coder create and coder delete help message (#15752)

2024-12-05 12:32:52 +11:00

dotfiles_other.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

dotfiles_test.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

dotfiles_windows.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

dotfiles.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

exp_errors_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

exp_errors.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

exp_mcp_test.go

feat: add idle app status (#18415)

2025-06-20 14:34:31 -08:00

exp_mcp.go

feat: add idle app status (#18415)

2025-06-20 14:34:31 -08:00

exp_prompts.go

feat(cli): add experimental rpty command (#16700)

2025-02-26 12:32:57 +00:00

exp_rpty_test.go

feat(agent/agentcontainers): implement sub agent injection (#18245)

2025-06-10 12:37:54 +03:00

exp_rpty.go

feat(agent/reconnectingpty): allow selecting backend type (#17011)

2025-03-20 13:45:31 +00:00

exp_scaletest_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

exp_scaletest_test.go

chore(cli): skip scaletest tests when race detector enabled (#16033)

2025-01-03 23:08:51 +02:00

exp_scaletest.go

chore: rollback PR #18081 (#18104)

2025-05-29 13:12:13 -03:00

exp.go

feat(cli): add coder exp mcp command (#17066)

2025-03-31 18:52:09 +01:00

externalauth_test.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

externalauth.go

feat: add status watcher to MCP server (#18320)

2025-06-13 12:53:43 -08:00

favorite_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

favorite.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

gitaskpass_test.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

gitaskpass.go

feat: add status watcher to MCP server (#18320)

2025-06-13 12:53:43 -08:00

gitssh_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

gitssh.go

feat: add status watcher to MCP server (#18320)

2025-06-13 12:53:43 -08:00

help.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

help.tpl

feat(cli): colorize help page (#9589)

2023-09-08 18:21:33 +00:00

list_test.go

fix: display the correct response for coder list (#16547)

2025-02-13 10:13:20 -05:00

list.go

chore: rollback PR #18081 (#18104)

2025-05-29 13:12:13 -03:00

login_test.go

feat: expose premium trial form via CLI (#15054)

2024-10-29 13:02:20 +00:00

login.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

logout_test.go

fix: enrich the notLoggedInMessage error message with the full path to the coder (#17715)

2025-05-12 11:45:24 -07:00

logout.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

netcheck_test.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

netcheck.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

notifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

notifications.go

feat: add tool to send a test notification (#16611)

2025-02-19 13:08:38 +00:00

open_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

open_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

open.go

chore: rollback PR #18081 (#18104)

2025-05-29 13:12:13 -03:00

organization_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organization.go

chore: add cli command to fetch group sync settings as json (#14694)

2024-09-17 14:08:33 -05:00

organizationmanage.go

chore: remove the double confirmation when creating an organization via the CLI (#16972)

2025-03-17 17:14:59 -04:00

organizationmembers_test.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationmembers.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationroles_test.go

chore: include custom roles in list org roles (#13336)

2024-05-23 07:54:59 -10:00

organizationroles.go

feat: split cli roles edit command into create and update commands (#17121)

2025-04-04 14:04:20 -04:00

organizationsettings.go

chore: add cli command to update organization sync settings (#15459)

2024-11-13 13:44:21 -06:00

parameter_internal_test.go

feat(cli): provide parameter values via command line (#8898)

2023-08-09 13:00:25 +02:00

parameter.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

parameterresolver.go

chore: remove coder/preview dependency from codersdk (#17939)

2025-05-20 10:45:12 -05:00

ping_internal_test.go

feat!: add summary to coder ping (#14762)

2024-09-25 13:24:23 +10:00

ping_test.go

feat(cli): add local and UTC time options to ping cmd (#16648)

2025-02-24 05:38:17 +00:00

ping.go

feat(cli): add local and UTC time options to ping cmd (#16648)

2025-02-24 05:38:17 +00:00

portforward_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

portforward_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

portforward.go

feat: change port-forward to opportunistically listen on IPv6 (#15640)

2024-11-25 16:33:28 +04:00

provisionerjobs_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs.go

feat(cli): preserve table column order (#16843)

2025-03-10 12:28:06 +00:00

provisioners_test.go

fix(coderd): add stricter authorization for provisioners endpoint (#16587)

2025-02-17 14:34:47 +02:00

provisioners.go

feat(cli): preserve table column order (#16843)

2025-03-10 12:28:06 +00:00

publickey_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

publickey.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

remoteforward.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

rename_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

rename.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

resetpassword_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

resetpassword_test.go

chore: add postgres template caching for tests (#15336)

2024-11-04 17:23:31 +01:00

resetpassword.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

restart_test.go

chore: rollback PR #18081 (#18104)

2025-05-29 13:12:13 -03:00

restart.go

feat(cli): add --provisioner-log-debug option (#14558)

2024-09-04 14:39:35 +01:00

root_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

root_test.go

feat: add coder connect exists hidden subcommand (#17418)

2025-04-17 11:23:24 +04:00

root.go

feat: add status watcher to MCP server (#18320)

2025-06-13 12:53:43 -08:00

schedule_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

schedule_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

schedule.go

chore: rollback PR #18081 (#18104)

2025-05-29 13:12:13 -03:00

server_createadminuser_test.go

chore: add postgres template caching for tests (#15336)

2024-11-04 17:23:31 +01:00

server_createadminuser.go

chore: add the --ephemeral server flag (#16126)

2025-01-20 14:31:16 +01:00

server_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

server_regenerate_vapid_keypair_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

server_regenerate_vapid_keypair.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

server_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

server_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

server.go

chore: close db properly in early exit paths in ConnectToPostgres (#18448)

2025-06-20 14:11:52 +02:00

show_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

show.go

feat(cli): display devcontainers in show command (#16515)

2025-02-11 09:20:55 +00:00

signal_unix.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

signal_windows.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

speedtest_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

speedtest.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

ssh_internal_test.go

fix(cli)!: enforce selection for multiple agents rather than use randomness (#18427)

2025-06-19 22:13:35 +03:00

ssh_other.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

ssh_windows.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh.go

fix(cli)!: enforce selection for multiple agents rather than use randomness (#18427)

2025-06-19 22:13:35 +03:00

start_test.go

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

start.go

feat(cli): start workspace in no-wait mode (#17087)

2025-03-25 13:54:53 +01:00

stat_test.go

chore: migrate to github.com/coder/clistat (#17107)

2025-03-26 10:36:53 +00:00

stat.go

chore: migrate to github.com/coder/clistat (#17107)

2025-03-26 10:36:53 +00:00

state_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

state.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

stop.go

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

support_test.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

support.go

fix(cli): ensure that the support bundle command does not panic on zero values (#14392)

2024-08-22 11:15:02 +01:00

templatecreate_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatecreate.go

chore: fix docs/admin links and upgrade notice (#15043)

2024-11-01 19:43:51 +00:00

templatedelete_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templatedelete.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templateedit_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

templateedit.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

templateinit_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

templateinit.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

templatelist_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatelist.go

chore: include all templates in cli template list (#13841)

2024-07-09 11:04:16 -05:00

templatepull_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

templatepull.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templatepush_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

templatepush.go

fix(cli): allow specifying empty provisioner tag set with --provisioner-tag="-" (#18205)

2025-06-03 16:55:34 +01:00

templates.go

fix: remove templates plan docs (#13824)

2024-07-09 14:27:34 +00:00

templateversionarchive_test.go

feat: archive template versions to hide them from the ui (#10179)

2023-10-11 09:26:22 -05:00

templateversionarchive.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

templateversions_test.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

templateversions.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

tokens_test.go

feat(cli): support deleting tokens by id (#16341)

2025-02-12 18:18:17 +11:00

tokens.go

refactor: replace golang.org/x/exp/slices with slices (#16772)

2025-03-04 00:46:49 +11:00

update_test.go

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

update.go

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

user_delete_test.go

chore!: allow CreateUser to accept multiple organizations (#14383)

2024-08-23 21:23:51 +00:00

usercreate_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

usercreate.go

docs: add section on how to retrieve user list (#17798)

2025-05-13 20:48:16 +00:00

userdelete.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

usereditroles_test.go

feat: add edit-role within user command (#17341)

2025-04-15 18:30:20 -04:00

usereditroles.go

chore: avoid depending on rbac in slim builds (#17959)

2025-05-22 19:48:23 +10:00

userlist_test.go

fix: enrich the notLoggedInMessage error message with the full path to the coder (#17715)

2025-05-12 11:45:24 -07:00

userlist.go

docs: add section on how to retrieve user list (#17798)

2025-05-13 20:48:16 +00:00

users.go

feat: add edit-role within user command (#17341)

2025-04-15 18:30:20 -04:00

userstatus_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

userstatus.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

util_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

version_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

version.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

vpndaemon_other.go

chore: add vpn-daemon run subcommand for windows (#15526)

2024-11-18 21:10:01 +10:00

vpndaemon_windows_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

vpndaemon_windows.go

chore(vpn): send info, debug logs over tunnel (#18240)

2025-06-06 14:31:27 +10:00

vpndaemon.go

chore: add vpn-daemon run subcommand for windows (#15526)

2024-11-18 21:10:01 +10:00

vscodessh_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

vscodessh.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

whoami_test.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00

whoami.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00