coder

mirror of https://github.com/coder/coder.git synced 2026-06-03 04:58:23 +00:00

Files

T

Thomas Kosiewski 7b06fc77ae refactor: simplify OAuth2 authorization flow and use 302 redirects (#18923 )

# Refactor OAuth2 Provider Authorization Flow

This PR refactors the OAuth2 provider authorization flow by:

1. Removing the `authorizeMW` middleware and directly implementing its functionality in the `ShowAuthorizePage` handler
2. Simplifying function signatures by removing unnecessary parameters:
   - Removed `db` parameter from `ShowAuthorizePage`
   - Removed `accessURL` parameter from `ProcessAuthorize`
3. Changing the redirect status code in `ProcessAuthorize` from 307 (Temporary Redirect) to 302 (Found) to improve compatibility with external OAuth2 apps and browsers. (Technical explanation: we replied with a 307 to a POST request, thus the browser performs a redirect to that URL as a POST request, but we need it to be a GET request to be compatible. Thus, we use the 302 redirect so that browsers turn it into a GET request when redirecting back to the redirect_uri.)

The changes maintain the same functionality while simplifying the code and improving compatibility with external systems.

2025-07-20 16:22:52 +02:00

oidctest

refactor: simplify OAuth2 authorization flow and use 302 redirects (#18923 )

2025-07-20 16:22:52 +02:00

promhelp

chore: add tx metrics and logs for serialization errors (#15215 )

2024-10-25 12:14:15 -04:00

testjar

chore: add custom samesite options to auth cookies (#16885 )

2025-04-08 14:15:14 -05:00

authorize_test.go

chore: convert dbauthz tests to also run with Postgres (#15862 )