mirror of
https://github.com/coder/coder.git
synced 2026-06-05 05:58:20 +00:00
909acbc833
Adds a `sharing add` command for sharing Workspaces with other users and groups. The command allows sharing with multiple users, and groups within one command as well as specifying the role (`use`, or `admin`) defaulting to `use` if none is specified. In the current implementation when the command completes we show the user the current state of the workspace ACL. ``` $ coder sharing add apricot-catfish-86 --user=member:admin --group=contractors:use USER GROUP ROLE member - admin member contractors use ``` If a user is a part of multiple groups, or the workspace has been individually shared with them they will show up multiple times. Although this is a bit confusing at first glance it's important to be able to tell what the maximum role a user may have, and via what ACL they have it. --- One piece of UX to consider is that in order to be able to share a Workspace with a user they must have a role that can read that user. In the tests we give the user the `ScopedRoleOrgAuditor` role. Closes [coder/internal#859](https://github.com/coder/internal/issues/859)
232 lines
6.0 KiB
Go
232 lines
6.0 KiB
Go
package cli
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
|
|
"golang.org/x/xerrors"
|
|
|
|
"github.com/coder/coder/v2/cli/cliui"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/serpent"
|
|
)
|
|
|
|
const defaultGroupDisplay = "-"
|
|
|
|
type workspaceShareRow struct {
|
|
User string `table:"user"`
|
|
Group string `table:"group,default_sort"`
|
|
Role codersdk.WorkspaceRole `table:"role"`
|
|
}
|
|
|
|
func (r *RootCmd) sharing() *serpent.Command {
|
|
orgContext := NewOrganizationContext()
|
|
|
|
cmd := &serpent.Command{
|
|
Use: "sharing [subcommand]",
|
|
Short: "Commands for managing shared workspaces",
|
|
Aliases: []string{"share"},
|
|
Handler: func(inv *serpent.Invocation) error {
|
|
return inv.Command.HelpHandler(inv)
|
|
},
|
|
Children: []*serpent.Command{r.shareWorkspace(orgContext)},
|
|
Hidden: true,
|
|
}
|
|
|
|
orgContext.AttachOptions(cmd)
|
|
return cmd
|
|
}
|
|
|
|
func (r *RootCmd) shareWorkspace(orgContext *OrganizationContext) *serpent.Command {
|
|
var (
|
|
// Username regex taken from codersdk/name.go
|
|
nameRoleRegex = regexp.MustCompile(`(^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*)+(?::([A-Za-z0-9-]+))?`)
|
|
client = new(codersdk.Client)
|
|
users []string
|
|
groups []string
|
|
formatter = cliui.NewOutputFormatter(
|
|
cliui.TableFormat(
|
|
[]workspaceShareRow{}, []string{"User", "Group", "Role"}),
|
|
cliui.JSONFormat(),
|
|
)
|
|
)
|
|
|
|
cmd := &serpent.Command{
|
|
Use: "add <workspace> --user <user>:<role> --group <group>:<role>",
|
|
Aliases: []string{"share"},
|
|
Short: "Share a workspace with a user or group.",
|
|
Options: serpent.OptionSet{
|
|
{
|
|
Name: "user",
|
|
Description: "A comma separated list of users to share the workspace with.",
|
|
Flag: "user",
|
|
Value: serpent.StringArrayOf(&users),
|
|
}, {
|
|
Name: "group",
|
|
Description: "A comma separated list of groups to share the workspace with.",
|
|
Flag: "group",
|
|
Value: serpent.StringArrayOf(&groups),
|
|
},
|
|
},
|
|
Middleware: serpent.Chain(
|
|
r.InitClient(client),
|
|
serpent.RequireNArgs(1),
|
|
),
|
|
Handler: func(inv *serpent.Invocation) error {
|
|
if len(users) == 0 && len(groups) == 0 {
|
|
return xerrors.New("at least one user or group must be provided")
|
|
}
|
|
|
|
workspace, err := namedWorkspace(inv.Context(), client, inv.Args[0])
|
|
if err != nil {
|
|
return xerrors.Errorf("could not fetch the workspace %s: %w", inv.Args[0], err)
|
|
}
|
|
|
|
org, err := orgContext.Selected(inv, client)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
userRoles := make(map[string]codersdk.WorkspaceRole, len(users))
|
|
if len(users) > 0 {
|
|
orgMembers, err := client.OrganizationMembers(inv.Context(), org.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, user := range users {
|
|
userAndRole := nameRoleRegex.FindStringSubmatch(user)
|
|
if userAndRole == nil {
|
|
return xerrors.Errorf("invalid user format %q: must match pattern 'username:role'", user)
|
|
}
|
|
|
|
username := userAndRole[1]
|
|
role := userAndRole[2]
|
|
if role == "" {
|
|
role = string(codersdk.WorkspaceRoleUse)
|
|
}
|
|
|
|
userID := ""
|
|
for _, member := range orgMembers {
|
|
if member.Username == username {
|
|
userID = member.UserID.String()
|
|
break
|
|
}
|
|
}
|
|
if userID == "" {
|
|
return xerrors.Errorf("could not find user %s in the organization %s", username, org.Name)
|
|
}
|
|
|
|
workspaceRole, err := stringToWorkspaceRole(role)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
userRoles[userID] = workspaceRole
|
|
}
|
|
}
|
|
|
|
groupRoles := make(map[string]codersdk.WorkspaceRole)
|
|
if len(groups) > 0 {
|
|
orgGroups, err := client.Groups(inv.Context(), codersdk.GroupArguments{
|
|
Organization: org.ID.String(),
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, group := range groups {
|
|
groupAndRole := nameRoleRegex.FindStringSubmatch(group)
|
|
if groupAndRole == nil {
|
|
return xerrors.Errorf("invalid group format %q: must match pattern 'group:role'", group)
|
|
}
|
|
groupName := groupAndRole[1]
|
|
role := groupAndRole[2]
|
|
if role == "" {
|
|
role = string(codersdk.WorkspaceRoleUse)
|
|
}
|
|
|
|
var orgGroup *codersdk.Group
|
|
for _, group := range orgGroups {
|
|
if group.Name == groupName {
|
|
orgGroup = &group
|
|
break
|
|
}
|
|
}
|
|
|
|
if orgGroup == nil {
|
|
return xerrors.Errorf("could not find group named %s belonging to the organization %s", groupName, org.Name)
|
|
}
|
|
|
|
workspaceRole, err := stringToWorkspaceRole(role)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
groupRoles[orgGroup.ID.String()] = workspaceRole
|
|
}
|
|
}
|
|
|
|
err = client.UpdateWorkspaceACL(inv.Context(), workspace.ID, codersdk.UpdateWorkspaceACL{
|
|
UserRoles: userRoles,
|
|
GroupRoles: groupRoles,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
workspaceACL, err := client.WorkspaceACL(inv.Context(), workspace.ID)
|
|
if err != nil {
|
|
return xerrors.Errorf("could not fetch current workspace ACL after sharing %w", err)
|
|
}
|
|
|
|
outputRows := make([]workspaceShareRow, 0)
|
|
for _, user := range workspaceACL.Users {
|
|
if user.Role == codersdk.WorkspaceRoleDeleted {
|
|
continue
|
|
}
|
|
|
|
outputRows = append(outputRows, workspaceShareRow{
|
|
User: user.Username,
|
|
Group: defaultGroupDisplay,
|
|
Role: user.Role,
|
|
})
|
|
}
|
|
for _, group := range workspaceACL.Groups {
|
|
if group.Role == codersdk.WorkspaceRoleDeleted {
|
|
continue
|
|
}
|
|
|
|
for _, user := range group.Members {
|
|
outputRows = append(outputRows, workspaceShareRow{
|
|
User: user.Username,
|
|
Group: group.Name,
|
|
Role: group.Role,
|
|
})
|
|
}
|
|
}
|
|
out, err := formatter.Format(inv.Context(), outputRows)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
_, err = fmt.Fprintln(inv.Stdout, out)
|
|
return err
|
|
},
|
|
}
|
|
|
|
return cmd
|
|
}
|
|
|
|
func stringToWorkspaceRole(role string) (codersdk.WorkspaceRole, error) {
|
|
switch role {
|
|
case string(codersdk.WorkspaceRoleUse):
|
|
return codersdk.WorkspaceRoleUse, nil
|
|
case string(codersdk.WorkspaceRoleAdmin):
|
|
return codersdk.WorkspaceRoleAdmin, nil
|
|
default:
|
|
return "", xerrors.Errorf("invalid role %q: expected %q or %q",
|
|
role, codersdk.WorkspaceRoleAdmin, codersdk.WorkspaceRoleUse)
|
|
}
|
|
}
|