coder

mirror of https://github.com/coder/coder.git synced 2026-06-02 20:48:20 +00:00

Files

T

Cian Johnston 3f55b35f68 refactor: replace AsSystemRestricted with narrower actors (#23712 )

Replace overly-broad `AsSystemRestricted` with purpose-built actors:

- **OAuth2 provider paths** → `AsSystemOAuth2` (13 call sites across
`tokens.go`, `registration.go`, `apikey.go`)
- **Provisioner daemon health read** → `AsSystemReadProvisionerDaemons`
(1 site in `healthcheck/provisioner.go`)
- **Provisionerd file cache paths** → `AsProvisionerd` (2 sites in
`provisionerdserver.go`, matching existing usage nearby)

<details>
<summary>Implementation notes</summary>

Each replacement actor is a strict subset of `AsSystemRestricted`. Every
DB method
at each call site is already covered by the narrower actor's
permissions:

- `subjectSystemOAuth2`: OAuth2App/Secret/CodeToken (all), ApiKey (Read,
Delete), User (Read), Organization (Read)
- `subjectSystemReadProvisionerDaemons`: ProvisionerDaemon (Read)
- `subjectProvisionerd`: File (Create, Read) plus provisionerd-scoped
resources

No new permissions added. `nolint:gocritic` comments updated to reflect
the new actors.
</details>

> 🤖 Created by a Coder Agent, reviewed by me.

2026-03-27 15:08:30 +00:00

acquirer_test.go

chore: remove unnecessary redeclarations in for loops (#18440 )

2025-06-20 13:16:55 -06:00

acquirer.go

chore: arrange imports in a standard way (#21452 )

2026-01-08 15:24:11 +04:00

mergeenvs_test.go

feat: add merge_strategy support for coder_env resources (#23107 )

2026-03-18 15:43:28 +01:00

metrics.go

feat: add provisioner job queue wait time histogram and jobs enqueued counter (#21869 )