Danielle Maywood 409360c62d fix(coderd): ensure inbox WebSocket is closed when client disconnects (#21652) ...

Relates to https://github.com/coder/coder/issues/19715

This is similar to https://github.com/coder/coder/pull/19711

This endpoint works by doing the following:
- Subscribing to the database's with pubsub
- Accepts a WebSocket upgrade
- Starts a `httpapi.Heartbeat`
- Creates a json encoder
- **Infinitely loops waiting for notification until request context
cancelled**

The critical issue here is that `httpapi.Heartbeat` silently fails when
the client has disconnected. This means we never cancel the request
context, leaving the WebSocket alive until we receive a notification
from the database and fail to write that down the pipe.

By replacing usage of `httpapi.Heartbeat` with `httpapi.HeartbeatClose`,
we cancel the context _when the heartbeat fails to write_ due to the
client disconnecting. This allows us to cleanup without waiting for a
notification to come through the pubsub channel.

2026-01-26 09:24:45 +00:00

..

agentapi

perf: reduce pg_notify call volume by batching together agent metadata updates (#21330)

2026-01-22 22:47:49 -08:00

agentmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

aibridge

feat: use coder specific header for aibridge authentication from AI proxy (#21590)

2026-01-21 19:06:19 +00:00

apidoc

feat: support custom bedrock base url (#21582)

2026-01-21 12:48:56 +00:00

apikey

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

appearance

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

audit

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

autobuild

feat(coderd): bump workspace deadline on AI agent activity (#21584)

2026-01-22 13:52:32 +02:00

awsidentity

fix: add new aws regions to instance identity (#10434)

2023-10-30 19:44:29 +00:00

azureidentity

chore: update azure certs (#21265)

2025-12-15 13:44:44 -09:00

coderdtest

perf: reduce pg_notify call volume by batching together agent metadata updates (#21330)

2026-01-22 22:47:49 -08:00

connectionlog

fix: avoid connection logging crashes in agent (#20307)

2025-10-16 01:56:43 +11:00

cryptokeys

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

database

perf: reduce pg_notify call volume by batching together agent metadata updates (#21330)

2026-01-22 22:47:49 -08:00

devtunnel

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

dynamicparameters

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

entitlements

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

externalauth

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

files

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

gitsshkey

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

healthcheck

chore: improve healthcheck timeout message (#21520)

2026-01-15 16:37:05 +00:00

httpapi

refactor: add RFC-compliant enum types and use SDK as source of truth (#21468)

2026-01-15 12:41:28 +03:00

httpmw

fix(coderd): allow agent auth during workspace shutdown (#21538)

2026-01-21 13:18:43 +00:00

idpsync

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

jobreaper

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

jwtutils

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

mcp

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

metricscache

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

notifications

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

oauth2provider

refactor: add RFC-compliant enum types and use SDK as source of truth (#21468)

2026-01-15 12:41:28 +03:00

oauthpki

fix(coderd): support string type for oidc response's expires_in json property (#20152)

2025-10-15 17:37:37 +00:00

portsharing

fix: properly convert max port share level for oss (#13261)

2024-05-13 14:37:51 -04:00

pproflabel

chore: add usage tracking package (#19095)

2025-08-16 01:31:00 +10:00

prebuilds

fix: limit concurrent database connections in prebuild reconciliation (#20908)

2026-01-21 10:56:31 +00:00

prometheusmetrics

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

promoauth

feat!: support PKCE in the oauth2 client's auth/exchange flow (#21215)

2025-12-15 17:41:47 +00:00

provisionerdserver

chore!: send modules archive over the proto messages (#21398)

2026-01-09 11:33:34 -06:00

provisionerkey

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

proxyhealth

feat: add csp headers for embedded apps (#18374)

2025-06-17 09:00:32 -08:00

pubsub

feat(coderd): add inbox notifications endpoints (#16889)

2025-03-18 00:02:47 +01:00

rbac

fix(coderd/rbac): reinstate deployment-wide workspace.share permission for owner role (#21620)

2026-01-22 08:12:15 -08:00

render

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

runtimeconfig

chore(coderd/runtimeconfig): remove dbmem from tests (#18790)

2025-07-08 14:31:05 +00:00

schedule

chore: improve build deadline code (#19203)

2025-08-07 11:00:31 +10:00

searchquery

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

taskname

fix: replace moby/moby namesgenerator with internal implementation (#21377)

2026-01-09 15:40:26 -07:00

telemetry

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

testdata

feat: add flag to disable template insights (#20940)

2025-12-14 03:00:03 +00:00

tracing

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

updatecheck

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

usage

chore: add unknown usage event type error (#19436)

2025-08-22 16:32:35 +10:00

userpassword

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util

fix: replace moby/moby namesgenerator with internal implementation (#21377)

2026-01-09 15:40:26 -07:00

webpush

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

workspaceapps

perf: reduce number of queries made by /api/v2/workspaceagents/{id} (#21522)

2026-01-19 12:36:33 +00:00

workspacestats

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

wsbuilder

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

wspubsub

feat: add app status tracking to the backend (#17163)

2025-03-31 10:55:44 -04:00

activitybump_test.go

chore: distinct operations for provisioner's 'parse', 'init', 'plan', 'apply', 'graph' (#21064)

2025-12-15 11:26:41 -06:00

aitasks_internal_test.go

fix: set codersdk.Task current_state during task initialization (#20692)

2025-11-17 13:24:12 +00:00

aitasks_test.go

test: use deterministic time to avoid time-based flake (#21396)

2025-12-29 14:25:14 +00:00

aitasks.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

apikey_scopes_validation_test.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

apikey_test.go

feat: add allow list to API keys (#19972)

2025-10-24 12:33:56 +01:00

apikey.go

fix: replace moby/moby namesgenerator with internal implementation (#21377)

2026-01-09 15:40:26 -07:00

apiroot.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

audit_internal_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit_test.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

audit.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

authorize_test.go

feat: add an organization member permission level (#19953)

2025-10-27 17:14:16 -06:00

authorize.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

client_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

coderd_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderd_test.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

coderd.go

perf: reduce pg_notify call volume by batching together agent metadata updates (#21330)

2026-01-22 22:47:49 -08:00

csp.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

debug_test.go

chore: improve healthcheck timeout message (#21520)

2026-01-15 16:37:05 +00:00

debug.go

chore: improve healthcheck timeout message (#21520)

2026-01-15 16:37:05 +00:00

deployment_test.go

fix(coderd): mark provisioner daemon psk as secret (#12322)

2024-02-27 16:33:32 +00:00

deployment.go

chore: remove chats experiment (#18535)

2025-06-25 13:03:32 +00:00

deprecated.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

experiments_test.go

chore: revert dynamic params as a safe experiment (#17510)

2025-04-22 16:21:15 +00:00

experiments.go

fix: do not warn on valid known experiments (#18514)

2025-06-24 09:14:41 +01:00

externalauth_test.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

externalauth.go

feat!: support PKCE in the oauth2 client's auth/exchange flow (#21215)

2025-12-15 17:41:47 +00:00

files_test.go

ci: improve 'tfail in goroutine' ruleguard rule (#19682)

2025-09-04 14:28:29 +10:00

files.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

gitsshkey_test.go

chore: distinct operations for provisioner's 'parse', 'init', 'plan', 'apply', 'graph' (#21064)

2025-12-15 11:26:41 -06:00

gitsshkey.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

inboxnotifications_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications.go

fix(coderd): ensure inbox WebSocket is closed when client disconnects (#21652)

2026-01-26 09:24:45 +00:00

initscript_test.go

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

initscript.go

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

insights_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights_test.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

insights.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

latencycheck.go

chore: add prometheus timing to latency endpoint (#7742)

2023-06-06 10:26:13 -05:00

mcp_http.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

members_test.go

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

members.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

notifications_test.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

notifications.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

oauth2_error_compliance_test.go

refactor: add RFC-compliant enum types and use SDK as source of truth (#21468)

2026-01-15 12:41:28 +03:00

oauth2_metadata_test.go

refactor: add RFC-compliant enum types and use SDK as source of truth (#21468)

2026-01-15 12:41:28 +03:00

oauth2_metadata_validation_test.go

refactor: add RFC-compliant enum types and use SDK as source of truth (#21468)

2026-01-15 12:41:28 +03:00

oauth2_security_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_test.go

refactor: add RFC-compliant enum types and use SDK as source of truth (#21468)

2026-01-15 12:41:28 +03:00

oauth2.go

feat: implement oauth2 RFC 7009 token revocation endpoint (#20362)

2025-10-22 15:18:42 -05:00

organizations_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organizations.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

pagination_test.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

pagination.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

parameters_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

parameters.go

fix: add heartbeat to keep dynamic params websocket open (#20026)

2025-10-02 09:32:40 -05:00

presets_test.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

presets.go

feat: support icon and description in preset (#18977)

2025-07-28 15:02:26 +01:00

provisionerdaemons_test.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisionerdaemons.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisionerjobs_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs_test.go

chore: fix api param name (#20172)

2025-10-06 13:58:37 +02:00

provisionerjobs.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

roles_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

roles.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

scopes_catalog_api_test.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

scopes_catalog.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

tailnet_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

tailnet.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

templates_test.go

fix(coderd): handle rbac.NotAuthorizedError when deleting template (#21645)

2026-01-23 12:02:46 +00:00

templates.go

fix(coderd): handle rbac.NotAuthorizedError when deleting template (#21645)

2026-01-23 12:02:46 +00:00

templateversions_test.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

templateversions.go

fix: replace moby/moby namesgenerator with internal implementation (#21377)

2026-01-09 15:40:26 -07:00

updatecheck_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

userauth_test.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

userauth.go

fix: replace moby/moby namesgenerator with internal implementation (#21377)

2026-01-09 15:40:26 -07:00

users_test.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

users.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

webpush_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

webpush.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

workspaceagentportshare_test.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

workspaceagentportshare.go

docs: fix swagger documentation for DELETE port share endpoint (#18426)

2025-06-18 14:07:53 +00:00

workspaceagents_internal_test.go

perf: reduce number of queries made by /api/v2/workspaceagents/{id} (#21522)

2026-01-19 12:36:33 +00:00

workspaceagents_test.go

perf: reduce pg_notify call volume by batching together agent metadata updates (#21330)

2026-01-22 22:47:49 -08:00

workspaceagents.go

perf: reduce pg_notify call volume by batching together agent metadata updates (#21330)

2026-01-22 22:47:49 -08:00

workspaceagentsrpc_internal_test.go

test: use not before in TestAgentConnectionMonitor_* (#21332)

2025-12-22 10:21:39 +04:00

workspaceagentsrpc_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

workspaceagentsrpc.go

perf: reduce pg_notify call volume by batching together agent metadata updates (#21330)

2026-01-22 22:47:49 -08:00

workspaceapps_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

workspaceapps.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

workspacebuilds_test.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

workspacebuilds.go

perf: reduce number of queries made by /api/v2/workspaceagents/{id} (#21522)

2026-01-19 12:36:33 +00:00

workspaceproxies_test.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceproxies.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceresourceauth_test.go

chore: distinct operations for provisioner's 'parse', 'init', 'plan', 'apply', 'graph' (#21064)

2025-12-15 11:26:41 -06:00

workspaceresourceauth.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

workspaces_test.go

feat(enterprise): implement organization "disable workspace sharing" option (#21376)

2026-01-14 09:47:50 -08:00

workspaces.go

feat(enterprise): implement organization "disable workspace sharing" option (#21376)

2026-01-14 09:47:50 -08:00

workspaceupdates_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceupdates.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00