mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
Rowan Smith
9614d55400
Backport of https://github.com/coder/coder/pull/24645 to `release/2.32`.
Once a user has touched a field, it is better to leave it alone and
display explicit validation errors over silently overwriting their
inputs. Same for auto-filled values (whether from query parameters or a
previous build).
Original PR: #24645 — fix: do not clobber dynamic parameters
Merge commit: d958d89b6f
Closes #23418
<details>
<summary>Cherry-pick conflict resolution</summary>
Two conflicts resolved:
1. **`site/src/testHelpers/websockets.ts`**: File was empty on
release/2.32. Took the incoming version with the new
`mockDynamicParameterWebSocket` helper.
2.
**`site/src/pages/CreateWorkspacePage/CreateWorkspacePage.jest.tsx`**:
File is `.jest.tsx` on the release branch (`.test.tsx` on main). Applied
the incoming content (refactored websocket mocking, modernized test
calls) to the existing `.jest.tsx` filename.
</details>
> [!NOTE]
> Generated with [Coder Agents](https://coder.com) by @rowansmithau
---------
Co-authored-by: Asher <ash@coder.com>
Co-authored-by: Garrett Delfosse <delfossegarrett@gmail.com>