Cian Johnston 212aeff724 fix(cli): fix potential panic in traceError if unwrapped err is nil (#15166) ...

Seen while investigating #12721:

Root cause was a developer error, but this definitely shouldn't panic.

Before:
```
/ # coder stat
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1f12eb0]

goroutine 1 [running]:
github.com/coder/coder/v2/cli.traceError({0x90e89a0?, 0x40007a8210})
        /home/runner/work/coder/coder/cli/root.go:1119 +0x70
github.com/coder/coder/v2/cli.cliHumanFormatError({0x40003065a0, 0x1c8}, {0x90e89a0, 0x40007a8210}, 0x40007a81e0?)
        /home/runner/work/coder/coder/cli/root.go:985 +0x190
github.com/coder/coder/v2/cli.cliHumanFormatError({0x40000d0f00, 0x139}, {0x90e89a0, 0x40007a81e0}, 0x40001c4480?)
        /home/runner/work/coder/coder/cli/root.go:985 +0x1d8
github.com/coder/coder/v2/cli.cliHumanFormatError({0x40000d0b40, 0xf}, {0x90e5f00, 0x40006a3a80}, 0x90e5d40?)
        /home/runner/work/coder/coder/cli/root.go:985 +0x1d8
github.com/coder/coder/v2/cli.cliHumanFormatError({0x0, 0x0}, {0x90e5ce0, 0x40003b14c0}, 0x2?)
        /home/runner/work/coder/coder/cli/root.go:985 +0x1d8
github.com/coder/coder/v2/cli.formatRunCommandError(0x40007a8108, 0x400079fce7)
        /home/runner/work/coder/coder/cli/root.go:1057 +0x30c
github.com/coder/coder/v2/cli.cliHumanFormatError({0x0, 0x0}, {0x90e5ec0, 0x40007a8108}, 0xaa0aed0?)
        /home/runner/work/coder/coder/cli/root.go:980 +0xe0
github.com/coder/coder/v2/cli.cliHumanFormatError({0x0, 0x0}, {0x90e5160, 0x40007a8120}, 0x90e50e0?)
        /home/runner/work/coder/coder/cli/root.go:966 +0x144
github.com/coder/coder/v2/cli.(*PrettyErrorFormatter).Format(0x400079fda0, {0x90e5160?, 0x40007a8120?})
        /home/runner/work/coder/coder/cli/root.go:927 +0x48
github.com/coder/coder/v2/cli.(*RootCmd).RunWithSubcommands(0x400068ed80, {0x400053a2c8, 0x30, 0x57})
        /home/runner/work/coder/coder/cli/root.go:175 +0x278
main.main()
        /home/runner/work/coder/coder/enterprise/cmd/coder/main.go:11 +0x40
```

After:
```
Encountered an error running "coder stat", see "coder stat --help" for more information
error: <nil>
```

2024-10-21 17:12:57 +01:00

..

clilog

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

clistat

fix(cli): improve container detection when cgroupns=private (#15156)

2024-10-21 15:28:32 +01:00

clitest

chore!: allow CreateUser to accept multiple organizations (#14383)

2024-08-23 21:23:51 +00:00

cliui

feat!: add summary to coder ping (#14762)

2024-09-25 13:24:23 +10:00

cliutil

fix: serve test derp map locally (#14490)

2024-08-30 18:43:51 +10:00

config

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

exptest

fix(cli): add check for DisableOwnerWorkspaceExec in scaletest (#14417)

2024-08-26 12:02:54 +01:00

gitauth

refactor: split coderd/gitauth into two, add cli/gitauth (#9479)

2023-09-01 15:41:22 +00:00

telemetry

refactor(coderd/telemetry): move CLI telemetry to cli/telemetry (#9517)

2023-09-04 21:42:45 +03:00

testdata

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

agent_internal_test.go

fix: Port forward should ignore coder ports (#7645)

2023-05-23 17:14:05 +02:00

agent_test.go

fix: include custom agent headers in tailnet to support DERP connections (#15145)

2024-10-21 20:59:21 +11:00

agent.go

fix: support additional http headers on agent (#14464)

2024-08-29 14:15:15 +10:00

autoupdate_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

autoupdate.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

completion.go

chore: skip completion install prompts in non-interactive shells (#14391)

2024-08-22 15:40:53 +10:00

configssh_internal_test.go

fix: fix flaking Test_sshConfigExecEscape (#14233)

2024-08-12 18:56:34 +10:00

configssh_other.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh_test.go

chore: skip ssh exec-ing test on windows (#15146)

2024-10-21 04:17:20 +00:00

configssh_windows.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

create_test.go

feat: implement feature to support template version while creating workspace using cli (#14880)

2024-10-11 18:00:11 +05:00

create.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

delete_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

delete.go

feat(cli): add --provisioner-log-debug option (#14558)

2024-09-04 14:39:35 +01:00

dotfiles_test.go

fix: detect nested dotfiles scripts (#14455)

2024-08-28 02:14:23 +10:00

dotfiles.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

errors_test.go

feat(cli): add golden tests for errors (#11588) (#12698)

2024-04-01 09:19:26 -05:00

errors.go

feat(cli): add golden tests for errors (#11588) (#12698)

2024-04-01 09:19:26 -05:00

exp_scaletest_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

exp_scaletest_test.go

feat(cli/exp): add target workspace/users to scaletest commands (#11701)

2024-01-19 15:32:46 +00:00

exp_scaletest.go

fix(cli): add check for DisableOwnerWorkspaceExec in scaletest (#14417)

2024-08-26 12:02:54 +01:00

exp.go

chore: add command to render all existing cli prompts (#13689)

2024-06-27 05:20:15 -10:00

externalauth_test.go

chore: explain GIT_ASKPASS behavior in docs (#12784)

2024-03-28 13:59:03 -05:00

externalauth.go

chore: expose formatExamples enterprise commands (#13304)

2024-05-21 13:26:34 -05:00

favorite_test.go

feat(cli): add favorite/unfavorite commands (#11793)

2024-01-24 14:05:39 +00:00

favorite.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

gitaskpass_test.go

feat: add external-auth cli (#10052)

2023-10-09 23:04:35 +00:00

gitaskpass.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

gitssh_test.go

chore: refactor ResolveAutostart tests to use dbfake (#10603)

2023-11-30 19:33:04 -06:00

gitssh.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

help.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

help.tpl

feat(cli): colorize help page (#9589)

2023-09-08 18:21:33 +00:00

list_test.go

chore: refactor ResolveAutostart tests to use dbfake (#10603)

2023-11-30 19:33:04 -06:00

list.go

chore: add organization name to workspaces (#13755)

2024-07-02 09:25:05 -05:00

login_test.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

login.go

chore: improve coder server ux (#14761)

2024-09-24 13:16:36 +10:00

logout_test.go

chore: remove middleware to request version and entitlement warnings (#12750)

2024-03-25 15:01:42 -04:00

logout.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

netcheck_test.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

netcheck.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

notifications_test.go

chore: remove notifications experiment (#14869)

2024-10-01 13:43:47 +00:00

notifications.go

feat(cli): pause notifications (#13873)

2024-07-11 15:22:20 +02:00

open_internal_test.go

feat(cli): add coder open vscode (#11191)

2024-01-02 20:46:18 +02:00

open_test.go

feat(cli): add coder open vscode (#11191)

2024-01-02 20:46:18 +02:00

open.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

organization_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organization.go

chore: add cli command to fetch group sync settings as json (#14694)

2024-09-17 14:08:33 -05:00

organizationmanage.go

chore: unhide multi-organization cli commands (#14693)

2024-09-17 10:22:20 -05:00

organizationmembers_test.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationmembers.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationroles_test.go

chore: include custom roles in list org roles (#13336)

2024-05-23 07:54:59 -10:00

organizationroles.go

chore: unhide multi-organization cli commands (#14693)

2024-09-17 10:22:20 -05:00

organizationsettings.go

feat(site): add warnings and status indicator to provisioner groups (#14708)

2024-09-20 09:55:04 -06:00

parameter_internal_test.go

feat(cli): provide parameter values via command line (#8898)

2023-08-09 13:00:25 +02:00

parameter.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

parameterresolver.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

ping_internal_test.go

feat!: add summary to coder ping (#14762)

2024-09-25 13:24:23 +10:00

ping_test.go

feat!: add summary to coder ping (#14762)

2024-09-25 13:24:23 +10:00

ping.go

feat!: add summary to coder ping (#14762)

2024-09-25 13:24:23 +10:00

portforward_internal_test.go

feat: Support for comma-separation and ranges in port-forward (#4166)

2022-10-03 11:58:43 +03:00

portforward_test.go

fix(cli): port-forward: update workspace last_used_at (#12659)

2024-03-20 16:44:12 +00:00

portforward.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

prompts.go

chore: add example prompt command for multiple prompt bug (#13885)

2024-07-12 11:59:13 -05:00

publickey_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

publickey.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

remoteforward.go

feat(cli/ssh): allow multiple remote forwards and allow missing local file (#11648)

2024-01-19 15:21:10 +02:00

rename_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

rename.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

resetpassword_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

resetpassword_test.go

chore(ci): clean up databases after test finishes in CI (#12702)

2024-03-21 14:53:16 +00:00

resetpassword.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

restart_test.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

restart.go

feat(cli): add --provisioner-log-debug option (#14558)

2024-09-04 14:39:35 +01:00

root_internal_test.go

chore: expose formatExamples enterprise commands (#13304)

2024-05-21 13:26:34 -05:00

root_test.go

chore: remove middleware to request version and entitlement warnings (#12750)

2024-03-25 15:01:42 -04:00

root.go

fix(cli): fix potential panic in traceError if unwrapped err is nil (#15166)

2024-10-21 17:12:57 +01:00

schedule_internal_test.go

feat: cli: consolidate schedule-related commands (#2402)

2022-06-16 18:24:10 +01:00

schedule_test.go

chore!: allow CreateUser to accept multiple organizations (#14383)

2024-08-23 21:23:51 +00:00

schedule.go

chore: expose formatExamples enterprise commands (#13304)

2024-05-21 13:26:34 -05:00

server_createadminuser_test.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

server_createadminuser.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

server_internal_test.go

fix!: remove TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA cipher by default (#13837)

2024-07-09 17:18:27 +00:00

server_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

server_test.go

chore: improve coder server ux (#14761)

2024-09-24 13:16:36 +10:00

server.go

chore: remove notifications experiment (#14869)

2024-10-01 13:43:47 +00:00

show_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

show.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

signal_unix.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

signal_windows.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

speedtest_test.go

feat(cli): add json output to coder speedtest (#13475)

2024-06-05 08:31:44 +00:00

speedtest.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

ssh_internal_test.go

fix: close SSH sessions bottom-up if top-down fails (#14678)

2024-09-17 14:46:49 +04:00

ssh_other.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

ssh_windows.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

start_test.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

start.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

stat_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

stat.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

state_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

state.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

stop.go

feat(cli): add --provisioner-log-debug option (#14558)

2024-09-04 14:39:35 +01:00

support_test.go

fix(cli): ensure that the support bundle command does not panic on zero values (#14392)

2024-08-22 11:15:02 +01:00

support.go

fix(cli): ensure that the support bundle command does not panic on zero values (#14392)

2024-08-22 11:15:02 +01:00

templatecreate_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatecreate.go

chore: read template tar from stdin if stdin is not a tty (#14643)

2024-09-12 14:36:20 +10:00

templatedelete_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templatedelete.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templateedit_test.go

chore: remove max_ttl from templates (#12644)

2024-03-20 10:37:57 -05:00

templateedit.go

chore: align active version terminology and link to docs (#14639)

2024-09-11 12:25:07 +02:00

templateinit_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

templateinit.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

templatelist_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatelist.go

chore: include all templates in cli template list (#13841)

2024-07-09 11:04:16 -05:00

templatepull_test.go

chore: remove unnecessary extraction library (#12847)

2024-04-02 11:19:54 -04:00

templatepull.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templatepush_test.go

fix(cli): inherit provisioner tags from last template version (#13462)

2024-06-04 11:59:54 +00:00

templatepush.go

chore: read template tar from stdin if stdin is not a tty (#14643)

2024-09-12 14:36:20 +10:00

templates.go

fix: remove templates plan docs (#13824)

2024-07-09 14:27:34 +00:00

templateversionarchive_test.go

feat: archive template versions to hide them from the ui (#10179)

2023-10-11 09:26:22 -05:00

templateversionarchive.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templateversions_test.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

templateversions.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

tokens_test.go

feat: implement feature to create a token on behalf of another user in the cli (#14813)

2024-09-30 20:15:28 +00:00

tokens.go

feat(cli): extend duration to longer units (#15040)

2024-10-16 17:02:56 +02:00

update_test.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

update.go

chore(cli): rename build options to ephemeral parameters in cli (#15030)

2024-10-16 23:54:12 +02:00

user_delete_test.go

chore!: allow CreateUser to accept multiple organizations (#14383)

2024-08-23 21:23:51 +00:00

usercreate_test.go

feat: add "Full Name" field to user creation (#13659)

2024-06-26 09:00:42 +01:00

usercreate.go

feat(codersdk): export name validators (#14551)

2024-09-04 08:34:39 +00:00

userdelete.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

userlist_test.go

feat: add "Full Name" field to user creation (#13659)

2024-06-26 09:00:42 +01:00

userlist.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

users.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

userstatus_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

userstatus.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

util_internal_test.go

feat(cli): extend duration to longer units (#15040)

2024-10-16 17:02:56 +02:00

util.go

feat(cli): extend duration to longer units (#15040)

2024-10-16 17:02:56 +02:00

version_test.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

version.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

vscodessh_test.go

chore: switch ssh session stats based on experiment (#13637)

2024-06-25 10:58:45 -04:00

vscodessh.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

whoami_test.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00

whoami.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00