Mathias Fredriksson 98d5e7948d fix(coderd/autobuild): handle concurrent build number race in lifecycle executor (#25824) ...

The lifecycle executor did not handle unique-violation errors from
InsertWorkspaceBuild. When a concurrent actor (API handler, another
lifecycle executor, or prebuilds reconciler) inserts a workspace build
with the same build number, PostgreSQL returns a unique constraint
violation on workspace_builds_workspace_id_build_number_key. The
lifecycle executor treated this as a hard error, logging it and storing
it in stats.Errors.

The per-workspace advisory lock (pg_try_advisory_xact_lock) prevents
two lifecycle executors from racing, but does not protect against
races with the CreateWorkspaceBuild API handler or the prebuilds
reconciler, which use different (or no) locking.

Catch the specific unique-violation error after InTx returns (where
the transaction is already rolled back) and clear it. The concurrent
actor's build takes effect; the lifecycle executor treats the
workspace as a no-op for this tick.

Closes coder/internal#455
Closes PLAT-290

2026-05-29 17:12:31 +03:00

..

notify

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

doc.go

feat: automatically stop workspaces based on failure_ttl (#7989)

2023-06-22 00:33:22 -04:00

lifecycle_executor_internal_test.go

fix(coderd): use BuildReasonTaskAutoPause for task workspaces (#22126)

2026-02-17 15:11:04 +00:00

lifecycle_executor_test.go

fix(coderd/autobuild): handle concurrent build number race in lifecycle executor (#25824)

2026-05-29 17:12:31 +03:00

lifecycle_executor.go

fix(coderd/autobuild): handle concurrent build number race in lifecycle executor (#25824)

2026-05-29 17:12:31 +03:00