mirror of
https://github.com/coder/coder.git
synced 2026-06-03 13:08:25 +00:00
Zach
e0be9bf213
Adds `dynamicparameters.EvaluateSecretMismatch` as a shared helper on top of the existing renderer, then wires it into the resolve-autostart handler so the UI can surface unsatisfied `coder_secret` requirements in a template alongside parameter mismatch for autostart. The lifecycle executor changes will land in a follow-up that depend on this helper. The UI changes that consume the new `secret_mismatch` field is also a follow-up. Generated with assistance from Coder Agents.
113 lines
2.5 KiB
Go
113 lines
2.5 KiB
Go
package dynamicparameters
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/hashicorp/hcl/v2"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
previewtypes "github.com/coder/preview/types"
|
|
)
|
|
|
|
func TestSecretValidationBlockerCode(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cases := []struct {
|
|
name string
|
|
in hcl.Diagnostics
|
|
want string
|
|
}{
|
|
{
|
|
name: "Empty",
|
|
in: hcl.Diagnostics{},
|
|
want: "",
|
|
},
|
|
{
|
|
name: "MissingSecretIsNotBlocking",
|
|
in: hcl.Diagnostics{{
|
|
Severity: hcl.DiagError,
|
|
Summary: "Missing required secrets",
|
|
Extra: previewtypes.DiagnosticExtra{
|
|
Code: DiagCodeMissingSecret,
|
|
},
|
|
}},
|
|
want: "",
|
|
},
|
|
{
|
|
name: "Forbidden",
|
|
in: hcl.Diagnostics{{
|
|
Severity: hcl.DiagWarning,
|
|
Summary: "Cannot validate secret requirements",
|
|
Extra: previewtypes.DiagnosticExtra{
|
|
Code: DiagCodeSecretValidationForbidden,
|
|
},
|
|
}},
|
|
want: DiagCodeSecretValidationForbidden,
|
|
},
|
|
{
|
|
name: "FetchFailed",
|
|
in: hcl.Diagnostics{{
|
|
Severity: hcl.DiagError,
|
|
Summary: "Failed to fetch owner secrets",
|
|
Extra: previewtypes.DiagnosticExtra{
|
|
Code: DiagCodeOwnerSecretsFetchFailed,
|
|
},
|
|
}},
|
|
want: DiagCodeOwnerSecretsFetchFailed,
|
|
},
|
|
{
|
|
name: "DiagnosticWithNoExtraIsIgnored",
|
|
in: hcl.Diagnostics{{
|
|
Severity: hcl.DiagError,
|
|
Summary: "Some other error",
|
|
}},
|
|
want: "",
|
|
},
|
|
{
|
|
name: "MixedKeepsLookingUntilMatch",
|
|
in: hcl.Diagnostics{
|
|
{
|
|
Severity: hcl.DiagError,
|
|
Summary: "Missing required secrets",
|
|
Extra: previewtypes.DiagnosticExtra{
|
|
Code: DiagCodeMissingSecret,
|
|
},
|
|
},
|
|
{
|
|
Severity: hcl.DiagError,
|
|
Summary: "Failed to fetch owner secrets",
|
|
Extra: previewtypes.DiagnosticExtra{
|
|
Code: DiagCodeOwnerSecretsFetchFailed,
|
|
},
|
|
},
|
|
},
|
|
want: DiagCodeOwnerSecretsFetchFailed,
|
|
},
|
|
{
|
|
// SetDiagnosticExtra wraps any pre-existing extra into
|
|
// previewtypes.DiagnosticExtra.Wrapped. ExtractDiagnosticExtra
|
|
// walks that chain. A naive type assertion would miss it.
|
|
name: "WrappedExtraIsDetected",
|
|
in: func() hcl.Diagnostics {
|
|
d := &hcl.Diagnostic{
|
|
Severity: hcl.DiagWarning,
|
|
Summary: "Cannot validate secret requirements",
|
|
Extra: "some other extra",
|
|
}
|
|
previewtypes.SetDiagnosticExtra(d, previewtypes.DiagnosticExtra{
|
|
Code: DiagCodeSecretValidationForbidden,
|
|
})
|
|
return hcl.Diagnostics{d}
|
|
}(),
|
|
want: DiagCodeSecretValidationForbidden,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
require.Equal(t, tc.want, secretValidationBlockerCode(tc.in))
|
|
})
|
|
}
|
|
}
|