coder

mirror of https://github.com/coder/coder.git synced 2026-06-05 14:08:20 +00:00

Files

T

Danny Kopping 24b20df7d5 fix: use os.Pipe implementation for Windows CLI tests to reduce flakiness (#21874 )

On Windows, `pty.New()` was creating a `ConPTY` (`PseudoConsole`) even
when no process would be attached. `ConPTY` requires a real process to
function correctly - without one, the pipe handles become invalid
intermittently, causing flaky test failures like `read |0: The handle is
invalid.`
This affected tests using the `ptytest.New()` + `Attach()` pattern for
in-process CLI testing.
The fix splits Windows PTY creation into two paths:
- `newPty()` now returns a simple pipe-based PTY for the `Attach()` use
case
- `newConPty()` creates a real `ConPTY`, called by `Start()` when a
process will be attached
AFAICT this will result in no change in behaviour outside of tests.

Fixes coder/internal#1277   

_Disclaimer: investigated and implemented by Claude Opus 4.5, reviewed
by me._

---------

Signed-off-by: Danny Kopping <danny@coder.com>

2026-02-03 11:50:28 +02:00

ptytest

fix: use os.Pipe implementation for Windows CLI tests to reduce flakiness (#21874 )

2026-02-03 11:50:28 +02:00

pty_linux.go

chore: update golang to 1.24.1 (#17035 )

2025-03-26 01:56:39 -05:00

pty_other.go

feat(agent/agentssh): handle session signals (#10842 )

2023-11-23 19:55:36 +02:00

pty_windows.go

fix: use os.Pipe implementation for Windows CLI tests to reduce flakiness (#21874 )