mirror of
https://github.com/coder/coder.git
synced 2026-06-05 05:58:20 +00:00
Susana Ferreira
f044cc3550
# Description This PR adds the `worker_name` field to the provisioner jobs endpoint. To achieve this, the following SQL query was updated: - `GetProvisionerJobsByOrganizationAndStatusWithQueuePositionAndProvisioner` As a result, the `codersdk.ProvisionerJob` type, which represents the provisioner job API response, was modified to include the new field. **Notes:** * As mentioned in [comment](https://github.com/coder/coder/pull/17877#discussion_r2093218206), the `GetProvisionerJobsByIDsWithQueuePosition` query was not changed due to load concerns. This means that for template and template version endpoints, `worker_id` will still be returned, but `worker_name` will not. * Similar to `worker_id`, the `worker_name` is only present once a job is assigned to a provisioner daemon. For jobs in a pending state (not yet assigned), neither `worker_id` nor `worker_name` will be returned. --- # Affected Endpoints - `/organizations/{organization}/provisionerjobs` - `/organizations/{organization}/provisionerjobs/{job}` --- # Testing - Added new tests verifying that both `worker_id` and `worker_name` are returned once a provisioner job reaches the **succeeded** state. - Existing tests covering state transitions and other logic remain unchanged, as they test different scenarios. --- # Front-end Changes Admin provisioner jobs dashboard: <img width="1088" alt="Screenshot 2025-05-16 at 11 51 33" src="https://github.com/user-attachments/assets/0e20e360-c615-4497-84b7-693777c5443e" /> Fixes: https://github.com/coder/coder/issues/16982
31 lines
780 B
Plaintext
31 lines
780 B
Plaintext
[
|
|
{
|
|
"id": "====[workspace build worker ID]=====",
|
|
"organization_id": "===========[first org ID]===========",
|
|
"key_id": "00000000-0000-0000-0000-000000000001",
|
|
"created_at": "====[timestamp]=====",
|
|
"last_seen_at": "====[timestamp]=====",
|
|
"name": "test-daemon",
|
|
"version": "v0.0.0-devel",
|
|
"api_version": "1.6",
|
|
"provisioners": [
|
|
"echo"
|
|
],
|
|
"tags": {
|
|
"owner": "",
|
|
"scope": "organization"
|
|
},
|
|
"key_name": "built-in",
|
|
"status": "idle",
|
|
"current_job": null,
|
|
"previous_job": {
|
|
"id": "======[workspace build job ID]======",
|
|
"status": "succeeded",
|
|
"template_name": "test-template",
|
|
"template_icon": "",
|
|
"template_display_name": ""
|
|
},
|
|
"organization_name": "Coder"
|
|
}
|
|
]
|