Spike Curtis 4fc0093388 fix: fix TestCloserStack_Timeout to wait for all asyncClosers (#19837) ...

fixes https://github.com/coder/internal/issues/966


TestCloserStack_Timeout creates `asyncCloser`s which allow control over the exact timing and order of their close method returning. They also, as a final backstop will throw an error if the test context ends before they are unblocked.

TestCloserStack_Timeout unblocks all `asyncCloser`s in a defer and then ends the test. This defer _unblocks_ the running close goroutines, but does not wait for them to finish. Since the test context is canceled as soon as the test completes, this creates a race condition where the close goroutines can trigger the context cancelled  arm of the `select` statement.

The fix is to both unblock and wait for all close goroutines to complete before ending the test and cancelling the context.

2025-09-16 21:53:50 +04:00

..

clilog

test: fix use of t.Logf where t.Log would suffice (#16328)

2025-01-29 14:35:04 +00:00

clitest

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

cliui

fix: return empty array if no option multi-selected (#19224)

2025-08-07 11:37:58 +00:00

cliutil

feat(cli): include license status in support bundle (#18472)

2025-06-24 11:16:31 +02:00

config

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

exptest

test(cli/exptest): fix context in TestScaleTestWorkspaceTraffic_UseHostLogin (#16171)

2025-01-17 14:51:24 +02:00

gitauth

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

telemetry

refactor(coderd/telemetry): move CLI telemetry to cli/telemetry (#9517)

2023-09-04 21:42:45 +03:00

testdata

chore: add aibridge configs & experiment (#19793)

2025-09-16 11:45:23 +02:00

agent_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

agent_test.go

chore: refactor CLI agent auth tests as unit tests (#19609)

2025-09-03 10:49:19 +04:00

agent.go

chore: refactor CLI agent auth tests as unit tests (#19609)

2025-09-03 10:49:19 +04:00

autoupdate_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

autoupdate.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

completion.go

chore: skip completion install prompts in non-interactive shells (#14391)

2024-08-22 15:40:53 +10:00

configssh_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

configssh_other.go

fix: handle paths with spaces in Match exec clause of SSH config (#18266)

2025-06-06 16:44:25 +04:00

configssh_test.go

chore: update gofumpt from v0.4.0 to v0.8.0 (#18652)

2025-07-03 11:28:00 -06:00

configssh_windows.go

fix: handle paths with spaces in Match exec clause of SSH config (#18266)

2025-06-06 16:44:25 +04:00

configssh.go

chore: update gofumpt from v0.4.0 to v0.8.0 (#18652)

2025-07-03 11:28:00 -06:00

connect_test.go

feat: add coder connect exists hidden subcommand (#17418)

2025-04-17 11:23:24 +04:00

connect.go

feat: add coder connect exists hidden subcommand (#17418)

2025-04-17 11:23:24 +04:00

create_test.go

feat(cli): support description in create and presets list CLI commands (#19079)

2025-07-29 16:59:26 +01:00

create.go

feat(cli): add enterprise external-workspaces CLI command (#19287)

2025-08-19 10:52:31 +02:00

delete_test.go

chore: wire up usage tracking for managed agents (#19096)

2025-08-20 23:38:09 +10:00

delete.go

fix: unify coder create and coder delete help message (#15752)

2024-12-05 12:32:52 +11:00

dotfiles_other.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

dotfiles_test.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

dotfiles_windows.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

dotfiles.go

feat: check for .ps1 dotfiles scripts on windows (#16785)

2025-03-04 15:37:29 -07:00

exp_errors_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

exp_errors.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

exp_mcp_test.go

fix: improve reliability of app statuses (#18622)

2025-06-30 12:12:20 -08:00

exp_mcp.go

chore: refactor CLI agent auth tests as unit tests (#19609)

2025-09-03 10:49:19 +04:00

exp_prompts.go

feat: implement rich multi-selector (#19201)

2025-08-06 23:03:51 +02:00

exp_rpty_test.go

feat(agent/agentcontainers): auto detect dev containers (#18950)

2025-07-22 19:02:43 +01:00

exp_rpty.go

feat(cli): add enterprise external-workspaces CLI command (#19287)

2025-08-19 10:52:31 +02:00

exp_scaletest_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

exp_scaletest_test.go

chore(cli): skip scaletest tests when race detector enabled (#16033)

2025-01-03 23:08:51 +02:00

exp_scaletest.go

chore: add --disable-direct to coder exp scaletest workspace-traffic --ssh (#19632)

2025-08-29 17:02:13 +10:00

exp_task_create_test.go

feat(cli): add quiet flag to task create (#19701)

2025-09-04 10:03:22 +01:00

exp_task_create.go

feat(cli): add quiet flag to task create (#19701)

2025-09-04 10:03:22 +01:00

exp_task_delete_test.go

feat(cli): add coder exp task delete (#19644)

2025-09-01 11:14:13 +03:00

exp_task_delete.go

feat(cli): add coder exp task delete (#19644)

2025-09-01 11:14:13 +03:00

exp_task_list_test.go

chore(cli): reduce clutter from exp tasks list command (#19727)

2025-09-08 13:23:18 +01:00

exp_task_list.go

chore(cli): reduce clutter from exp tasks list command (#19727)

2025-09-08 13:23:18 +01:00

exp_task_status_test.go

chore: refactor codersdk to use SessionTokenProvider (#19565)

2025-08-29 10:41:32 +02:00

exp_task_status.go

feat(cli): implement exp task status command (#19533)

2025-08-26 16:01:35 +01:00

exp_task.go

feat(cli): add coder exp task delete (#19644)

2025-09-01 11:14:13 +03:00

exp.go

feat(cli): add coder exp tasks list (#19496)

2025-08-25 13:03:32 +00:00

externalauth_test.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

externalauth.go

chore: refactor CLI agent auth tests as unit tests (#19609)

2025-09-03 10:49:19 +04:00

favorite_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

favorite.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

gitaskpass_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

gitaskpass.go

chore: refactor CLI agent auth tests as unit tests (#19609)

2025-09-03 10:49:19 +04:00

gitssh_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

gitssh.go

chore: refactor CLI agent auth tests as unit tests (#19609)

2025-09-03 10:49:19 +04:00

help.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

help.tpl

feat(cli): colorize help page (#9589)

2023-09-08 18:21:33 +00:00

list_test.go

fix: display the correct response for coder list (#16547)

2025-02-13 10:13:20 -05:00

list.go

feat(cli): add enterprise external-workspaces CLI command (#19287)

2025-08-19 10:52:31 +02:00

login_test.go

feat: expose premium trial form via CLI (#15054)

2024-10-29 13:02:20 +00:00

login.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

logout_test.go

fix: enrich the notLoggedInMessage error message with the full path to the coder (#17715)

2025-05-12 11:45:24 -07:00

logout.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

netcheck_test.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

netcheck.go

feat!: add interface report to coder netcheck (#13562)

2024-06-13 10:19:36 +04:00

notifications_test.go

feat: support custom notifications (#19751)

2025-09-11 15:08:57 +02:00

notifications.go

feat: support custom notifications (#19751)

2025-09-11 15:08:57 +02:00

open_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

open_test.go

feat(agent/agentcontainers): auto detect dev containers (#18950)

2025-07-22 19:02:43 +01:00

open.go

feat(cli): add enterprise external-workspaces CLI command (#19287)

2025-08-19 10:52:31 +02:00

organization_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organization.go

chore: add cli command to fetch group sync settings as json (#14694)

2024-09-17 14:08:33 -05:00

organizationmanage.go

chore: remove the double confirmation when creating an organization via the CLI (#16972)

2025-03-17 17:14:59 -04:00

organizationmembers_test.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationmembers.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

organizationroles_test.go

chore: include custom roles in list org roles (#13336)

2024-05-23 07:54:59 -10:00

organizationroles.go

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

organizationsettings.go

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

parameter_internal_test.go

feat(cli): provide parameter values via command line (#8898)

2023-08-09 13:00:25 +02:00

parameter.go

feat(cli): add CLI support for creating a workspace with preset (#18912)

2025-07-28 14:46:04 +01:00

parameterresolver.go

feat(cli): add CLI support for creating a workspace with preset (#18912)

2025-07-28 14:46:04 +01:00

ping_internal_test.go

fix(cli): calculate coder ping max correctly (#18734)

2025-07-03 13:22:54 +10:00

ping_test.go

feat(cli): add local and UTC time options to ping cmd (#16648)

2025-02-24 05:38:17 +00:00

ping.go

refactor: convert workspacesdk.AgentConn to an interface (#19392)

2025-08-20 10:00:44 +01:00

portforward_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

portforward_test.go

chore: move InProcNet to testutil (#18563)

2025-06-27 14:42:22 +04:00

portforward.go

refactor: convert workspacesdk.AgentConn to an interface (#19392)

2025-08-20 10:00:44 +01:00

provisionerjobs_test.go

chore: reduce execution time of TestProvisionerJobs (#19475)

2025-08-22 13:40:06 +01:00

provisionerjobs.go

feat!: add ability to cancel pending workspace build (#18713)

2025-07-08 11:02:58 +02:00

provisioners_test.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisioners.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

publickey_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

publickey.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

remoteforward.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

rename_test.go

chore(coderd): allow creating workspaces without specifying an organization (#14048)

2024-07-30 10:44:02 -06:00

rename.go

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

resetpassword_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

resetpassword_test.go

chore: add postgres template caching for tests (#15336)

2024-11-04 17:23:31 +01:00

resetpassword.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

restart_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

restart.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

root_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

root_test.go

chore: refactor CLI agent auth tests as unit tests (#19609)

2025-09-03 10:49:19 +04:00

root.go

feat: add sharing add command to the CLI (#19576)

2025-09-04 17:37:16 -04:00

schedule_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

schedule_test.go

fix: fix flake due to two time.Now() calls (#19450)

2025-08-20 12:12:02 -05:00

schedule.go

feat(cli): add enterprise external-workspaces CLI command (#19287)

2025-08-19 10:52:31 +02:00

server_createadminuser_test.go

chore: add postgres template caching for tests (#15336)

2024-11-04 17:23:31 +01:00

server_createadminuser.go

chore: add the --ephemeral server flag (#16126)

2025-01-20 14:31:16 +01:00

server_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

server_regenerate_vapid_keypair_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

server_regenerate_vapid_keypair.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

server_slim.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

server_test.go

chore: remove dbmem (#18803)

2025-07-09 09:46:31 +02:00

server.go

feat: ensure OAuth2 refresh tokens outlive access tokens (#19769)

2025-09-13 08:57:26 +02:00

sharing_test.go

test: avoid sharing deployment values between subtests (#19833)

2025-09-16 13:51:26 +10:00

sharing.go

feat: add sharing remove command to the CLI (#19767)

2025-09-11 16:22:25 -04:00

show_test.go

feat(cli): improve devcontainer support for coder show (#18793)

2025-07-08 16:16:00 +00:00

show.go

feat(cli): improve devcontainer support for coder show (#18793)

2025-07-08 16:16:00 +00:00

signal_unix.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

signal_windows.go

fix: separate signals for passive, active, and forced shutdown (#12358)

2024-03-15 13:16:36 +00:00

speedtest_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

speedtest.go

refactor: convert workspacesdk.AgentConn to an interface (#19392)

2025-08-20 10:00:44 +01:00

ssh_internal_test.go

fix: fix TestCloserStack_Timeout to wait for all asyncClosers (#19837)

2025-09-16 21:53:50 +04:00

ssh_other.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh_test.go

test: dial socket when testing coder ssh unix socket forwarding (#19563)

2025-08-27 21:30:54 +10:00

ssh_windows.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh.go

refactor: convert workspacesdk.AgentConn to an interface (#19392)

2025-08-20 10:00:44 +01:00

start_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

start.go

feat: extend workspace build reasons to track connection types (#18827)

2025-07-22 13:11:27 +02:00

stat_test.go

chore: migrate to github.com/coder/clistat (#17107)

2025-03-26 10:36:53 +00:00

stat.go

chore: migrate to github.com/coder/clistat (#17107)

2025-03-26 10:36:53 +00:00

state_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

state.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

stop.go

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

support_test.go

feat(cli): include license status in support bundle (#18472)

2025-06-24 11:16:31 +02:00

support.go

chore: fix typo in clientNetcheckSummary for support bundle command (#19441)

2025-08-21 10:08:51 +10:00

templatecreate_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatecreate.go

chore: fix docs/admin links and upgrade notice (#15043)

2024-11-01 19:43:51 +00:00

templatedelete_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templatedelete.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templateedit_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

templateedit.go

fix!: support empty or default fields when updating templates (#19256)

2025-08-12 11:37:44 -05:00

templateinit_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

templateinit.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

templatelist_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

templatelist.go

chore: include all templates in cli template list (#13841)

2024-07-09 11:04:16 -05:00

templatepresets_test.go

feat(cli): support description in create and presets list CLI commands (#19079)

2025-07-29 16:59:26 +01:00

templatepresets.go

feat(cli): support description in create and presets list CLI commands (#19079)

2025-07-29 16:59:26 +01:00

templatepull_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

templatepull.go

chore: remove org context switcher in the cli (#13674)

2024-07-01 16:04:45 -05:00

templatepush_test.go

fix(cli/templatepush): only implicitly read from stdin if the directory flag is unset (#19681)

2025-09-04 14:31:56 +10:00

templatepush.go

fix(cli/templatepush): only implicitly read from stdin if the directory flag is unset (#19681)

2025-09-04 14:31:56 +10:00

templates.go

feat(cli): add CLI support for listing presets (#18910)

2025-07-24 16:44:36 +01:00

templateversionarchive_test.go

feat: archive template versions to hide them from the ui (#10179)

2023-10-11 09:26:22 -05:00

templateversionarchive.go

fix: conform to stricter printf usage in Go 1.24 (#16330)

2025-01-29 18:06:22 +02:00

templateversions_test.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

templateversions.go

feat: allow promoting an existing template version to active from CLI (#15051)

2024-10-17 14:15:14 +05:00

tokens_test.go

feat(cli): support deleting tokens by id (#16341)

2025-02-12 18:18:17 +11:00

tokens.go

refactor: replace golang.org/x/exp/slices with slices (#16772)

2025-03-04 00:46:49 +11:00

update_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

update.go

fix!: stop workspace before update (#18425)

2025-06-23 09:12:37 +01:00

user_delete_test.go

chore!: allow CreateUser to accept multiple organizations (#14383)

2024-08-23 21:23:51 +00:00

usercreate_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

usercreate.go

docs: add section on how to retrieve user list (#17798)

2025-05-13 20:48:16 +00:00

userdelete.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

usereditroles_test.go

feat: add edit-role within user command (#17341)

2025-04-15 18:30:20 -04:00

usereditroles.go

chore: avoid depending on rbac in slim builds (#17959)

2025-05-22 19:48:23 +10:00

userlist_test.go

fix: enrich the notLoggedInMessage error message with the full path to the coder (#17715)

2025-05-12 11:45:24 -07:00

userlist.go

docs: add section on how to retrieve user list (#17798)

2025-05-13 20:48:16 +00:00

users.go

feat: add edit-role within user command (#17341)

2025-04-15 18:30:20 -04:00

userstatus_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

userstatus.go

feat(cli): add shell completions (#14341)

2024-08-20 14:47:46 +10:00

util_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

version_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

version.go

chore(cli): rename Cmd to Command (#12616)

2024-03-17 09:45:26 -05:00

vpndaemon_darwin.go

feat: ensure OAuth2 refresh tokens outlive access tokens (#19769)

2025-09-13 08:57:26 +02:00

vpndaemon_other.go

chore: add vpn-daemon run command for macos (#19080)

2025-07-30 02:03:20 +10:00

vpndaemon_windows_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

vpndaemon_windows.go

fix: avoid duplicating logs on Coder Connect Windows (#19052)

2025-07-28 14:02:00 +10:00

vpndaemon.go

chore: add vpn-daemon run subcommand for windows (#15526)

2024-11-18 21:10:01 +10:00

vscodessh_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

vscodessh.go

feat(cli): add enterprise external-workspaces CLI command (#19287)

2025-08-19 10:52:31 +02:00

whoami_test.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00

whoami.go

feat: added whomai cmd to coder cli (#13814)

2024-07-09 13:23:11 -05:00