Spike Curtis 71f87d054f fix: accept legacy redirect HTTP environment variables (#10748) ...

> Can someone help me understand the differences between these env variables:
>
>    CODER_REDIRECT_TO_ACCESS_URL
>    CODER_TLS_REDIRECT_HTTP_TO_HTTPS
>    CODER_TLS_REDIRECT_HTTP

Oh man, what a mess. It looks like `CODER_TLS_REDIRECT_HTTP ` appears in our config docs. Maybe that was the initial name for the environment variable?

At some point, both the flag and the environment variable were `--tls-redirect-http-to-https` and `CODER_TLS_REDIRECT_HTTP_TO_HTTPS`.  `CODER_TLS_REDIRECT_HTTP` did nothing.

However, then we introduced `CODER_REDIRECT_TO_ACCESS_URL`, we put in some deprecation code that was maybe fat-fingered such that we accept the environment variable `CODER_TLS_REDIRECT_HTTP` but the flag `--tls-redirect-http-to-https`.  Our docs still refer to `CODER_TLS_REDIRECT_HTTP` at https://coder.com/docs/v2/latest/admin/configure#address

So, I think what we gotta do is still accept `CODER_TLS_REDIRECT_HTTP` since it was working and in an example doc, but also fix the deprecation code to accept `CODER_TLS_REDIRECT_HTTP_TO_HTTPS` environment variable.

2023-11-17 15:09:29 +04:00

..

clibase

fix: accept legacy redirect HTTP environment variables (#10748)

2023-11-17 15:09:29 +04:00

clistat

fix: fix coder stat mem (#8762)

2023-07-27 09:33:43 +01:00

clitest

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

cliui

refactor(cli): extract workspace list parameters (#10605)

2023-11-09 12:16:43 +00:00

cliutil

fix: lock log sink against concurrent write and close (#10668)

2023-11-14 16:38:34 +04:00

config

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

gitauth

refactor: split coderd/gitauth into two, add cli/gitauth (#9479)

2023-09-01 15:41:22 +00:00

telemetry

refactor(coderd/telemetry): move CLI telemetry to cli/telemetry (#9517)

2023-09-04 21:42:45 +03:00

testdata

feat(coderd/healthcheck): allow configuring database hc threshold (#10623)

2023-11-13 14:14:43 +00:00

agent_internal_test.go

fix: Port forward should ignore coder ports (#7645)

2023-05-23 17:14:05 +02:00

agent_test.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

agent.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

autoupdate_test.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

autoupdate.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

configssh_internal_test.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh_other.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh_test.go

chore: migrate CLI tests to use dbfake (#10500)

2023-11-03 12:22:32 -05:00

configssh_windows.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh.go

ci: enable gocognit (#9359)

2023-08-27 14:46:44 -05:00

create_test.go

feat(cli): create workspace using parameters from existing workspace (#10604)

2023-11-09 19:22:47 +01:00

create.go

feat(cli): create workspace using parameters from existing workspace (#10604)

2023-11-09 19:22:47 +01:00

delete_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

delete.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

dotfiles_test.go

feat(cli): make the dotfiles repository directory configurable (#10377)

2023-10-24 12:00:04 +03:00

dotfiles.go

feat(cli): make the dotfiles repository directory configurable (#10377)

2023-10-24 12:00:04 +03:00

errors.go

chore: replace <ChooseOne> with alternatives when appropriate (#9907)

2023-10-02 10:51:35 -06:00

exp_scaletest_slim.go

fix(cli): remove exp scaletest from slim binary (#9934)

2023-10-03 15:13:04 +01:00

exp_scaletest_test.go

feat(cli): add template filter support to exp scaletest cleanup and traffic (#10558)

2023-11-07 16:41:55 +00:00

exp_scaletest.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

exp.go

chore: change cli error message handling (#9952)

2023-09-29 16:50:23 -05:00

externalauth_test.go

feat: allow external auth providers to expose extra metadata (#10157)

2023-10-09 23:02:16 -05:00

externalauth.go

fix: handle SIGHUP from OpenSSH (#10638)

2023-11-13 15:14:42 +04:00

gitaskpass_test.go

feat: add external-auth cli (#10052)

2023-10-09 23:04:35 +00:00

gitaskpass.go

fix: handle SIGHUP from OpenSSH (#10638)

2023-11-13 15:14:42 +04:00

gitssh_test.go

chore: migrate CLI tests to use dbfake (#10500)

2023-11-03 12:22:32 -05:00

gitssh.go

fix: handle SIGHUP from OpenSSH (#10638)

2023-11-13 15:14:42 +04:00

help.go

perf(cli): optimize CPU consumption of help pages (#9607)

2023-09-14 19:48:29 -05:00

help.tpl

feat(cli): colorize help page (#9589)

2023-09-08 18:21:33 +00:00

list_test.go

chore: migrate CLI tests to use dbfake (#10500)

2023-11-03 12:22:32 -05:00

list.go

feat(cli): allow showing schedules for multiple workspaces (#10596)

2023-11-10 13:51:49 +00:00

login_test.go

fix(cli): display pasted session token (#9710)

2023-09-20 12:41:59 -04:00

login.go

fix(cli): display pasted session token (#9710)

2023-09-20 12:41:59 -04:00

logout_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

logout.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

netcheck_test.go

refactor(coderd/healthcheck): move derp report to derphealth package (#9506)

2023-09-04 21:41:50 +03:00

netcheck.go

refactor(coderd/healthcheck): move derp report to derphealth package (#9506)

2023-09-04 21:41:50 +03:00

parameter_internal_test.go

feat(cli): provide parameter values via command line (#8898)

2023-08-09 13:00:25 +02:00

parameter.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

parameterresolver.go

feat(cli): create workspace using parameters from existing workspace (#10604)

2023-11-09 19:22:47 +01:00

ping_test.go

refactor(agent): add agenttest.New helper function (#9812)

2023-09-26 12:05:19 +01:00

ping.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

portforward_internal_test.go

feat: Support for comma-separation and ranges in port-forward (#4166)

2022-10-03 11:58:43 +03:00

portforward_test.go

chore: migrate CLI tests to use dbfake (#10500)

2023-11-03 12:22:32 -05:00

portforward.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

publickey_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

publickey.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

remoteforward.go

feat(cli): add reverse tunnelling SSH support for unix sockets (#9976)

2023-10-03 16:39:39 +10:00

rename_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

rename.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

resetpassword_slim.go

refactor(cli)!: remove reset-password from slim binary (#9520)

2023-09-04 19:38:53 +03:00

resetpassword_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

resetpassword.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

restart_test.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

restart.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

root_internal_test.go

chore: disable goleak in windows cli tests (#8955)

2023-08-07 22:23:00 -05:00

root_test.go

chore: migrate CLI tests to use dbfake (#10500)

2023-11-03 12:22:32 -05:00

root.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

schedule_internal_test.go

feat: cli: consolidate schedule-related commands (#2402)

2022-06-16 18:24:10 +01:00

schedule_test.go

feat(cli): allow showing schedules for multiple workspaces (#10596)

2023-11-10 13:51:49 +00:00

schedule.go

feat(cli): allow showing schedules for multiple workspaces (#10596)

2023-11-10 13:51:49 +00:00

server_createadminuser_test.go

refactor(coderd/database): split Time and Now into dbtime package (#9482)

2023-09-01 16:50:12 +00:00

server_createadminuser.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

server_internal_test.go

fix: accept legacy redirect HTTP environment variables (#10748)

2023-11-17 15:09:29 +04:00

server_slim.go

refactor(cli)!: remove reset-password from slim binary (#9520)

2023-09-04 19:38:53 +03:00

server_test.go

chore: fail server startup on invalid DERP map (#10536)

2023-11-06 23:04:07 +10:00

server.go

fix: accept legacy redirect HTTP environment variables (#10748)

2023-11-17 15:09:29 +04:00

show_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

show.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

signal_unix.go

feat: Add external provisioner daemons (#4935)

2022-11-16 16:34:06 -06:00

signal_windows.go

feat: Add external provisioner daemons (#4935)

2022-11-16 16:34:06 -06:00

speedtest_test.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

speedtest.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

ssh_internal_test.go

fix: accept legacy redirect HTTP environment variables (#10748)

2023-11-17 15:09:29 +04:00

ssh_other.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh_test.go

fix: close ssh sessions gracefully (#10732)

2023-11-17 12:43:20 +04:00

ssh_windows.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh.go

fix: close ssh sessions gracefully (#10732)

2023-11-17 12:43:20 +04:00

start_test.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

start.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

stat_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

stat.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

state_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

state.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

stop.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

templatecreate_test.go

feat: add cli support for --require-active-version (#10337)

2023-10-19 17:16:15 -05:00

templatecreate.go

chore: revert "chore: remove workspace_actions experiment (#10030)" (#10363)

2023-10-20 13:21:53 -05:00

templatedelete_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templatedelete.go

feat: archive template versions to hide them from the ui (#10179)

2023-10-11 09:26:22 -05:00

templateedit_test.go

feat: add cli support for --require-active-version (#10337)

2023-10-19 17:16:15 -05:00

templateedit.go

chore: revert "chore: remove workspace_actions experiment (#10030)" (#10363)

2023-10-20 13:21:53 -05:00

templateinit_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

templateinit.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

templatelist_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templatelist.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

templatepull_test.go

chore: fix lint failures

2023-10-10 11:26:53 -05:00

templatepull.go

feat: add --version flag to coder templates pull, default to active version (#10153)

2023-10-10 10:20:31 -05:00

templatepush_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templatepush.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

templates.go

feat: add template setting to require active template version (#10277)

2023-10-18 17:07:21 -05:00

templatevariables.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

templateversionarchive_test.go

feat: archive template versions to hide them from the ui (#10179)

2023-10-11 09:26:22 -05:00

templateversionarchive.go

feat: add template setting to require active template version (#10277)

2023-10-18 17:07:21 -05:00

templateversions_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templateversions.go

feat: add template setting to require active template version (#10277)

2023-10-18 17:07:21 -05:00

tokens_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

tokens.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

update_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

update.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

user_delete_test.go

fix: add requester IP to workspace build audit logs (#10242)

2023-10-18 15:08:02 -05:00

usercreate_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

usercreate.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

userdelete.go

feat(cli): add coder users delete command (#10115)

2023-10-09 11:47:57 -05:00

userlist_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

userlist.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

users.go

feat(cli): add coder users delete command (#10115)

2023-10-09 11:47:57 -05:00

userstatus_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

userstatus.go

feat(cli): add coder users delete command (#10115)

2023-10-09 11:47:57 -05:00

util_internal_test.go

feat: cli: consolidate schedule-related commands (#2402)

2022-06-16 18:24:10 +01:00

util.go

feat(cli): allow showing schedules for multiple workspaces (#10596)

2023-11-10 13:51:49 +00:00

version_test.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

version.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

vscodessh_test.go

feat: add log-dir flag to vscodessh for debuggability (#10514)

2023-11-03 16:21:31 +00:00

vscodessh.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00