Susana Ferreira 734299de71 fix: disallow lifecycle endpoints for prebuilt workspaces (#19264) ...

## Description

This PR updates the API to prevent lifecycle configuration endpoints
from being used on prebuilt workspaces. Since prebuilds are managed by
the reconciliation loop and do not participate in the regular workspace
lifecycle, they must not support per-workspace overrides for fields like
deadline, TTL, autostart, or dormancy.

Attempting to use these endpoints on a prebuilt workspace will now
return a clear validation error (`409 Conflict`) with an appropriate
explanation. This prevents accidental misconfiguration and preserves the
lifecycle separation between prebuilds and regular workspaces.

## Changes

The following endpoints now return an error if the target workspace is a
prebuild:

* `PUT /workspaces/{workspace}/extend`
* `PUT /workspaces/{workspace}/ttl`
* `PUT /workspaces/{workspace}/autostart`
* `PUT /workspaces/{workspace}/dormant`

Update endpoints logic to use the API clock in order to allow time
mocking in tests.

Related with: 
* Issue: https://github.com/coder/coder/issues/18898
* PR: https://github.com/coder/coder/pull/19252

2025-08-14 11:30:19 +01:00

..

agentapi

chore!: route connection logs to new table (#18340)

2025-07-15 14:36:06 +10:00

agentmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

apidoc

feat: add user_secrets table (#19162)

2025-08-07 15:58:59 -04:00

apikey

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

appearance

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

audit

chore: mark workspace apps and workspace agents as unaudited (#18761)

2025-07-15 16:08:42 +10:00

autobuild

fix: set prebuilds lifecycle parameters on creation and claim (#19252)

2025-08-13 12:45:46 +01:00

awsidentity

fix: add new aws regions to instance identity (#10434)

2023-10-30 19:44:29 +00:00

azureidentity

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderdtest

feat: add workspace sharing page (#19107)

2025-07-31 15:05:09 +00:00

connectionlog

chore!: route connection logs to new table (#18340)

2025-07-15 14:36:06 +10:00

cryptokeys

chore: update to coder/quartz v0.2.0 (#18007)

2025-05-27 16:05:03 +04:00

database

chore(coderd/database/dbauthz): migrate TestTemplate to use mocked DB (#19304)

2025-08-14 11:32:53 +02:00

devtunnel

chore: disable devtunnel tests on windows (#18521)

2025-06-24 19:01:29 +10:00

dynamicparameters

feat: validate presets on template import (#18844)

2025-07-30 15:28:56 +02:00

entitlements

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

externalauth

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

files

chore: support zip filetypes in the file cache (#18750)

2025-07-08 15:46:39 -06:00

gitsshkey

…

healthcheck

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

httpapi

chore: create interface for pkgs to return codersdk errors (#18719)

2025-07-03 08:33:45 -05:00

httpmw

chore: rename service -> coder_service, remove agent_id label (#19241)

2025-08-07 13:58:39 -05:00

idpsync

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

jobreaper

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

jwtutils

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

mcp

feat: add MCP tools for ChatGPT (#19102)

2025-08-04 14:11:22 +02:00

metricscache

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

notifications

chore: add more pprof labels for various go routines (#19243)

2025-08-07 20:05:32 +00:00

oauth2provider

refactor: simplify OAuth2 authorization flow and use 302 redirects (#18923)

2025-07-20 16:22:52 +02:00

oauthpki

fix: stop extending API key access if OIDC refresh is available (#17878)

2025-05-19 12:05:35 +04:00

portsharing

fix: properly convert max port share level for oss (#13261)

2024-05-13 14:37:51 -04:00

pproflabel

chore: add more pprof labels for various go routines (#19243)

2025-08-07 20:05:32 +00:00

prebuilds

fix: set prebuilds lifecycle parameters on creation and claim (#19252)

2025-08-13 12:45:46 +01:00

prometheusmetrics

fix(coderd/prometheusmetrics)!: filter deleted wsbuilds to reduce db load (#19197)

2025-08-11 14:48:31 +03:00

promoauth

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerdserver

fix: set prebuilds lifecycle parameters on creation and claim (#19252)

2025-08-13 12:45:46 +01:00

provisionerkey

chore: shorten provisioner key (#14017)

2024-07-25 16:08:12 -05:00

proxyhealth

feat: add csp headers for embedded apps (#18374)

2025-06-17 09:00:32 -08:00

pubsub

feat(coderd): add inbox notifications endpoints (#16889)

2025-03-18 00:02:47 +01:00

rbac

feat: add user_secrets table (#19162)

2025-08-07 15:58:59 -04:00

render

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

runtimeconfig

chore(coderd/runtimeconfig): remove dbmem from tests (#18790)

2025-07-08 14:31:05 +00:00

schedule

chore: improve build deadline code (#19203)

2025-08-07 11:00:31 +10:00

searchquery

chore: support 'me' as the username for template author (#19204)

2025-08-06 11:45:07 -05:00

telemetry

feat: graduate prebuilds to general availability (#18607)

2025-06-26 15:54:52 +02:00

testdata

feat: include template variables in dynamic parameter rendering (#18819)

2025-07-21 13:02:31 -05:00

tracing

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck

chore(coderd/updatecheck): remove dbmem from tests (#18792)

2025-07-08 14:32:46 +00:00

userpassword

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util

fix: sanitize app status summary (#19075)

2025-07-29 15:24:11 +01:00

webpush

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

workspaceapps

feat: allow bypassing current CORS magic based on template config (#18706)

2025-07-30 13:42:39 -07:00

workspacestats

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

wsbuilder

fix: add constraint and runtime check for provisioner logs size limit (#18893)

2025-07-30 19:09:53 -05:00

wspubsub

feat: add app status tracking to the backend (#17163)

2025-03-31 10:55:44 -04:00

activitybump_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

aitasks_test.go

refactor: create tasks in coderd instead of frontend (#19280)

2025-08-12 11:23:55 +01:00

aitasks.go

refactor: create tasks in coderd instead of frontend (#19280)

2025-08-12 11:23:55 +01:00

apikey_test.go

feat: add separate max token lifetime for administrators (#18267)

2025-06-06 17:36:30 +02:00

apikey.go

feat: add separate max token lifetime for administrators (#18267)

2025-06-06 17:36:30 +02:00

apiroot.go

…

audit_internal_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit_test.go

chore: mark workspace apps and workspace agents as unaudited (#18761)

2025-07-15 16:08:42 +10:00

audit.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

authorize_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

authorize.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

client_test.go

…

coderd_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderd_test.go

chore(testutil): add testutil.GoleakOptions (#16070)

2025-01-08 15:38:37 +00:00

coderd.go

refactor: create tasks in coderd instead of frontend (#19280)

2025-08-12 11:23:55 +01:00

csp.go

…

debug_test.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

debug.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

deployment_test.go

fix(coderd): mark provisioner daemon psk as secret (#12322)

2024-02-27 16:33:32 +00:00

deployment.go

chore: remove chats experiment (#18535)

2025-06-25 13:03:32 +00:00

deprecated.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

experiments_test.go

chore: revert dynamic params as a safe experiment (#17510)

2025-04-22 16:21:15 +00:00

experiments.go

fix: do not warn on valid known experiments (#18514)

2025-06-24 09:14:41 +01:00

externalauth_test.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

externalauth.go

fix: limit OAuth redirects to local paths (#14585)

2024-09-10 15:58:50 +01:00

files_test.go

fix: handle potential DB conflict due to concurrent upload requests in postFile (#19005)

2025-07-30 13:55:30 -07:00

files.go

fix: handle potential DB conflict due to concurrent upload requests in postFile (#19005)

2025-07-30 13:55:30 -07:00

gitsshkey_test.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

gitsshkey.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

inboxnotifications_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications.go

fix(coderd): fix panics by always checking for non-nil request logger (#18228)

2025-06-12 13:50:50 +03:00

insights_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

insights.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

latencycheck.go

…

mcp_http.go

feat: add MCP tools for ChatGPT (#19102)

2025-08-04 14:11:22 +02:00

members_test.go

chore: update error message for duplicate organization members (#17594)

2025-04-28 14:51:33 -06:00

members.go

chore: revert feat(enterprise/coderd): allow system users to be added to groups (#19254)

2025-08-08 12:18:07 +01:00

notifications_test.go

feat(coderd): add new dispatch logic for coder inbox (#16764)

2025-03-05 22:43:18 +01:00

notifications.go

feat(coderd): add new dispatch logic for coder inbox (#16764)

2025-03-05 22:43:18 +01:00

oauth2_error_compliance_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_metadata_test.go

feat: implement RFC 6750 Bearer token authentication (#18644)

2025-07-02 19:14:54 +02:00

oauth2_metadata_validation_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_security_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_test.go

refactor: organize OAuth2 provider tests into dedicated packages (#18747)

2025-07-03 20:41:47 +02:00

oauth2.go

refactor: simplify OAuth2 authorization flow and use 302 redirects (#18923)

2025-07-20 16:22:52 +02:00

organizations_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organizations.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

pagination_test.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

pagination.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

parameters_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

parameters.go

chore: refactor dynamic parameters into dedicated package (#18420)

2025-06-20 13:00:39 -05:00

presets_test.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

presets.go

feat: support icon and description in preset (#18977)

2025-07-28 15:02:26 +01:00

provisionerdaemons_test.go

fix: return provisioners in desc order and add limit to cli (#16720)

2025-02-26 21:06:51 +02:00

provisionerdaemons.go

feat(coderd/httpapi): add QueryParamParser.JSONStringMap (#16578)

2025-02-18 14:14:30 +00:00

provisionerjobs_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs_test.go

feat: add provisioner daemon name to provisioner jobs responses (#17877)

2025-05-19 16:05:39 +01:00

provisionerjobs.go

fix: add constraint and runtime check for provisioner logs size limit (#18893)

2025-07-30 19:09:53 -05:00

roles_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

roles.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

tailnet_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

tailnet.go

fix: use client preferred URL for the default DERP (#18911)

2025-07-17 20:17:44 +10:00

templates_test.go

fix!: support empty or default fields when updating templates (#19256)

2025-08-12 11:37:44 -05:00

templates.go

fix!: support empty or default fields when updating templates (#19256)

2025-08-12 11:37:44 -05:00

templateversions_test.go

feat: validate presets on template import (#18844)

2025-07-30 15:28:56 +02:00

templateversions.go

fix: add constraint and runtime check for provisioner logs size limit (#18893)

2025-07-30 19:09:53 -05:00

updatecheck_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck.go

…

userauth_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

userauth.go

chore: add custom samesite options to auth cookies (#16885)

2025-04-08 14:15:14 -05:00

users_test.go

fix: use system context for querying workspaces when deleting users (#19211)

2025-08-07 16:31:27 +10:00

users.go

fix: generalize password invalid message (#19307)

2025-08-11 12:20:02 -07:00

webpush_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

webpush.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

workspaceagentportshare_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

workspaceagentportshare.go

docs: fix swagger documentation for DELETE port share endpoint (#18426)

2025-06-18 14:07:53 +00:00

workspaceagents_test.go

feat(site): use websocket connection for devcontainer updates (#18808)

2025-07-14 21:35:35 +01:00

workspaceagents.go

fix: sanitize app status summary (#19075)

2025-07-29 15:24:11 +01:00

workspaceagentsrpc_internal_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceagentsrpc_test.go

fix: remove unnecessary user lookup in agent API calls (#17934)

2025-05-20 17:07:50 +02:00

workspaceagentsrpc.go

chore: rename service -> coder_service, remove agent_id label (#19241)

2025-08-07 13:58:39 -05:00

workspaceapps_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

workspaceapps.go

feat: enable key rotation (#15066)

2024-10-25 17:14:35 +01:00

workspacebuilds_test.go

feat: extend workspace build reasons to track connection types (#18827)

2025-07-22 13:11:27 +02:00

workspacebuilds.go

feat: extend workspace build reasons to track connection types (#18827)

2025-07-22 13:11:27 +02:00

workspaceproxies_test.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceproxies.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceresourceauth_test.go

fix!: enforce regex for agent names (#16641)

2025-02-20 05:09:26 +00:00

workspaceresourceauth.go

…

workspaces_test.go

test: add tests for updating workspace acl (#19240)

2025-08-07 17:09:46 -06:00

workspaces.go

fix: disallow lifecycle endpoints for prebuilt workspaces (#19264)

2025-08-14 11:30:19 +01:00

workspaceupdates_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceupdates.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00