Ethan 761adfa62a fix(coderd/rbac): grant template admin read access to dormant workspaces (#23554) ...

## Summary

Template admins could **list** dormant workspaces but could not **read**
them individually, resulting in a 403 when clicking into a dormant
workspace that was visible in the list.

### Root cause

- `GetWorkspaces` prepares its SQL authorization filter against the
`workspace` type, so dormant workspaces pass the filter and appear in
list results for template admins.
- `GetWorkspaceByID` calls `RBACObject()` on the fetched workspace,
which returns `workspace_dormant` when `DormantAt` is set. Template
admin had zero permissions on that type, so the read was denied.

### Fix

Add `ActionRead` on `ResourceWorkspaceDormant` to both the site-level
`template-admin` and org-level `organization-template-admin` roles. This
is the minimal grant needed to make list and read consistent without
granting any lifecycle permissions (create, update, delete, stop, etc.)
on dormant workspaces.

Split the `WorkspaceDormant` RBAC test case into `WorkspaceDormantRead`
(read only) and `WorkspaceDormant` (remaining write/lifecycle actions)
so the new permission can be asserted independently.

Template admins can read non-dormant workspaces, so this is the only
missing permission.

---

> This PR was generated with Coder agents and reviewed by a human.

2026-05-04 01:55:28 +00:00

..

agentapi

feat: add exit code and status to workspace agent scripts (#24505)

2026-04-29 12:24:26 -08:00

agentmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

aibridge

feat: add chatgpt support for aibridge proxy (#23826)

2026-03-31 12:54:38 -04:00

aiseats

feat: track ai seat usage (#22682)

2026-03-16 12:36:26 -05:00

apidoc

chore: remove agents experiment flag and mark feature as beta (#24432)

2026-05-01 01:49:00 +10:00

apikey

fix: initialize API key LastUsed to Unix epoch instead of zero time (#22327)

2026-03-02 16:02:01 +01:00

appearance

…

audit

feat: audit user secret create, update, and delete (#24756)

2026-04-29 12:57:47 -06:00

autobuild

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

awsidentity

…

azureidentity

chore: update azure certs (#21265)

2025-12-15 13:44:44 -09:00

boundaryusage

fix: make boundary usage telemetry collection atomic (#21907)

2026-02-06 09:52:17 -07:00

cachecompress

fix(site): avoid duplicating bin download headers (#22981)

2026-03-13 00:22:55 +11:00

coderdtest

fix: match on ID instead of username (#24797)

2026-04-29 12:24:52 -08:00

connectionlog

feat: batch connection logs to avoid DB lock contention (#23727)

2026-04-03 15:47:26 -05:00

cryptokeys

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

database

feat: add user_oidc auth type for MCP servers (#24793)

2026-05-03 11:31:48 -04:00

devtunnel

chore: remove unnecessary loop variable captures (#22180)

2026-02-19 09:02:19 +00:00

dynamicparameters

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

entitlements

feat: add Prometheus metrics for license warnings and errors (#21749)

2026-01-29 13:50:15 +01:00

externalauth

fix(coderd/externalauth): detect rate-limit 403/429 and narrow isFailedRefresh (#24334)

2026-04-28 18:03:35 +03:00

files

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

gitsshkey

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

healthcheck

fix(coderd/healthcheck/derphealth): avoid data races in DERP report (#24795)

2026-04-28 13:06:45 -07:00

httpapi

fix: prioritize context cancellation in WebSocket sendEvent (#23756)

2026-03-29 20:11:30 -04:00

httpmw

refactor: add dbgen chat generators and migrate test boilerplate (#24497)

2026-05-01 13:29:33 +01:00

idpsync

test: remove unnecessary dbauthz.AsSystemRestricted calls in tests (#22663)

2026-03-05 20:29:49 +00:00

jobreaper

refactor: extract test helpers in coderd/jobreaper to reduce duplication (#23001)

2026-03-19 21:51:26 +00:00

jwtutils

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

mcp

fix(coderd): enforce ActionSSH in MCP HTTP agent connection path (#24607)

2026-04-22 12:34:17 +02:00

metricscache

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

notifications

feat: chat auto-archive owner digest notifications (#24643)

2026-04-28 08:56:36 +01:00

oauth2provider

fix: redirect OAuth2 authorization page to dashboard (#24499)

2026-04-27 23:26:17 +03:00

oauthpki

fix(coderd): support string type for oidc response's expires_in json property (#20152)

2025-10-15 17:37:37 +00:00

portsharing

…

pproflabel

chore: add tallyman events for ai seat tracking (#22689)

2026-03-18 09:30:22 -05:00

prebuilds

fix: make prebuild claiming durable and idempotent (#23108)

2026-04-02 23:51:02 +02:00

prometheusmetrics

feat: add coder_build_info metric (#24365)

2026-04-15 12:48:38 +00:00

promoauth

fix!: remove deprecated prometheus metrics (#21788)

2026-01-30 13:30:06 +01:00

provisionerdserver

feat: plumb user secrets through provisioner chain to terraform (#24542)

2026-04-27 08:26:07 -06:00

provisionerkey

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

proxyhealth

feat: add csp headers for embedded apps (#18374)

2025-06-17 09:00:32 -08:00

pubsub

feat(coderd): wire advisor runtime to admin config (#24622)

2026-04-30 15:07:33 +02:00

rbac

fix(coderd/rbac): grant template admin read access to dormant workspaces (#23554)

2026-05-04 01:55:28 +00:00

render

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

runtimeconfig

chore(coderd/runtimeconfig): remove dbmem from tests (#18790)

2025-07-08 14:31:05 +00:00

schedule

chore: remove unnecessary loop variable captures (#22180)

2026-02-19 09:02:19 +00:00

searchquery

perf: cap count queries and emit native UUID comparisons for audit/connection logs (#23835)

2026-04-07 07:24:53 -07:00

taskname

fix(coderd): strip markdown code fences from Anthropic task name responses (#23024)

2026-03-13 17:35:26 +00:00

telemetry

refactor: add dbgen chat generators and migrate test boilerplate (#24497)

2026-05-01 13:29:33 +01:00

testdata

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

tracing

fix: StatusWriter Unwrap and process output error recovery (#23383)

2026-03-20 20:00:55 +00:00

updatecheck

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

usage

chore: add tallyman events for ai seat tracking (#22689)

2026-03-18 09:30:22 -05:00

userpassword

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util

fix(coderd): actually wire the chat template allowlist into tools (#23626)

2026-03-25 22:15:27 +00:00

webpush

fix: recover web push subscriptions after PWA reinstall (#24720)

2026-04-26 14:49:10 -07:00

workspaceapps

perf(coderd): cheaper chatd org membership checks (#24361)

2026-04-16 00:12:54 +10:00

workspacestats

feat: add Prometheus metrics for chatd subsystem (#24371)

2026-04-15 19:53:10 +01:00

wsbuilder

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

wspubsub

feat: add WatchAllWorkspaceBuilds endpoint for autostart scaletests (#22057)

2026-03-13 20:37:41 -07:00

x

fix(coderd/x/chatd): replay retry phase on subscribe (#24569)

2026-05-04 11:48:39 +10:00

activitybump_test.go

test: add testutil.WaitBuffer and replace time.Sleep in tests (#22922)

2026-03-12 18:07:52 +02:00

aitasks_internal_test.go

fix: set codersdk.Task current_state during task initialization (#20692)

2025-11-17 13:24:12 +00:00

aitasks_test.go

fix: return 409 Conflict instead of 502 when task agent is busy (#23424)

2026-03-23 09:52:34 +00:00

aitasks.go

fix: return 409 Conflict instead of 502 when task agent is busy (#23424)

2026-03-23 09:52:34 +00:00

apikey_scopes_validation_test.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

apikey_test.go

fix: persist session cookie to disk to prevent PWA logout (#23746)

2026-04-01 09:54:59 -04:00

apikey.go

fix: persist session cookie to disk to prevent PWA logout (#23746)

2026-04-01 09:54:59 -04:00

apiroot.go

…

audit_internal_test.go

feat: make database.Chat auditable (#24485)

2026-04-21 11:11:56 +01:00

audit_test.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

audit.go

feat: audit user secret create, update, and delete (#24756)

2026-04-29 12:57:47 -06:00

authorize_test.go

feat: add an organization member permission level (#19953)

2025-10-27 17:14:16 -06:00

authorize.go

feat: show friendly alert for missing agents-access role (#23831)

2026-03-31 17:26:58 +01:00

client_test.go

…

coderd_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderd_test.go

chore: switch agent gone response from 502 to 404 (#23090)

2026-03-25 09:57:28 -04:00

coderd.go

feat: add user_oidc auth type for MCP servers (#24793)

2026-05-03 11:31:48 -04:00

csp.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

debug_test.go

feat(coderd): add consolidated /debug/profile endpoint for pprof collection (#22892)

2026-03-13 14:09:39 +00:00

debug.go

feat(coderd): add consolidated /debug/profile endpoint for pprof collection (#22892)

2026-03-13 14:09:39 +00:00

deployment_test.go

…

deployment.go

chore: remove chats experiment (#18535)

2025-06-25 13:03:32 +00:00

deprecated.go

…

exp_chats_internal_test.go

feat(coderd): accept parameters in start_workspace tool (#24434)

2026-04-21 11:36:20 +10:00

exp_chats_test.go

refactor: add dbgen chat generators and migrate test boilerplate (#24497)

2026-05-01 13:29:33 +01:00

exp_chats.go

fix: add preset support to MCP tools (#24694)

2026-05-01 10:57:52 +01:00

experiments_test.go

chore: revert dynamic params as a safe experiment (#17510)

2025-04-22 16:21:15 +00:00

experiments.go

fix: do not warn on valid known experiments (#18514)

2025-06-24 09:14:41 +01:00

export_test.go

fix: add preset support to MCP tools (#24694)

2026-05-01 10:57:52 +01:00

externalauth_test.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

externalauth.go

feat!: support PKCE in the oauth2 client's auth/exchange flow (#21215)

2025-12-15 17:41:47 +00:00

files_test.go

test: share coderdtest instances to stop paying the startup tax 22 times (#23454)

2026-03-23 19:54:43 +00:00

files.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

gitsshkey_test.go

chore: distinct operations for provisioner's 'parse', 'init', 'plan', 'apply', 'graph' (#21064)

2025-12-15 11:26:41 -06:00

gitsshkey.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

inboxnotifications_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications.go

feat: chat auto-archive owner digest notifications (#24643)

2026-04-28 08:56:36 +01:00

initscript_test.go

test: share coderdtest instances to stop paying the startup tax 22 times (#23454)

2026-03-23 19:54:43 +00:00

initscript.go

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

insights_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights_test.go

fix(coderd): fix flaky TestGetUserStatusCounts timezone boundary (#22639)

2026-03-04 18:01:56 -08:00

insights.go

fix: user status change chart accommodates DST (#22191)

2026-03-04 12:54:39 +02:00

latencycheck.go

…

mcp_http.go

fix(coderd): enforce ActionSSH in MCP HTTP agent connection path (#24607)

2026-04-22 12:34:17 +02:00

mcp_internal_test.go

feat: add user_oidc auth type for MCP servers (#24793)

2026-05-03 11:31:48 -04:00

mcp_test.go

feat: add user_oidc auth type for MCP servers (#24793)

2026-05-03 11:31:48 -04:00

mcp.go

feat: add user_oidc auth type for MCP servers (#24793)

2026-05-03 11:31:48 -04:00

members_test.go

feat: make service accounts a Premium feature (#24020)

2026-04-07 12:25:32 -06:00

members.go

feat: display the AI add-on column in the UI on the Users and Organization Members tables (#23291)

2026-03-26 10:36:40 +00:00

notifications_test.go

chore: return 404, not 400 if missing or authz deny (#22069)

2026-02-13 08:19:07 -06:00

notifications.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

oauth2_error_compliance_test.go

test: reduce number of coderdtest instances (#23463)

2026-03-25 09:53:06 +00:00

oauth2_metadata_test.go

refactor: add RFC-compliant enum types and use SDK as source of truth (#21468)

2026-01-15 12:41:28 +03:00

oauth2_metadata_validation_test.go

test: share coderdtest instances in OAuth2 validation tests (#23455)

2026-03-23 21:03:34 +00:00

oauth2_security_test.go

test: reduce number of coderdtest instances (#23463)

2026-03-25 09:53:06 +00:00

oauth2_test.go

fix(coderd): use dbtime.Now() instead of time.Now() in test assertions against DB timestamps (#22685)

2026-03-06 09:14:11 +00:00

oauth2.go

feat: implement oauth2 RFC 7009 token revocation endpoint (#20362)

2025-10-22 15:18:42 -05:00

organizations_test.go

…

organizations.go

chore(coderd/database): remove deprecated db2sdk.List(Lazy)? methods (#21902)

2026-02-03 17:52:07 +00:00

pagination_test.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

pagination.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

parameters_test.go

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

parameters.go

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

presets_test.go

chore: remove unnecessary loop variable captures (#22180)

2026-02-19 09:02:19 +00:00

presets.go

feat: support icon and description in preset (#18977)

2025-07-28 15:02:26 +01:00

provisionerdaemons_test.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisionerdaemons.go

chore(coderd/database): remove deprecated db2sdk.List(Lazy)? methods (#21902)

2026-02-03 17:52:07 +00:00

provisionerjobs_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs_test.go

feat: add workspace build transition to provisioner job list (#24131)

2026-04-10 09:50:11 -05:00

provisionerjobs.go

feat: add exit code and status to workspace agent scripts (#24505)

2026-04-29 12:24:26 -08:00

roles_test.go

…

roles.go

feat: migrate agents-access to org-scoped system role for proper chat RBAC (#24438)

2026-04-23 17:59:42 +01:00

scopes_catalog_api_test.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

scopes_catalog.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

tailnet_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

tailnet.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00

templates_test.go

fix(coderd): allow template deletion when only prebuild workspaces remain (#23417)

2026-03-25 09:43:06 +02:00

templates.go

fix(coderd): allow template deletion when only prebuild workspaces remain (#23417)

2026-03-25 09:43:06 +02:00

templateversions_test.go

chore!: remove api.ts unnecessary calls (#22168)

2026-04-23 06:20:35 +10:00

templateversions.go

chore!: remove api.ts unnecessary calls (#22168)

2026-04-23 06:20:35 +10:00

updatecheck_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck.go

…

userauth_test.go

test: reduce number of coderdtest instances (#23463)

2026-03-25 09:53:06 +00:00

userauth.go

refactor: replace sort.Strings with slices.Sort (#23457)

2026-03-23 23:19:23 +02:00

users_test.go

feat: add collapsible thinking blocks with configurable display mode (#24635)

2026-04-24 11:29:08 +00:00

users.go

feat: add role selector in the create user form (#24711)

2026-04-29 10:57:10 -04:00

usersecrets_audit_test.go

feat: audit user secret create, update, and delete (#24756)

2026-04-29 12:57:47 -06:00

usersecrets_test.go

feat: add secret value and file path validation (#24269)

2026-04-13 07:24:34 -06:00

usersecrets.go

feat: audit user secret create, update, and delete (#24756)

2026-04-29 12:57:47 -06:00

webpush_internal_test.go

fix(coderd): validate webpush subscription endpoints (#24347)

2026-04-15 11:31:43 +02:00

webpush_test.go

fix: recover web push subscriptions after PWA reinstall (#24720)

2026-04-26 14:49:10 -07:00

webpush.go

fix(coderd): validate webpush subscription endpoints (#24347)

2026-04-15 11:31:43 +02:00

workspaceagentportshare_test.go

feat(coderd/rbac): make organization-member a per-org system custom role (#21359)

2026-01-12 18:19:19 -08:00

workspaceagentportshare.go

docs: fix swagger documentation for DELETE port share endpoint (#18426)

2025-06-18 14:07:53 +00:00

workspaceagents_active_chat_internal_test.go

refactor: add dbgen chat generators and migrate test boilerplate (#24497)

2026-05-01 13:29:33 +01:00

workspaceagents_chat_context_internal_test.go

refactor: add dbgen chat generators and migrate test boilerplate (#24497)

2026-05-01 13:29:33 +01:00

workspaceagents_chat_context_test.go

refactor: add dbgen chat generators and migrate test boilerplate (#24497)

2026-05-01 13:29:33 +01:00

workspaceagents_internal_test.go

fix(coderd): enforce workspace authz on watchChatGit (#24477)

2026-04-20 21:33:35 +10:00

workspaceagents_test.go

fix: mark connecting agents as unhealthy instead of healthy (#24044)

2026-04-09 13:21:28 +05:00

workspaceagents.go

feat: add exit code and status to workspace agent scripts (#24505)

2026-04-29 12:24:26 -08:00

workspaceagentsrpc_internal_test.go

test: use not before in TestAgentConnectionMonitor_* (#21332)

2025-12-22 10:21:39 +04:00

workspaceagentsrpc_test.go

test: add testutil.WaitBuffer and replace time.Sleep in tests (#22922)

2026-03-12 18:07:52 +02:00

workspaceagentsrpc.go

fix: limit calls to GetWorkspaceAgentByID in agentapi (#23015)

2026-03-20 15:42:05 -05:00

workspaceapps_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

workspaceapps.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

workspacebuilds_test.go

feat: add link for viewing raw build logs in workspace and template build jobs (#21727)

2026-02-03 09:45:23 +00:00

workspacebuilds.go

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

workspaceproxies_test.go

…

workspaceproxies.go

feat: add MCP server configuration backend for chats (#23227)

2026-03-19 14:07:36 +00:00

workspaceresourceauth_test.go

feat: support multiple agents with shared instance-identity auth (#24325)

2026-04-16 13:59:09 +02:00

workspaceresourceauth.go

feat: support multiple agents with shared instance-identity auth (#24325)

2026-04-16 13:59:09 +02:00

workspaces_scoped_test.go

chore: add permissions to coder:workspace.* scopes for functionality (#23515)

2026-03-25 13:46:58 -05:00

workspaces_test.go

feat: add exit code and status to workspace agent scripts (#24505)

2026-04-29 12:24:26 -08:00

workspaces.go

feat: add secret requirement contract to dynamic parameters (#24785)

2026-04-29 16:38:26 -07:00

workspaceupdates_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceupdates.go

chore: arrange imports in a standard way (#21452)

2026-01-08 15:24:11 +04:00