mirror of
https://github.com/coder/coder.git
synced 2026-06-04 21:48:22 +00:00
Kyle Carberry
391b22aef7
Adds `coder exp chat context add` and `coder exp chat context clear` commands that run inside a workspace to manage chat context files via the agent token. `add` reads instruction and skill files from a directory (defaulting to cwd) and inserts them as context-file messages into an active chat. Multiple calls are additive — `instructionFromContextFiles` already accumulates all context-file parts across messages. `clear` soft-deletes all context-file messages, causing `contextFileAgentID()` to return `!found` on the next turn, which triggers `needsInstructionPersist=true` and re-fetches defaults from the agent. Both commands auto-detect the target chat via `CODER_CHAT_ID` (already set by `agentproc` on chat-spawned processes), or fall back to single-active-chat resolution for the agent. The `--chat` flag overrides both. Also adds sub-agent context inheritance: `createChildSubagentChat` now copies parent context-file messages to child chats at spawn time, so delegated sub-agents share the same instruction context without independently re-fetching from the workspace agent. <details><summary>Implementation details</summary> **New files:** - `cli/exp_chat.go` — CLI command tree under `coder exp chat context` **Modified files:** - `agent/agentcontextconfig/api.go` — `ConfigFromDir()` reads context from an arbitrary directory without env vars - `codersdk/agentsdk/agentsdk.go` — `AddChatContext`/`ClearChatContext` SDK methods - `coderd/workspaceagents.go` — POST/DELETE handlers on `/workspaceagents/me/chat-context` - `coderd/coderd.go` — Route registration - `coderd/database/queries/chats.sql` — `GetActiveChatsByAgentID`, `SoftDeleteContextFileMessages` - `coderd/database/dbauthz/dbauthz.go` — RBAC implementations for new queries - `coderd/x/chatd/subagent.go` — `copyParentContextFiles` for sub-agent inheritance - `cli/root.go` — Register `chatCommand()` in `AGPLExperimental()` **Auth pattern:** Uses `AgentAuth` (same as `coder external-auth`) — agent token via `CODER_AGENT_TOKEN` + `CODER_AGENT_URL` env vars. </details> > 🤖 Generated by Coder Agents --------- Co-authored-by: Michael Suchacz <203725896+ibetitsmike@users.noreply.github.com>
77 lines
2.0 KiB
Go
77 lines
2.0 KiB
Go
package coderd
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/coderd/database"
|
|
"github.com/coder/coder/v2/coderd/database/dbauthz"
|
|
"github.com/coder/coder/v2/coderd/database/dbfake"
|
|
"github.com/coder/coder/v2/coderd/database/dbgen"
|
|
"github.com/coder/coder/v2/coderd/database/dbtestutil"
|
|
"github.com/coder/coder/v2/testutil"
|
|
)
|
|
|
|
func TestActiveAgentChatDefinitionsAgree(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := dbauthz.AsSystemRestricted(testutil.Context(t, testutil.WaitMedium))
|
|
db, _ := dbtestutil.NewDB(t)
|
|
|
|
org, err := db.GetDefaultOrganization(ctx)
|
|
require.NoError(t, err)
|
|
|
|
owner := dbgen.User(t, db, database.User{})
|
|
workspace := dbfake.WorkspaceBuild(t, db, database.WorkspaceTable{
|
|
OrganizationID: org.ID,
|
|
OwnerID: owner.ID,
|
|
}).WithAgent().Do()
|
|
modelConfig := insertAgentChatTestModelConfig(ctx, t, db, owner.ID)
|
|
|
|
insertedChats := make([]database.Chat, 0, len(database.AllChatStatusValues())*2)
|
|
for _, archived := range []bool{false, true} {
|
|
for _, status := range database.AllChatStatusValues() {
|
|
chat, err := db.InsertChat(ctx, database.InsertChatParams{
|
|
Status: status,
|
|
OwnerID: owner.ID,
|
|
LastModelConfigID: modelConfig.ID,
|
|
Title: fmt.Sprintf("%s-archived-%t", status, archived),
|
|
AgentID: uuid.NullUUID{UUID: workspace.Agents[0].ID, Valid: true},
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
if archived {
|
|
_, err = db.ArchiveChatByID(ctx, chat.ID)
|
|
require.NoError(t, err)
|
|
|
|
chat, err = db.GetChatByID(ctx, chat.ID)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
insertedChats = append(insertedChats, chat)
|
|
}
|
|
}
|
|
|
|
activeChats, err := db.GetActiveChatsByAgentID(ctx, workspace.Agents[0].ID)
|
|
require.NoError(t, err)
|
|
|
|
activeByID := make(map[uuid.UUID]bool, len(activeChats))
|
|
for _, chat := range activeChats {
|
|
activeByID[chat.ID] = true
|
|
}
|
|
|
|
for _, chat := range insertedChats {
|
|
require.Equalf(
|
|
t,
|
|
isActiveAgentChat(chat),
|
|
activeByID[chat.ID],
|
|
"status=%s archived=%t",
|
|
chat.Status,
|
|
chat.Archived,
|
|
)
|
|
}
|
|
}
|