mirror of
https://github.com/coder/coder.git
synced 2026-06-03 04:58:23 +00:00
Zach
6832ca3cd9
http.DefaultTransport is shared with httptest.Server, which calls CloseIdleConnections on it during Close. Parallel subtests sharing this transport could see their in-flight requests broken with 'net/http: HTTP/1.x transport connection broken: http: CloseIdleConnections called'. Most visibly this flaked TestExternalAuthCallback/ValidateURL. Lazily create a dedicated http.Client per OAuth2Config so its idle connection pool is not affected by unrelated httptest.Server.Close calls. Generated with assistance from Coder Agents.
69 lines
1.7 KiB
Go
69 lines
1.7 KiB
Go
package testutil
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/url"
|
|
"sync"
|
|
"time"
|
|
|
|
"golang.org/x/oauth2"
|
|
|
|
"github.com/coder/coder/v2/coderd/promoauth"
|
|
)
|
|
|
|
type OAuth2Config struct {
|
|
Token *oauth2.Token
|
|
TokenSourceFunc OAuth2TokenSource
|
|
|
|
httpClientOnce sync.Once
|
|
httpClient *http.Client
|
|
}
|
|
|
|
// Do issues req using a dedicated http.Client per OAuth2Config so a
|
|
// parallel httptest.Server.Close() (which calls CloseIdleConnections
|
|
// on http.DefaultTransport) cannot break our in-flight requests.
|
|
func (c *OAuth2Config) Do(_ context.Context, _ promoauth.Oauth2Source, req *http.Request) (*http.Response, error) {
|
|
c.httpClientOnce.Do(func() {
|
|
c.httpClient = &http.Client{Transport: &http.Transport{}}
|
|
})
|
|
return c.httpClient.Do(req)
|
|
}
|
|
|
|
func (*OAuth2Config) AuthCodeURL(state string, _ ...oauth2.AuthCodeOption) string {
|
|
return "/?state=" + url.QueryEscape(state)
|
|
}
|
|
|
|
func (c *OAuth2Config) Exchange(_ context.Context, _ string, _ ...oauth2.AuthCodeOption) (*oauth2.Token, error) {
|
|
if c.Token == nil {
|
|
return &oauth2.Token{
|
|
AccessToken: "access_token",
|
|
RefreshToken: "refresh_token",
|
|
Expiry: time.Now().Add(time.Hour),
|
|
}, nil
|
|
}
|
|
return c.Token, nil
|
|
}
|
|
|
|
func (c *OAuth2Config) TokenSource(_ context.Context, _ *oauth2.Token) oauth2.TokenSource {
|
|
if c.TokenSourceFunc == nil {
|
|
return OAuth2TokenSource(func() (*oauth2.Token, error) {
|
|
if c.Token == nil {
|
|
return &oauth2.Token{
|
|
AccessToken: "access_token",
|
|
RefreshToken: "refresh_token",
|
|
Expiry: time.Now().Add(time.Hour),
|
|
}, nil
|
|
}
|
|
return c.Token, nil
|
|
})
|
|
}
|
|
return c.TokenSourceFunc
|
|
}
|
|
|
|
type OAuth2TokenSource func() (*oauth2.Token, error)
|
|
|
|
func (o OAuth2TokenSource) Token() (*oauth2.Token, error) {
|
|
return o()
|
|
}
|