Mathias Fredriksson 2a1984f0e8 fix(coderd/externalauth): save refreshed token before validation (#24332) ...

GitHub rotates refresh tokens on use, invalidating the old token
immediately. If post-refresh validation fails (e.g. rate-limited
403 from /user), the new token was silently discarded because the
DB save only happened after successful validation. The next refresh
attempt would use the stale refresh token, fail permanently, and
destroy the token.

Move the UpdateExternalAuthLink call to immediately after
TokenSource.Token() succeeds. The post-validation save block is
removed (dead code after the early save). The DB write uses a
detached context (context.WithoutCancel) so a canceled request
cannot prevent persistence of the already-consumed refresh token.

2026-04-18 14:28:29 +03:00

..

gitprovider

feat: add head_branch to pull request diff status (#23076)

2026-03-14 17:24:19 +00:00

externalauth_internal_test.go

feat(coderd): refactors github pr sync functionality (#22715)

2026-03-10 18:46:01 +00:00

externalauth_test.go

fix(coderd/externalauth): save refreshed token before validation (#24332)

2026-04-18 14:28:29 +03:00

externalauth.go

fix(coderd/externalauth): save refreshed token before validation (#24332)

2026-04-18 14:28:29 +03:00