Danielle Maywood f2a1a7e8c3 fix(coderd): gate AI task notifications on agent ready state (#20690) ...

Relates to https://github.com/coder/internal/issues/1098

Currently AgentAPI waits for only 2 seconds worth of identical terminal
screen snapshots before deciding a task has entered a "stable" state. We
interpret this as becoming "idle", resulting in a notification being
triggered. This behavior is not ideal and is ultimately the root cause
of our spammy notifications.

Unfortunately, until we move AgentAPI to either use the Claude Code SDK
(or ACP wrapper around it), we are unable to easily fix the root cause.

This PR instead waits until the agent is ready before it will send state
change notifications. This will at least resolve _some_ of the
complaints about task state notifications being too spammy.

---

🤖 PR was written by Claude Sonnet 4.5 using [Coder
Mux](https://github.com/coder/cmux) and reviewed by a human 👩

2025-11-10 16:00:13 +00:00

..

agentapi

fix: refactor agent resource monitoring API to avoid excessive calls to DB (#20430)

2025-10-28 13:38:16 -07:00

agentmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

apidoc

chore: add API key ID to interceptions (#20513)

2025-11-10 13:46:41 +01:00

apikey

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

appearance

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

audit

feat(coderd): add audit resource for tasks (#20301)

2025-10-15 16:13:59 +00:00

autobuild

fix(coderd): ensure lifecycle executor has sufficient task permissions (#20539)

2025-10-29 15:44:35 +00:00

awsidentity

fix: add new aws regions to instance identity (#10434)

2023-10-30 19:44:29 +00:00

azureidentity

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderdtest

chore: log with %s on unexpected non-sdk err (#20570)

2025-10-30 10:23:52 -08:00

connectionlog

fix: avoid connection logging crashes in agent (#20307)

2025-10-16 01:56:43 +11:00

cryptokeys

chore: update to coder/quartz v0.2.0 (#18007)

2025-05-27 16:05:03 +04:00

database

chore: add API key ID to interceptions (#20513)

2025-11-10 13:46:41 +01:00

devtunnel

chore: disable devtunnel tests on windows (#18521)

2025-06-24 19:01:29 +10:00

dynamicparameters

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

entitlements

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

externalauth

fix: add default value for RevokeURL property in external auth config for GitHub (#20272)

2025-10-14 09:28:10 +02:00

files

fix: remove hold WaitGroup in TestConcurrentFetch (#19617)

2025-09-03 09:25:49 +04:00

gitsshkey

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

healthcheck

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

httpapi

chore: bring back x-auth-checks with a length limit (#19928)

2025-09-24 10:46:50 -06:00

httpmw

feat(coderd): add lookup task by name in httpmw.TaskParam (#20647)

2025-11-05 14:28:34 +00:00

idpsync

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

jobreaper

fix: allow unhanger to unhang dormant workspaces (#20229)

2025-10-09 17:33:57 +11:00

jwtutils

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

mcp

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

metricscache

test: fix TestCache_DeploymentStats flake (#19683)

2025-09-08 12:07:38 +10:00

notifications

chore: remove references to dbtestutil.WillUsePostgres (#20436)

2025-10-23 14:24:54 +02:00

oauth2provider

chore: add revocation endpoint to oauth well-known (#20561)

2025-10-29 16:44:53 -05:00

oauthpki

fix(coderd): support string type for oidc response's expires_in json property (#20152)

2025-10-15 17:37:37 +00:00

portsharing

fix: properly convert max port share level for oss (#13261)

2024-05-13 14:37:51 -04:00

pproflabel

chore: add usage tracking package (#19095)

2025-08-16 01:31:00 +10:00

prebuilds

feat: add prebuilds reconciliation duration metric (#20535)

2025-10-29 12:52:30 +00:00

prometheusmetrics

fix: remove unintentionally added print in test code (#20391)

2025-10-20 18:51:15 -07:00

promoauth

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

provisionerdserver

fix(coderd): remove deprecated AITaskSidebarApp column (#20680)

2025-11-07 12:45:45 +02:00

provisionerkey

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

proxyhealth

feat: add csp headers for embedded apps (#18374)

2025-06-17 09:00:32 -08:00

pubsub

feat(coderd): add inbox notifications endpoints (#16889)

2025-03-18 00:02:47 +01:00

rbac

refactor: use task data model for notifications (#20590)

2025-10-31 15:53:27 +02:00

render

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

runtimeconfig

chore(coderd/runtimeconfig): remove dbmem from tests (#18790)

2025-07-08 14:31:05 +00:00

schedule

chore: improve build deadline code (#19203)

2025-08-07 11:00:31 +10:00

searchquery

feat(coderd): use task data model for list (#20394)

2025-10-23 20:22:51 +03:00

taskname

fix(coderd/taskname): ensure generated name is within 32 byte limit (#19612)

2025-08-28 12:58:02 +01:00

telemetry

fix(coderd): remove deprecated AITaskSidebarApp column (#20680)

2025-11-07 12:45:45 +02:00

testdata

feat: include template variables in dynamic parameter rendering (#18819)

2025-07-21 13:02:31 -05:00

tracing

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck

chore(coderd/updatecheck): remove dbmem from tests (#18792)

2025-07-08 14:32:46 +00:00

usage

chore: add unknown usage event type error (#19436)

2025-08-22 16:32:35 +10:00

userpassword

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util

chore: migrate from tenv linter to usetesting linter (#20401)

2025-10-21 15:10:47 -06:00

webpush

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

workspaceapps

feat: add an organization member permission level (#19953)

2025-10-27 17:14:16 -06:00

workspacestats

chore: remove references to dbtestutil.WillUsePostgres (#20436)

2025-10-23 14:24:54 +02:00

wsbuilder

feat(coderd): implement task to app linking (#20237)

2025-10-13 12:57:06 +03:00

wspubsub

feat: add app status tracking to the backend (#17163)

2025-03-31 10:55:44 -04:00

activitybump_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

aitasks_test.go

fix(coderd): gate AI task notifications on agent ready state (#20690)

2025-11-10 16:00:13 +00:00

aitasks.go

fix(coderd): fix template ai task check error message (#20651)

2025-11-03 12:54:43 +00:00

apikey_scopes_validation_test.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

apikey_test.go

feat: add allow list to API keys (#19972)

2025-10-24 12:33:56 +01:00

apikey.go

feat: add allow_list to resource-scoped API tokens (#19964)

2025-10-09 14:53:08 +02:00

apiroot.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

audit_internal_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit_test.go

chore: mark workspace apps and workspace agents as unaudited (#18761)

2025-07-15 16:08:42 +10:00

audit.go

fix(coderd): fix audit log resource link for tasks (#20545)

2025-10-29 15:31:41 +00:00

authorize_test.go

feat: add an organization member permission level (#19953)

2025-10-27 17:14:16 -06:00

authorize.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

client_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

coderd_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderd_test.go

chore(testutil): add testutil.GoleakOptions (#16070)

2025-01-08 15:38:37 +00:00

coderd.go

fix: deprecate codersdk.AITaskPromptParameterName and reduce usage (#20501)

2025-10-29 18:59:12 +00:00

csp.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

debug_test.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

debug.go

feat: mount pprof and metrics to /api/v2/debug for admins (#20353)

2025-10-21 03:13:11 +00:00

deployment_test.go

fix(coderd): mark provisioner daemon psk as secret (#12322)

2024-02-27 16:33:32 +00:00

deployment.go

chore: remove chats experiment (#18535)

2025-06-25 13:03:32 +00:00

deprecated.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

experiments_test.go

chore: revert dynamic params as a safe experiment (#17510)

2025-04-22 16:21:15 +00:00

experiments.go

fix: do not warn on valid known experiments (#18514)

2025-06-24 09:14:41 +01:00

externalauth_test.go

feat: add best effort attempt to revoke oauth access token in external auth provider (#19775)

2025-09-19 16:27:02 +02:00

externalauth.go

feat: add best effort attempt to revoke oauth access token in external auth provider (#19775)

2025-09-19 16:27:02 +02:00

files_test.go

ci: improve 'tfail in goroutine' ruleguard rule (#19682)

2025-09-04 14:28:29 +10:00

files.go

fix: handle potential DB conflict due to concurrent upload requests in postFile (#19005)

2025-07-30 13:55:30 -07:00

gitsshkey_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

gitsshkey.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

inboxnotifications_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications.go

fix(coderd): fix panics by always checking for non-nil request logger (#18228)

2025-06-12 13:50:50 +03:00

initscript_test.go

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

initscript.go

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

insights_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights_test.go

chore: refactor cli and coderd to use ClientOptions (#19763)

2025-09-22 21:02:56 +04:00

insights.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

latencycheck.go

chore: add prometheus timing to latency endpoint (#7742)

2023-06-06 10:26:13 -05:00

mcp_http.go

chore: refactor cli and coderd to use ClientOptions (#19763)

2025-09-22 21:02:56 +04:00

members_test.go

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

members.go

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

notifications_test.go

feat: support custom notifications (#19751)

2025-09-11 15:08:57 +02:00

notifications.go

feat: support custom notifications (#19751)

2025-09-11 15:08:57 +02:00

oauth2_error_compliance_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_metadata_test.go

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

oauth2_metadata_validation_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_security_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_test.go

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

oauth2.go

feat: implement oauth2 RFC 7009 token revocation endpoint (#20362)

2025-10-22 15:18:42 -05:00

organizations_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organizations.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

pagination_test.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

pagination.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

parameters_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

parameters.go

fix: add heartbeat to keep dynamic params websocket open (#20026)

2025-10-02 09:32:40 -05:00

presets_test.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

presets.go

feat: support icon and description in preset (#18977)

2025-07-28 15:02:26 +01:00

provisionerdaemons_test.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisionerdaemons.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisionerjobs_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs_test.go

chore: fix api param name (#20172)

2025-10-06 13:58:37 +02:00

provisionerjobs.go

chore: fix api param name (#20172)

2025-10-06 13:58:37 +02:00

roles_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

roles.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

scopes_catalog_api_test.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

scopes_catalog.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

tailnet_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

tailnet.go

refactor: convert workspacesdk.AgentConn to an interface (#19392)

2025-08-20 10:00:44 +01:00

templates_test.go

chore: remove references to dbtestutil.WillUsePostgres (#20436)

2025-10-23 14:24:54 +02:00

templates.go

chore: correct template API docs (#19228)

2025-08-19 15:14:25 +00:00

templateversions_test.go

chore: remove references to dbtestutil.WillUsePostgres (#20436)

2025-10-23 14:24:54 +02:00

templateversions.go

chore: add user details to aibridge interception list endpoint (#20397)

2025-10-22 16:18:31 +11:00

updatecheck_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

userauth_test.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

userauth.go

chore: add custom samesite options to auth cookies (#16885)

2025-04-08 14:15:14 -05:00

users_test.go

fix: check permission to update username (#20139)

2025-10-02 15:07:49 +02:00

users.go

feat: add allow list to API keys (#19972)

2025-10-24 12:33:56 +01:00

webpush_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

webpush.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

workspaceagentportshare_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

workspaceagentportshare.go

docs: fix swagger documentation for DELETE port share endpoint (#18426)

2025-06-18 14:07:53 +00:00

workspaceagents_internal_test.go

fix(coderd): ensure agent WebSocket conn is cleaned up (#19711)

2025-09-05 14:26:46 +01:00

workspaceagents_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

workspaceagents.go

fix(coderd): gate AI task notifications on agent ready state (#20690)

2025-11-10 16:00:13 +00:00

workspaceagentsrpc_internal_test.go

test: wait for completion before asserting in TestAgentConnectionMonitor_BuildOutdated (#19959)

2025-09-26 09:24:11 +04:00

workspaceagentsrpc_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

workspaceagentsrpc.go

chore: rename service -> coder_service, remove agent_id label (#19241)

2025-08-07 13:58:39 -05:00

workspaceapps_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

workspaceapps.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

workspacebuilds_test.go

fix(coderd): disallow POSTing a workspace build on a deleted workspace (#20584)

2025-10-30 13:32:18 +00:00

workspacebuilds.go

fix(coderd): remove deprecated AITaskSidebarApp column (#20680)

2025-11-07 12:45:45 +02:00

workspaceproxies_test.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceproxies.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceresourceauth_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

workspaceresourceauth.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

workspaces_test.go

fix(coderd): remove deprecated AITaskSidebarApp column (#20680)

2025-11-07 12:45:45 +02:00

workspaces.go

fix: update task link AppStatus using task_id (#20543)

2025-10-29 15:45:45 +00:00

workspaceupdates_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceupdates.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00