Spike Curtis b96f6b48a4 fix: ensure ssh cleanup happens on cmd error ...

I noticed in my logs that sometimes `coder ssh` doesn't gracefully disconnect from the coordinator.

The cause is the `closerStack` construct we use in that function.  It has two paths to start closing things down:

1. explicit `close()` which we do in `defer`
2. context cancellation, which happens if the cli function returns an error

sometimes the ssh remote command returns an error, and this triggers context cancellation of the `closerStack`.  That is fine in and of itself, but we still want the explicit `close()` to wait until everything is closed before returning, since that's where we do cleanup, including the graceful disconnect.  Prior to this fix the `close()` just immediately exits if another goroutine is closing the stack.  Here we add a wait until everything is done.

2024-03-07 17:26:49 +04:00

..

clibase

chore: provide usage instruction for CLI argument failures (#12309)

2024-02-28 12:10:17 -06:00

clilog

fix(enterprise/cli): add CODER_PROVISIONER_DAEMON_LOG_* options (#11279)

2023-12-19 16:49:50 +00:00

clistat

fix: handle no memory limit in coder stat mem (#11107)

2023-12-08 12:46:53 -05:00

clitest

fix: use flag to enable Prometheus (#12345)

2024-02-28 17:58:03 +01:00

cliui

feat: show tailnet peer diagnostics after coder ping (#12314)

2024-02-27 22:04:46 +04:00

cliutil

feat(cli): allow specifying name of provisioner daemon (#11077)

2023-12-07 16:59:13 +00:00

config

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

gitauth

refactor: split coderd/gitauth into two, add cli/gitauth (#9479)

2023-09-01 15:41:22 +00:00

telemetry

refactor(coderd/telemetry): move CLI telemetry to cli/telemetry (#9517)

2023-09-04 21:42:45 +03:00

testdata

fix(coderd): mark provisioner daemon psk as secret (#12322)

2024-02-27 16:33:32 +00:00

agent_internal_test.go

fix: Port forward should ignore coder ports (#7645)

2023-05-23 17:14:05 +02:00

agent_test.go

feat: use Agent v2 API for Service Banner (#11806)

2024-01-30 07:44:47 +04:00

agent.go

fix(cli): generate correctly named file in DumpHandler (#12409)

2024-03-04 18:35:33 +02:00

autoupdate_test.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

autoupdate.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

configssh_internal_test.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh_other.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh_test.go

feat(cli): support header and header-command in config-ssh (#10413)

2024-02-07 10:21:26 +02:00

configssh_windows.go

feat: add flag for Windows to create unix compatible filepaths (#8164)

2023-06-22 17:08:12 -05:00

configssh.go

feat(cli): support header and header-command in config-ssh (#10413)

2024-02-07 10:21:26 +02:00

create_test.go

feat: add support for optional external auth providers (#12021)

2024-02-21 11:18:38 -07:00

create.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

delete_test.go

fix: add postgres triggers to remove deleted users from user_links (#12117)

2024-02-20 13:19:38 -06:00

delete.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

dotfiles_test.go

feat(cli): make the dotfiles repository directory configurable (#10377)

2023-10-24 12:00:04 +03:00

dotfiles.go

feat(cli): make the dotfiles repository directory configurable (#10377)

2023-10-24 12:00:04 +03:00

errors.go

chore: provide usage instruction for CLI argument failures (#12309)

2024-02-28 12:10:17 -06:00

exp_scaletest_slim.go

fix(cli): remove exp scaletest from slim binary (#9934)

2023-10-03 15:13:04 +01:00

exp_scaletest_test.go

feat(cli/exp): add target workspace/users to scaletest commands (#11701)

2024-01-19 15:32:46 +00:00

exp_scaletest.go

fix(cli): scaletest: do not screenshot if verbose=false (#12317)

2024-02-27 12:35:48 +00:00

exp.go

chore: change cli error message handling (#9952)

2023-09-29 16:50:23 -05:00

externalauth_test.go

fix(cli): avoid panic when external auth name isn't provided (#12177)

2024-02-15 15:17:16 -06:00

externalauth.go

fix(cli): avoid panic when external auth name isn't provided (#12177)

2024-02-15 15:17:16 -06:00

favorite_test.go

feat(cli): add favorite/unfavorite commands (#11793)

2024-01-24 14:05:39 +00:00

favorite.go

feat(cli): add favorite/unfavorite commands (#11793)

2024-01-24 14:05:39 +00:00

gitaskpass_test.go

feat: add external-auth cli (#10052)

2023-10-09 23:04:35 +00:00

gitaskpass.go

fix: handle SIGHUP from OpenSSH (#10638)

2023-11-13 15:14:42 +04:00

gitssh_test.go

chore: refactor ResolveAutostart tests to use dbfake (#10603)

2023-11-30 19:33:04 -06:00

gitssh.go

fix: handle SIGHUP from OpenSSH (#10638)

2023-11-13 15:14:42 +04:00

help.go

perf(cli): optimize CPU consumption of help pages (#9607)

2023-09-14 19:48:29 -05:00

help.tpl

feat(cli): colorize help page (#9589)

2023-09-08 18:21:33 +00:00

list_test.go

chore: refactor ResolveAutostart tests to use dbfake (#10603)

2023-11-30 19:33:04 -06:00

list.go

feat(cli): show workspace favorite status in list output (#11878)

2024-01-29 14:14:12 +00:00

login_test.go

feat(coderd): add provisioner build version and api_version on serve (#11369)

2024-01-03 09:01:57 +00:00

login.go

feat: add customizable upgrade message on client/server version mismatch (#11587)

2024-01-30 17:11:37 -06:00

logout_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

logout.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

netcheck_test.go

refactor(coderd): move healthcheck report structs to codersdk (#12279)

2024-02-23 13:13:28 +00:00

netcheck.go

refactor(coderd/healthcheck): move derp report to derphealth package (#9506)

2023-09-04 21:41:50 +03:00

open_internal_test.go

feat(cli): add coder open vscode (#11191)

2024-01-02 20:46:18 +02:00

open_test.go

feat(cli): add coder open vscode (#11191)

2024-01-02 20:46:18 +02:00

open.go

feat(cli): add coder open vscode (#11191)

2024-01-02 20:46:18 +02:00

organization_test.go

feat: set organization context in coder organizations (#12265)

2024-02-26 11:39:26 -06:00

organization.go

chore(cli): use xerrors.Errorf instead of fmt.Errorf (#12368)

2024-02-29 18:58:48 +00:00

organizationmanage.go

chore(cli): use xerrors.Errorf instead of fmt.Errorf (#12368)

2024-02-29 18:58:48 +00:00

parameter_internal_test.go

feat(cli): provide parameter values via command line (#8898)

2023-08-09 13:00:25 +02:00

parameter.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

parameterresolver.go

feat(cli): create workspace using parameters from existing workspace (#10604)

2023-11-09 19:22:47 +01:00

ping_test.go

feat: show tailnet peer diagnostics after coder ping (#12314)

2024-02-27 22:04:46 +04:00

ping.go

feat: show tailnet peer diagnostics after coder ping (#12314)

2024-02-27 22:04:46 +04:00

portforward_internal_test.go

feat: Support for comma-separation and ranges in port-forward (#4166)

2022-10-03 11:58:43 +03:00

portforward_test.go

fix: use fake local network for port-forward tests (#11119)

2023-12-11 14:51:56 +04:00

portforward.go

fix: use fake local network for port-forward tests (#11119)

2023-12-11 14:51:56 +04:00

publickey_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

publickey.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

remoteforward.go

feat(cli/ssh): allow multiple remote forwards and allow missing local file (#11648)

2024-01-19 15:21:10 +02:00

rename_test.go

fix: generate new random username to prevent flake (#11501)

2024-01-08 19:09:14 +00:00

rename.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

resetpassword_slim.go

refactor(cli)!: remove reset-password from slim binary (#9520)

2023-09-04 19:38:53 +03:00

resetpassword_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

resetpassword.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

restart_test.go

fix: fix cliui prompt styling (#11899)

2024-01-29 13:56:43 -07:00

restart.go

fix: fix cliui prompt styling (#11899)

2024-01-29 13:56:43 -07:00

root_internal_test.go

feat: add customizable upgrade message on client/server version mismatch (#11587)

2024-01-30 17:11:37 -06:00

root_test.go

chore: remove organization requirement from convertGroup() (#12195)

2024-02-21 15:58:11 -06:00

root.go

fix(cli): generate correctly named file in DumpHandler (#12409)

2024-03-04 18:35:33 +02:00

schedule_internal_test.go

feat: cli: consolidate schedule-related commands (#2402)

2022-06-16 18:24:10 +01:00

schedule_test.go

chore: refactor ResolveAutostart tests to use dbfake (#10603)

2023-11-30 19:33:04 -06:00

schedule.go

feat(cli): allow showing schedules for multiple workspaces (#10596)

2023-11-10 13:51:49 +00:00

server_createadminuser_test.go

refactor(coderd/database): split Time and Now into dbtime package (#9482)

2023-09-01 16:50:12 +00:00

server_createadminuser.go

feat: capture cli logs in tests (#10669)

2023-11-14 22:56:27 +04:00

server_internal_test.go

fix: handle unescaped userinfo in postgres url (#11396)

2024-01-04 08:46:00 -05:00

server_slim.go

refactor(cli)!: remove reset-password from slim binary (#9520)

2023-09-04 19:38:53 +03:00

server_test.go

chore: consolidate various randomPort() implementations (#12362)

2024-02-29 12:51:44 +00:00

server.go

fix(cli): generate correctly named file in DumpHandler (#12409)

2024-03-04 18:35:33 +02:00

show_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

show.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

signal_unix.go

feat: Add external provisioner daemons (#4935)

2022-11-16 16:34:06 -06:00

signal_windows.go

feat: Add external provisioner daemons (#4935)

2022-11-16 16:34:06 -06:00

speedtest_test.go

chore: use dbfake for ssh tests rather than provisionerd (#10812)

2023-11-21 16:22:08 +04:00

speedtest.go

feat: add option to speedtest to dump a pcap of network traffic (#11848)

2024-01-29 09:57:31 -06:00

ssh_internal_test.go

fix: ensure ssh cleanup happens on cmd error

2024-03-07 17:26:49 +04:00

ssh_other.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh_test.go

chore: refactor agent routines that use the v2 API (#12223)

2024-02-23 11:04:23 +04:00

ssh_windows.go

feat(cli): implement ssh remote forward (#8515)

2023-07-20 12:05:39 +02:00

ssh.go

fix: ensure ssh cleanup happens on cmd error

2024-03-07 17:26:49 +04:00

start_test.go

fix: send end of logs when dbfake completes job (#11402)

2024-01-04 15:18:00 +04:00

start.go

fix(cli): ssh: auto-update workspace (#11773)

2024-01-23 18:01:44 +01:00

stat_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

stat.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

state_test.go

fix: parse username/workspace correctly on coder state push --build (#10974)

2023-12-04 09:58:35 +04:00

state.go

fix: parse username/workspace correctly on coder state push --build (#10974)

2023-12-04 09:58:35 +04:00

stop.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

support_test.go

feat(cli): add support cmd (#12328)

2024-03-01 17:13:50 +00:00

support.go

feat(cli): add support cmd (#12328)

2024-03-01 17:13:50 +00:00

templatecreate_test.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templatecreate.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templatedelete_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templatedelete.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templateedit_test.go

feat: add template activity_bump property (#11734)

2024-02-13 07:00:35 +00:00

templateedit.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templateinit_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

templateinit.go

chore: deprecate template create command in favor of template push (#11390)

2024-01-05 21:04:14 +00:00

templatelist_test.go

chore: ensure default org always exists (#12412)

2024-03-05 14:06:35 -06:00

templatelist.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templatepull_test.go

feat(cli): pull templates in zip format (#12032)

2024-02-06 19:17:29 +01:00

templatepull.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templatepush_test.go

chore: deprecate template create command in favor of template push (#11390)

2024-01-05 21:04:14 +00:00

templatepush.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templates.go

chore: deprecate template create command in favor of template push (#11390)

2024-01-05 21:04:14 +00:00

templatevariables_test.go

feat: load variables from tfvars files (#11549)

2024-01-12 15:08:23 +01:00

templatevariables.go

feat: load variables from tfvars files (#11549)

2024-01-12 15:08:23 +01:00

templateversionarchive_test.go

feat: archive template versions to hide them from the ui (#10179)

2023-10-11 09:26:22 -05:00

templateversionarchive.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

templateversions_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

templateversions.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

tokens_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

tokens.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

update_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

update.go

feat: add cli support for workspace automatic updates (#10438)

2023-11-02 14:41:34 -05:00

user_delete_test.go

fix: add requester IP to workspace build audit logs (#10242)

2023-10-18 15:08:02 -05:00

usercreate_test.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

usercreate.go

feat: implement organization context in the cli (#12259)

2024-02-26 10:03:49 -06:00

userdelete.go

feat(cli): add coder users delete command (#10115)

2023-10-09 11:47:57 -05:00

userlist_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

userlist.go

chore: add /v2 to import module path (#9072)

2023-08-18 18:55:43 +00:00

users.go

feat(cli): add coder users delete command (#10115)

2023-10-09 11:47:57 -05:00

userstatus_test.go

chore(cli): add linter to detect potential spurious usage of owner user in cli tests (#10133)

2023-10-10 11:14:20 +01:00

userstatus.go

feat(cli): add coder users delete command (#10115)

2023-10-09 11:47:57 -05:00

util_internal_test.go

feat: cli: consolidate schedule-related commands (#2402)

2022-06-16 18:24:10 +01:00

util.go

fix: prevent change in defaults if user unsets in template edit (#10793)

2023-11-20 18:14:30 -06:00

version_test.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

version.go

chore(cli): replace lipgloss with coder/pretty (#9564)

2023-09-07 16:28:22 -05:00

vscodessh_test.go

chore: use dbfake for ssh tests rather than provisionerd (#10812)

2023-11-21 16:22:08 +04:00

vscodessh.go

feat(cli/vscodessh): add support for --wait and scripts that block login (#10473)

2024-02-02 13:18:26 +02:00