mirror of
https://github.com/coder/coder.git
synced 2026-06-02 20:48:20 +00:00
Danny Kopping
79e007cf30
Previously the in-process aibridge daemon and the enterprise aibridgeproxy daemon both snapshotted their provider routing once at boot. Any `ai_providers` or `ai_provider_keys` mutation required a restart for either to pick it up. Add an `ai_providers_changed` pubsub channel that the CRUD handlers publish on after Create / Update / Delete. Both daemons subscribe: - **aibridged** rebuilds its `[]aibridge.Provider` snapshot via `BuildProviders` and swaps it into the pool atomically. Inflight requests keep serving against the bridge they already acquired; new acquires build against the new snapshot. Per-provider construction errors stay scoped to the offending row. - **aibridgeproxyd** rebuilds its routing snapshot from `GetAIProviders` and swaps the host→provider map atomically. The MITM listener picks up new providers without restart. DB read for aibridgeproxyd uses the existing `AsAIProviderMetadataReader` subject for routing-only access.
63 lines
2.1 KiB
Go
63 lines
2.1 KiB
Go
package coderd_test
|
|
|
|
import (
|
|
"context"
|
|
"sync/atomic"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/coderd/coderdtest"
|
|
coderpubsub "github.com/coder/coder/v2/coderd/pubsub"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/coder/v2/testutil"
|
|
)
|
|
|
|
// TestAIProvidersChangedPubsub asserts that the CRUD handlers publish
|
|
// on AIProvidersChangedChannel for the operations that affect the
|
|
// runtime provider set. Subscribers (aibridged, aibridgeproxyd) depend
|
|
// on these notifications to trigger their pool reload.
|
|
//
|
|
// The handlers publish best-effort and the payload is empty, so we
|
|
// assert "at least one event per mutation" via a counter.
|
|
func TestAIProvidersChangedPubsub(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
client, _, api := coderdtest.NewWithAPI(t, nil)
|
|
_ = coderdtest.CreateFirstUser(t, client)
|
|
ctx := testutil.Context(t, testutil.WaitLong)
|
|
|
|
var count atomic.Int64
|
|
unsubscribe, err := api.Pubsub.Subscribe(coderpubsub.AIProvidersChangedChannel, func(_ context.Context, _ []byte) {
|
|
count.Add(1)
|
|
})
|
|
require.NoError(t, err)
|
|
t.Cleanup(unsubscribe)
|
|
|
|
// Create.
|
|
req := codersdk.CreateAIProviderRequest{
|
|
Type: codersdk.AIProviderTypeOpenAI,
|
|
Name: "pubsub-openai",
|
|
Enabled: true,
|
|
BaseURL: "https://api.openai.com/v1/",
|
|
APIKeys: []string{"k1"},
|
|
}
|
|
//nolint:gocritic // Owner role is the audience for this endpoint.
|
|
created, err := client.CreateAIProvider(ctx, req)
|
|
require.NoError(t, err)
|
|
testutil.Eventually(ctx, t, func(_ context.Context) bool { return count.Load() >= 1 }, testutil.IntervalFast)
|
|
|
|
// Update.
|
|
newKey := "k2"
|
|
_, err = client.UpdateAIProvider(ctx, created.ID.String(), codersdk.UpdateAIProviderRequest{
|
|
APIKeys: &[]codersdk.AIProviderKeyMutation{{APIKey: &newKey}},
|
|
})
|
|
require.NoError(t, err)
|
|
testutil.Eventually(ctx, t, func(_ context.Context) bool { return count.Load() >= 2 }, testutil.IntervalFast)
|
|
|
|
// Delete.
|
|
err = client.DeleteAIProvider(ctx, created.ID.String())
|
|
require.NoError(t, err)
|
|
testutil.Eventually(ctx, t, func(_ context.Context) bool { return count.Load() >= 3 }, testutil.IntervalFast)
|
|
}
|