mirror of
https://github.com/coder/coder.git
synced 2026-06-03 13:08:25 +00:00
78bc5861e0
## Summary AI Bridge is moving to General Availability in v2.30 and will require the AI Governance Add-On license in future versions. This adds a soft warning for deployments using AI Bridge via Premium/Enterprise FeatureSet without an explicit AI Bridge add-on license. Relates to: https://github.com/coder/internal/issues/1226 ## Changes - Track whether AI Bridge was explicitly granted via license Features (add-on) vs inherited from FeatureSet - Show soft warning when AI Bridge is enabled and entitled via FeatureSet but not via explicit add-on - Changed AI Bridge enablement from hardcoded `true` to check `CODER_AIBRIDGE_ENABLED` deployment config ## Behavior Change AI Bridge is now only marked as "enabled" in entitlements when `CODER_AIBRIDGE_ENABLED=true` is set in the deployment config. Previously, it was always enabled for Premium/Enterprise licenses regardless of the config setting. This change ensures that users who do not use AI Bridge will not see the soft warning about the upcoming license requirement. ## Warning Message > AI Bridge is now Generally Available in v2.30. In a future Coder version, your deployment will require the AI Governance Add-On to continue using this feature. Please reach out to your account team or sales@coder.com to learn more. ## Behavior | Condition | Warning Shown | |-----------|---------------| | AI Bridge disabled | ❌ No | | AI Bridge enabled + explicit add-on license | ❌ No | | AI Bridge enabled + Premium/Enterprise FeatureSet (no add-on) | ✅ Yes | ## Screenshots ### 1. No license <img width="1708" height="577" alt="image" src="https://github.com/user-attachments/assets/cbdbfd4d-55de-4d70-8abf-2665f458e96f" /> ### 2. No license + CODER_AIBRIDGE_ENABLED=true <img width="1716" height="513" alt="image" src="https://github.com/user-attachments/assets/344aae76-7703-485f-b568-1f13a1efa48f" /> ### 3. Premium license + CODER_AIBRIDGE_ENABLED=false <img width="1687" height="389" alt="image" src="https://github.com/user-attachments/assets/c2be12b0-1c0f-438d-a293-f9ec9fe6a736" /> ### 4. Premium license + CODER_AIBRIDGE_ENABLED=true <img width="1707" height="525" alt="image" src="https://github.com/user-attachments/assets/1a4640e1-e656-4f9b-bed0-9390cb5d6a84" /> ## Notes - TODO comments added to mark code that should be removed when AI Bridge enforcement is added - Feature continues to work - this is just a transitional warning (soft enforcement)
228 lines
7.0 KiB
Go
228 lines
7.0 KiB
Go
package cli_test
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/cli/clitest"
|
|
"github.com/coder/coder/v2/coderd/coderdtest"
|
|
"github.com/coder/coder/v2/coderd/database"
|
|
"github.com/coder/coder/v2/coderd/database/dbgen"
|
|
"github.com/coder/coder/v2/coderd/database/dbtime"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/coder/v2/enterprise/coderd/coderdenttest"
|
|
"github.com/coder/coder/v2/enterprise/coderd/license"
|
|
"github.com/coder/coder/v2/testutil"
|
|
)
|
|
|
|
func TestAIBridgeListInterceptions(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("OK", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
dv := coderdtest.DeploymentValues(t)
|
|
dv.AI.BridgeConfig.Enabled = true
|
|
client, db, owner := coderdenttest.NewWithDatabase(t, &coderdenttest.Options{
|
|
Options: &coderdtest.Options{
|
|
DeploymentValues: dv,
|
|
},
|
|
LicenseOptions: &coderdenttest.LicenseOptions{
|
|
Features: license.Features{
|
|
codersdk.FeatureAIBridge: 1,
|
|
},
|
|
},
|
|
})
|
|
memberClient, member := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
|
|
now := dbtime.Now()
|
|
interception1 := dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: member.ID,
|
|
StartedAt: now.Add(-time.Hour),
|
|
}, &now)
|
|
interception2EndedAt := now.Add(time.Minute)
|
|
interception2 := dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: member.ID,
|
|
StartedAt: now,
|
|
}, &interception2EndedAt)
|
|
// Should not be returned because the user can't see it.
|
|
_ = dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: owner.UserID,
|
|
StartedAt: now.Add(-2 * time.Hour),
|
|
}, nil)
|
|
|
|
args := []string{
|
|
"aibridge",
|
|
"interceptions",
|
|
"list",
|
|
}
|
|
inv, root := newCLI(t, args...)
|
|
clitest.SetupConfig(t, memberClient, root)
|
|
|
|
ctx := testutil.Context(t, testutil.WaitLong)
|
|
|
|
out := bytes.NewBuffer(nil)
|
|
inv.Stdout = out
|
|
err := inv.WithContext(ctx).Run()
|
|
require.NoError(t, err)
|
|
|
|
// Reverse order because the order is `started_at ASC`.
|
|
requireHasInterceptions(t, out.Bytes(), []uuid.UUID{interception2.ID, interception1.ID})
|
|
})
|
|
|
|
t.Run("Filter", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
dv := coderdtest.DeploymentValues(t)
|
|
dv.AI.BridgeConfig.Enabled = true
|
|
client, db, owner := coderdenttest.NewWithDatabase(t, &coderdenttest.Options{
|
|
Options: &coderdtest.Options{
|
|
DeploymentValues: dv,
|
|
},
|
|
LicenseOptions: &coderdenttest.LicenseOptions{
|
|
Features: license.Features{
|
|
codersdk.FeatureAIBridge: 1,
|
|
},
|
|
},
|
|
})
|
|
memberClient, member := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
|
|
|
|
now := dbtime.Now()
|
|
|
|
// This interception should be returned since it matches all filters.
|
|
goodInterceptionEndedAt := now.Add(time.Minute)
|
|
goodInterception := dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: member.ID,
|
|
Provider: "real-provider",
|
|
Model: "real-model",
|
|
StartedAt: now,
|
|
}, &goodInterceptionEndedAt)
|
|
|
|
// These interceptions should not be returned since they don't match the
|
|
// filters.
|
|
_ = dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: owner.UserID,
|
|
Provider: goodInterception.Provider,
|
|
Model: goodInterception.Model,
|
|
StartedAt: goodInterception.StartedAt,
|
|
}, nil)
|
|
_ = dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: goodInterception.InitiatorID,
|
|
Provider: "bad-provider",
|
|
Model: goodInterception.Model,
|
|
StartedAt: goodInterception.StartedAt,
|
|
}, nil)
|
|
_ = dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: goodInterception.InitiatorID,
|
|
Provider: goodInterception.Provider,
|
|
Model: "bad-model",
|
|
StartedAt: goodInterception.StartedAt,
|
|
}, nil)
|
|
_ = dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: goodInterception.InitiatorID,
|
|
Provider: goodInterception.Provider,
|
|
Model: goodInterception.Model,
|
|
// Violates the started after filter.
|
|
StartedAt: now.Add(-2 * time.Hour),
|
|
}, nil)
|
|
_ = dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: goodInterception.InitiatorID,
|
|
Provider: goodInterception.Provider,
|
|
Model: goodInterception.Model,
|
|
// Violates the started before filter.
|
|
StartedAt: now.Add(2 * time.Hour),
|
|
}, nil)
|
|
|
|
args := []string{
|
|
"aibridge",
|
|
"interceptions",
|
|
"list",
|
|
"--started-after", now.Add(-time.Hour).Format(time.RFC3339),
|
|
"--started-before", now.Add(time.Hour).Format(time.RFC3339),
|
|
"--initiator", codersdk.Me,
|
|
"--provider", goodInterception.Provider,
|
|
"--model", goodInterception.Model,
|
|
}
|
|
inv, root := newCLI(t, args...)
|
|
clitest.SetupConfig(t, memberClient, root)
|
|
|
|
ctx := testutil.Context(t, testutil.WaitLong)
|
|
|
|
out := bytes.NewBuffer(nil)
|
|
inv.Stdout = out
|
|
err := inv.WithContext(ctx).Run()
|
|
require.NoError(t, err)
|
|
|
|
requireHasInterceptions(t, out.Bytes(), []uuid.UUID{goodInterception.ID})
|
|
})
|
|
|
|
t.Run("Pagination", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
dv := coderdtest.DeploymentValues(t)
|
|
dv.AI.BridgeConfig.Enabled = true
|
|
client, db, owner := coderdenttest.NewWithDatabase(t, &coderdenttest.Options{
|
|
Options: &coderdtest.Options{
|
|
DeploymentValues: dv,
|
|
},
|
|
LicenseOptions: &coderdenttest.LicenseOptions{
|
|
Features: license.Features{
|
|
codersdk.FeatureAIBridge: 1,
|
|
},
|
|
},
|
|
})
|
|
memberClient, member := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
|
|
|
|
now := dbtime.Now()
|
|
firstInterceptionEndedAt := now.Add(time.Minute)
|
|
firstInterception := dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: member.ID,
|
|
StartedAt: now,
|
|
}, &firstInterceptionEndedAt)
|
|
returnedInterception := dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: member.ID,
|
|
StartedAt: now.Add(-time.Hour),
|
|
}, &now)
|
|
_ = dbgen.AIBridgeInterception(t, db, database.InsertAIBridgeInterceptionParams{
|
|
InitiatorID: member.ID,
|
|
StartedAt: now.Add(-2 * time.Hour),
|
|
}, nil)
|
|
|
|
args := []string{
|
|
"aibridge",
|
|
"interceptions",
|
|
"list",
|
|
"--limit", "1",
|
|
"--after-id", firstInterception.ID.String(),
|
|
}
|
|
inv, root := newCLI(t, args...)
|
|
clitest.SetupConfig(t, memberClient, root)
|
|
|
|
ctx := testutil.Context(t, testutil.WaitLong)
|
|
|
|
out := bytes.NewBuffer(nil)
|
|
inv.Stdout = out
|
|
err := inv.WithContext(ctx).Run()
|
|
require.NoError(t, err)
|
|
|
|
// Only contains the second interception because after_id is the first
|
|
// interception, and we set a limit of 1.
|
|
requireHasInterceptions(t, out.Bytes(), []uuid.UUID{returnedInterception.ID})
|
|
})
|
|
}
|
|
|
|
func requireHasInterceptions(t *testing.T, out []byte, ids []uuid.UUID) {
|
|
t.Helper()
|
|
|
|
var results []codersdk.AIBridgeInterception
|
|
require.NoError(t, json.Unmarshal(out, &results))
|
|
require.Len(t, results, len(ids))
|
|
for i, id := range ids {
|
|
require.Equal(t, id, results[i].ID)
|
|
}
|
|
}
|