Spike Curtis 71c6dc4043 fix: stop disconnecting from coderd early and record disconnect correctly (#21250) ...

fixes https://github.com/coder/internal/issues/1196

The above issue exposes two different bugs in Coder.

In the agent, there is a race where if the agent is closed while starting up networking, it will erroneously disconnect from Coderd, which delays or breaks writing final status and logs.

In Coderd, there is a bug where we don't properly record the latest agent disconnection time if the agent had previously disconnected. This causes us to report the agent status as "Connected" even after it has disconnected up until the inactivity timeout fires.

This PR fixes both issues.

It also slightly reworks when we send workspace updates based on connection and disconnection. Previously we would send two updates when the agent connected in certain circumstances, even though the status would be the same in both (only times changed).  Now we universally only send one on connect, and then another on disconnect.

2025-12-15 12:04:01 +04:00

..

agentapi

feat: add flag to disable template insights (#20940)

2025-12-14 03:00:03 +00:00

agentmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

aibridge

feat(coderd): add overload protection with rate limiting and concurrency control (#21161)

2025-12-11 16:38:54 +01:00

apidoc

feat: add flag to disable template insights (#20940)

2025-12-14 03:00:03 +00:00

apikey

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

appearance

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

audit

feat(coderd): add audit resource for tasks (#20301)

2025-10-15 16:13:59 +00:00

autobuild

chore: promote tasks to stable from experimental (#20921)

2025-11-25 15:24:25 +00:00

awsidentity

fix: add new aws regions to instance identity (#10434)

2023-10-30 19:44:29 +00:00

azureidentity

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderdtest

chore: log with %s on unexpected non-sdk err (#20570)

2025-10-30 10:23:52 -08:00

connectionlog

fix: avoid connection logging crashes in agent (#20307)

2025-10-16 01:56:43 +11:00

cryptokeys

chore: update to coder/quartz v0.2.0 (#18007)

2025-05-27 16:05:03 +04:00

database

fix(coderd/database): sort template version variables and fix test flake (#21233)

2025-12-12 11:41:46 +00:00

devtunnel

fix: fixes use of possibly nil RemoteAddr() and LocalAddr() return values (#21076)

2025-12-03 15:06:00 +04:00

dynamicparameters

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

entitlements

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

externalauth

fix: add default value for RevokeURL property in external auth config for GitHub (#20272)

2025-10-14 09:28:10 +02:00

files

fix: remove hold WaitGroup in TestConcurrentFetch (#19617)

2025-09-03 09:25:49 +04:00

gitsshkey

…

healthcheck

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

httpapi

chore: bring back x-auth-checks with a length limit (#19928)

2025-09-24 10:46:50 -06:00

httpmw

feat(coderd): add overload protection with rate limiting and concurrency control (#21161)

2025-12-11 16:38:54 +01:00

idpsync

feat: add view workspace button to app error page (#20960)

2025-12-08 14:16:00 -09:00

jobreaper

fix: allow unhanger to unhang dormant workspaces (#20229)

2025-10-09 17:33:57 +11:00

jwtutils

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

mcp

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

metricscache

perf: don't calculate build times for deleted templates (#21072)

2025-12-04 10:27:56 -08:00

notifications

chore: remove references to dbtestutil.WillUsePostgres (#20436)

2025-10-23 14:24:54 +02:00

oauth2provider

feat: add view workspace button to app error page (#20960)

2025-12-08 14:16:00 -09:00

oauthpki

fix(coderd): support string type for oidc response's expires_in json property (#20152)

2025-10-15 17:37:37 +00:00

portsharing

fix: properly convert max port share level for oss (#13261)

2024-05-13 14:37:51 -04:00

pproflabel

chore: add usage tracking package (#19095)

2025-08-16 01:31:00 +10:00

prebuilds

feat: add prebuild invalidation via last_invalidated_at timestamp (#20582)

2025-11-20 17:12:25 +01:00

prometheusmetrics

test: fix TestDescCacheTimestampUpdate flake (#20975)

2025-12-02 10:53:36 +11:00

promoauth

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

provisionerdserver

fix: handle scenario where provisionerdserver deletes task before coderd (#21220)

2025-12-11 13:04:13 +00:00

provisionerkey

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

proxyhealth

feat: add csp headers for embedded apps (#18374)

2025-06-17 09:00:32 -08:00

pubsub

feat(coderd): add inbox notifications endpoints (#16889)

2025-03-18 00:02:47 +01:00

rbac

feat: add deployment-wide option to disable workspace sharing (#21172)

2025-12-09 08:13:09 -08:00

render

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

runtimeconfig

chore(coderd/runtimeconfig): remove dbmem from tests (#18790)

2025-07-08 14:31:05 +00:00

schedule

chore: improve build deadline code (#19203)

2025-08-07 11:00:31 +10:00

searchquery

feat(coderd): use task data model for list (#20394)

2025-10-23 20:22:51 +03:00

taskname

fix: improve task naming prompt to avoid URL content guessing (#21151)

2025-12-09 09:10:54 -06:00

telemetry

chore(docs): standardize "AIBridge" to "AI Bridge" in documentation (#20831)

2025-11-24 18:09:04 +05:00

testdata

feat: add flag to disable template insights (#20940)

2025-12-14 03:00:03 +00:00

tracing

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck

chore(coderd/updatecheck): remove dbmem from tests (#18792)

2025-07-08 14:32:46 +00:00

usage

chore: add unknown usage event type error (#19436)

2025-08-22 16:32:35 +10:00

userpassword

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util

chore: append template metadata to protobuf config (#20558)

2025-11-12 12:46:39 -06:00

webpush

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

workspaceapps

feat: add view workspace button to app error page (#20960)

2025-12-08 14:16:00 -09:00

workspacestats

feat: add flag to disable template insights (#20940)

2025-12-14 03:00:03 +00:00

wsbuilder

fix: allow stops and deletes after breaching AI limit (#21186)

2025-12-09 11:05:12 +00:00

wspubsub

feat: add app status tracking to the backend (#17163)

2025-03-31 10:55:44 -04:00

activitybump_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

aitasks_internal_test.go

fix: set codersdk.Task current_state during task initialization (#20692)

2025-11-17 13:24:12 +00:00

aitasks_test.go

test: close provisioner before creating workspace build (#21219)

2025-12-11 13:36:33 +00:00

aitasks.go

fix: handle scenario where provisionerdserver deletes task before coderd (#21220)

2025-12-11 13:04:13 +00:00

apikey_scopes_validation_test.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

apikey_test.go

feat: add allow list to API keys (#19972)

2025-10-24 12:33:56 +01:00

apikey.go

feat: add allow_list to resource-scoped API tokens (#19964)

2025-10-09 14:53:08 +02:00

apiroot.go

…

audit_internal_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit_test.go

chore: mark workspace apps and workspace agents as unaudited (#18761)

2025-07-15 16:08:42 +10:00

audit.go

fix(coderd): fix audit log resource link for tasks (#20545)

2025-10-29 15:31:41 +00:00

authorize_test.go

feat: add an organization member permission level (#19953)

2025-10-27 17:14:16 -06:00

authorize.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

client_test.go

…

coderd_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderd_test.go

chore(testutil): add testutil.GoleakOptions (#16070)

2025-01-08 15:38:37 +00:00

coderd.go

feat: add flag to disable template insights (#20940)

2025-12-14 03:00:03 +00:00

csp.go

…

debug_test.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

debug.go

feat: mount pprof and metrics to /api/v2/debug for admins (#20353)

2025-10-21 03:13:11 +00:00

deployment_test.go

fix(coderd): mark provisioner daemon psk as secret (#12322)

2024-02-27 16:33:32 +00:00

deployment.go

chore: remove chats experiment (#18535)

2025-06-25 13:03:32 +00:00

deprecated.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

experiments_test.go

chore: revert dynamic params as a safe experiment (#17510)

2025-04-22 16:21:15 +00:00

experiments.go

fix: do not warn on valid known experiments (#18514)

2025-06-24 09:14:41 +01:00

externalauth_test.go

feat: add best effort attempt to revoke oauth access token in external auth provider (#19775)

2025-09-19 16:27:02 +02:00

externalauth.go

feat: add best effort attempt to revoke oauth access token in external auth provider (#19775)

2025-09-19 16:27:02 +02:00

files_test.go

ci: improve 'tfail in goroutine' ruleguard rule (#19682)

2025-09-04 14:28:29 +10:00

files.go

docs: document 200 OK response for upload file API when file exists (#21071)

2025-12-08 16:04:56 -06:00

gitsshkey_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

gitsshkey.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

inboxnotifications_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications.go

fix(coderd): fix panics by always checking for non-nil request logger (#18228)

2025-06-12 13:50:50 +03:00

initscript_test.go

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

initscript.go

feat(coderd): add support for external agents to API's and provisioner (#19286)

2025-08-19 10:41:33 +02:00

insights_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights_test.go

feat: add flag to disable template insights (#20940)

2025-12-14 03:00:03 +00:00

insights.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

latencycheck.go

…

mcp_http.go

chore: refactor cli and coderd to use ClientOptions (#19763)

2025-09-22 21:02:56 +04:00

members_test.go

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

members.go

feat(coderd): add ability to search org members by user_id, is_system, github_user_id (#20048)

2025-09-30 23:54:21 +01:00

notifications_test.go

feat: support custom notifications (#19751)

2025-09-11 15:08:57 +02:00

notifications.go

feat: support custom notifications (#19751)

2025-09-11 15:08:57 +02:00

oauth2_error_compliance_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_metadata_test.go

fix: remove initial global HTTP client usage (#20128)

2025-10-02 11:43:13 -06:00

oauth2_metadata_validation_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_security_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_test.go

chore!: ensure consistent secret token generation and hashing (#20388)

2025-10-23 15:38:49 -05:00

oauth2.go

feat: implement oauth2 RFC 7009 token revocation endpoint (#20362)

2025-10-22 15:18:42 -05:00

organizations_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organizations.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

pagination_test.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

pagination.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

parameters_test.go

feat: make dynamic parameters opt-in by default for new templates (#19006)

2025-07-28 20:41:49 -05:00

parameters.go

fix: add heartbeat to keep dynamic params websocket open (#20026)

2025-10-02 09:32:40 -05:00

presets_test.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

presets.go

feat: support icon and description in preset (#18977)

2025-07-28 15:02:26 +01:00

provisionerdaemons_test.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisionerdaemons.go

feat: add filtering options to provisioners list (#19378)

2025-08-21 16:03:34 -04:00

provisionerjobs_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs_test.go

chore: fix api param name (#20172)

2025-10-06 13:58:37 +02:00

provisionerjobs.go

chore: fix api param name (#20172)

2025-10-06 13:58:37 +02:00

roles_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

roles.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

scopes_catalog_api_test.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

scopes_catalog.go

feat: add external API key scopes (#19916)

2025-09-26 11:43:32 +02:00

tailnet_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

tailnet.go

feat: add view workspace button to app error page (#20960)

2025-12-08 14:16:00 -09:00

templates_test.go

chore: remove references to dbtestutil.WillUsePostgres (#20436)

2025-10-23 14:24:54 +02:00

templates.go

chore: per template opt into cached terraform directories (#20609)

2025-11-13 14:04:12 -06:00

templateversions_test.go

chore: remove references to dbtestutil.WillUsePostgres (#20436)

2025-10-23 14:24:54 +02:00

templateversions.go

chore: append template metadata to protobuf config (#20558)

2025-11-12 12:46:39 -06:00

updatecheck_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck.go

…

userauth_test.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

userauth.go

chore: add custom samesite options to auth cookies (#16885)

2025-04-08 14:15:14 -05:00

users_test.go

feat: add notification warning alert to Tasks page (#20900)

2025-11-28 16:50:59 +00:00

users.go

feat: add notification warning alert to Tasks page (#20900)

2025-11-28 16:50:59 +00:00

webpush_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

webpush.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

workspaceagentportshare_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

workspaceagentportshare.go

docs: fix swagger documentation for DELETE port share endpoint (#18426)

2025-06-18 14:07:53 +00:00

workspaceagents_internal_test.go

fix(coderd): ensure agent WebSocket conn is cleaned up (#19711)

2025-09-05 14:26:46 +01:00

workspaceagents_test.go

fix: mock Agent querying OS for listening ports in tests (#20842)

2025-11-25 14:25:24 +04:00

workspaceagents.go

perf(coderd/database): limit GetLatestWorkspaceAppStatusByAppID to 1 row (#20917)

2025-11-25 16:56:42 +02:00

workspaceagentsrpc_internal_test.go

fix: stop disconnecting from coderd early and record disconnect correctly (#21250)

2025-12-15 12:04:01 +04:00

workspaceagentsrpc_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

workspaceagentsrpc.go

fix: stop disconnecting from coderd early and record disconnect correctly (#21250)

2025-12-15 12:04:01 +04:00

workspaceapps_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

workspaceapps.go

feat: add multi-scope support to API keys (#19917)

2025-09-26 11:56:34 +02:00

workspacebuilds_test.go

fix(coderd): disallow POSTing a workspace build on a deleted workspace (#20584)

2025-10-30 13:32:18 +00:00

workspacebuilds.go

fix(coderd): remove deprecated AITaskSidebarApp column (#20680)

2025-11-07 12:45:45 +02:00

workspaceproxies_test.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceproxies.go

fix: allow ports in wildcard url configuration (#11657)

2024-01-18 09:44:05 -06:00

workspaceresourceauth_test.go

chore: refactor instance identity to be a SessionTokenProvider (#19566)

2025-09-03 10:38:42 +04:00

workspaceresourceauth.go

…

workspaces_test.go

feat: add deployment-wide option to disable workspace sharing (#21172)

2025-12-09 08:13:09 -08:00

workspaces.go

fix(coderd): exclude sub-agents from workspace health calculation (#21098)

2025-12-04 15:38:24 +02:00

workspaceupdates_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceupdates.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00