mirror of
https://github.com/coder/coder.git
synced 2026-06-03 13:08:25 +00:00
741af057dc
Adds cursor-based pagination to the chat messages endpoint. ## Backend - New `GetChatMessagesByChatIDPaginated` SQL query: returns messages in `id DESC` order with a `before_id` keyset cursor and configurable `limit` - Handler parses `?before_id=N&limit=N` query params, uses the `LIMIT N+1` trick to set `has_more` without a separate COUNT query - Queued messages only returned on the first page (no cursor) since they're always the most recent - SDK client updated with `ChatMessagesPaginationOptions` - Fully backward compatible: omitting params returns the 50 newest messages ## Frontend - Switches `getChatMessages` from `useQuery` to `useInfiniteQuery` with cursor chaining via `getNextPageParam` - Pages flattened and sorted by `id` ascending for chronological display - `MessagesPaginationSentinel` component uses `IntersectionObserver` (200px rootMargin prefetch) inside the existing `flex-col-reverse` scroll container - `flex-col-reverse` handles scroll anchoring natively when older messages are prepended — no manual `scrollTop` adjustment needed (same pattern as coder/blink) ## Why cursor-based instead of offset/limit Offset-based pagination breaks when new messages arrive while paginating backward (offsets shift, causing duplicates or missed messages). The `before_id` cursor is stable regardless of inserts — each page is deterministic.
283 lines
9.0 KiB
Go
283 lines
9.0 KiB
Go
package chatd_test
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/coderd/coderdtest"
|
|
"github.com/coder/coder/v2/coderd/util/ptr"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/coder/v2/testutil"
|
|
)
|
|
|
|
// TestAnthropicWebSearchRoundTrip is an integration test that verifies
|
|
// provider-executed tool results (web_search) survive the full
|
|
// persist → reconstruct → re-send cycle. It sends a query that
|
|
// triggers Anthropic's web_search server tool, waits for completion,
|
|
// then sends a follow-up message. If the PE tool result was lost or
|
|
// corrupted during persistence, Anthropic rejects the second request:
|
|
//
|
|
// web_search tool use with id srvtoolu_... was found without a
|
|
// corresponding web_search_tool_result block
|
|
//
|
|
// The test requires ANTHROPIC_API_KEY to be set.
|
|
func TestAnthropicWebSearchRoundTrip(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
apiKey := os.Getenv("ANTHROPIC_API_KEY")
|
|
if apiKey == "" {
|
|
t.Skip("ANTHROPIC_API_KEY not set; skipping Anthropic integration test")
|
|
}
|
|
baseURL := os.Getenv("ANTHROPIC_BASE_URL")
|
|
|
|
ctx := testutil.Context(t, testutil.WaitSuperLong)
|
|
|
|
// Stand up a full coderd with the agents experiment.
|
|
deploymentValues := coderdtest.DeploymentValues(t)
|
|
deploymentValues.Experiments = []string{string(codersdk.ExperimentAgents)}
|
|
client := coderdtest.New(t, &coderdtest.Options{
|
|
DeploymentValues: deploymentValues,
|
|
})
|
|
_ = coderdtest.CreateFirstUser(t, client)
|
|
|
|
// Configure an Anthropic provider with the real API key.
|
|
_, err := client.CreateChatProvider(ctx, codersdk.CreateChatProviderConfigRequest{
|
|
Provider: "anthropic",
|
|
APIKey: apiKey,
|
|
BaseURL: baseURL,
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
// Create a model config that enables web_search.
|
|
contextLimit := int64(200000)
|
|
isDefault := true
|
|
_, err = client.CreateChatModelConfig(ctx, codersdk.CreateChatModelConfigRequest{
|
|
Provider: "anthropic",
|
|
Model: "claude-sonnet-4-20250514",
|
|
ContextLimit: &contextLimit,
|
|
IsDefault: &isDefault,
|
|
ModelConfig: &codersdk.ChatModelCallConfig{
|
|
ProviderOptions: &codersdk.ChatModelProviderOptions{
|
|
Anthropic: &codersdk.ChatModelAnthropicProviderOptions{
|
|
WebSearchEnabled: ptr.Ref(true),
|
|
},
|
|
},
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
// --- Step 1: Send a message that triggers web_search ---
|
|
t.Log("Creating chat with web search query...")
|
|
chat, err := client.CreateChat(ctx, codersdk.CreateChatRequest{
|
|
Content: []codersdk.ChatInputPart{
|
|
{
|
|
Type: codersdk.ChatInputPartTypeText,
|
|
Text: "What is the current weather in San Francisco right now? Use web search to find out.",
|
|
},
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
t.Logf("Chat created: %s (status=%s)", chat.ID, chat.Status)
|
|
|
|
// Stream events until the chat reaches a terminal status.
|
|
events, closer, err := client.StreamChat(ctx, chat.ID, nil)
|
|
require.NoError(t, err)
|
|
defer closer.Close()
|
|
|
|
waitForChatDone(ctx, t, events, "step 1")
|
|
|
|
// Verify the chat completed and messages were persisted.
|
|
chatData, err := client.GetChat(ctx, chat.ID)
|
|
require.NoError(t, err)
|
|
chatMsgs, err := client.GetChatMessages(ctx, chat.ID, nil)
|
|
require.NoError(t, err)
|
|
t.Logf("Chat status after step 1: %s, messages: %d",
|
|
chatData.Status, len(chatMsgs.Messages))
|
|
logMessages(t, chatMsgs.Messages)
|
|
|
|
require.Equal(t, codersdk.ChatStatusWaiting, chatData.Status,
|
|
"chat should be in waiting status after step 1")
|
|
|
|
// Find the first assistant message and verify it has the
|
|
// content parts the UI needs to render web search results:
|
|
// tool-call(PE), source, tool-result(PE), and text.
|
|
assistantMsg := findAssistantWithText(t, chatMsgs.Messages)
|
|
require.NotNil(t, assistantMsg,
|
|
"expected an assistant message with text content after step 1")
|
|
|
|
partTypes := partTypeSet(assistantMsg.Content)
|
|
require.Contains(t, partTypes, codersdk.ChatMessagePartTypeToolCall,
|
|
"assistant message should contain a PE tool-call part")
|
|
require.Contains(t, partTypes, codersdk.ChatMessagePartTypeSource,
|
|
"assistant message should contain source parts for UI citations")
|
|
require.Contains(t, partTypes, codersdk.ChatMessagePartTypeToolResult,
|
|
"assistant message should contain a PE tool-result part")
|
|
require.Contains(t, partTypes, codersdk.ChatMessagePartTypeText,
|
|
"assistant message should contain a text part")
|
|
|
|
// Verify the PE tool-call is marked as provider-executed.
|
|
for _, part := range assistantMsg.Content {
|
|
if part.Type == codersdk.ChatMessagePartTypeToolCall {
|
|
require.True(t, part.ProviderExecuted,
|
|
"web_search tool-call should be provider-executed")
|
|
break
|
|
}
|
|
}
|
|
|
|
// --- Step 2: Send a follow-up message ---
|
|
// This is the critical test: if PE tool results were lost during
|
|
// persistence, the reconstructed conversation will be rejected
|
|
// by Anthropic because server_tool_use has no matching
|
|
// web_search_tool_result.
|
|
t.Log("Sending follow-up message...")
|
|
_, err = client.CreateChatMessage(ctx, chat.ID,
|
|
codersdk.CreateChatMessageRequest{
|
|
Content: []codersdk.ChatInputPart{
|
|
{
|
|
Type: codersdk.ChatInputPartTypeText,
|
|
Text: "Thanks! What about New York?",
|
|
},
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
// Stream the follow-up response.
|
|
events2, closer2, err := client.StreamChat(ctx, chat.ID, nil)
|
|
require.NoError(t, err)
|
|
defer closer2.Close()
|
|
|
|
waitForChatDone(ctx, t, events2, "step 2")
|
|
|
|
// Verify the follow-up completed and produced content.
|
|
chatData2, err := client.GetChat(ctx, chat.ID)
|
|
require.NoError(t, err)
|
|
chatMsgs2, err := client.GetChatMessages(ctx, chat.ID, nil)
|
|
require.NoError(t, err)
|
|
t.Logf("Chat status after step 2: %s, messages: %d",
|
|
chatData2.Status, len(chatMsgs2.Messages))
|
|
logMessages(t, chatMsgs2.Messages)
|
|
|
|
require.Equal(t, codersdk.ChatStatusWaiting, chatData2.Status,
|
|
"chat should be in waiting status after step 2")
|
|
require.Greater(t, len(chatMsgs2.Messages), len(chatMsgs.Messages),
|
|
"follow-up should have added more messages")
|
|
|
|
// The last assistant message should have text.
|
|
lastAssistant := findLastAssistantWithText(t, chatMsgs2.Messages)
|
|
require.NotNil(t, lastAssistant,
|
|
"expected an assistant message with text in the follow-up")
|
|
|
|
t.Log("Anthropic web_search round-trip test passed.")
|
|
}
|
|
|
|
// waitForChatDone drains the event stream until the chat reaches
|
|
// a terminal status (waiting, completed, or error).
|
|
func waitForChatDone(
|
|
ctx context.Context,
|
|
t *testing.T,
|
|
events <-chan codersdk.ChatStreamEvent,
|
|
label string,
|
|
) {
|
|
t.Helper()
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
require.FailNow(t, "timed out waiting for "+label+" completion")
|
|
case event, ok := <-events:
|
|
if !ok {
|
|
return
|
|
}
|
|
switch event.Type {
|
|
case codersdk.ChatStreamEventTypeError:
|
|
if event.Error != nil {
|
|
t.Logf("[%s] stream error: %s", label, event.Error.Message)
|
|
}
|
|
case codersdk.ChatStreamEventTypeStatus:
|
|
if event.Status != nil {
|
|
t.Logf("[%s] status → %s", label, event.Status.Status)
|
|
switch event.Status.Status {
|
|
case codersdk.ChatStatusWaiting,
|
|
codersdk.ChatStatusCompleted:
|
|
return
|
|
case codersdk.ChatStatusError:
|
|
require.FailNow(t, label+" ended with error status")
|
|
}
|
|
}
|
|
case codersdk.ChatStreamEventTypeMessage:
|
|
if event.Message != nil {
|
|
t.Logf("[%s] persisted message: role=%s parts=%d",
|
|
label, event.Message.Role, len(event.Message.Content))
|
|
}
|
|
case codersdk.ChatStreamEventTypeMessagePart:
|
|
// Streaming delta — just note it.
|
|
if event.MessagePart != nil {
|
|
t.Logf("[%s] part: type=%s",
|
|
label, event.MessagePart.Part.Type)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// findAssistantWithText returns the first assistant message that
|
|
// contains a non-empty text part.
|
|
func findAssistantWithText(t *testing.T, msgs []codersdk.ChatMessage) *codersdk.ChatMessage {
|
|
t.Helper()
|
|
for i := range msgs {
|
|
if msgs[i].Role != "assistant" {
|
|
continue
|
|
}
|
|
for _, part := range msgs[i].Content {
|
|
if part.Type == codersdk.ChatMessagePartTypeText && part.Text != "" {
|
|
return &msgs[i]
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// findLastAssistantWithText returns the last assistant message that
|
|
// contains a non-empty text part.
|
|
func findLastAssistantWithText(t *testing.T, msgs []codersdk.ChatMessage) *codersdk.ChatMessage {
|
|
t.Helper()
|
|
for i := len(msgs) - 1; i >= 0; i-- {
|
|
if msgs[i].Role != "assistant" {
|
|
continue
|
|
}
|
|
for _, part := range msgs[i].Content {
|
|
if part.Type == codersdk.ChatMessagePartTypeText && part.Text != "" {
|
|
return &msgs[i]
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// logMessages prints a summary of all messages for debugging.
|
|
func logMessages(t *testing.T, msgs []codersdk.ChatMessage) {
|
|
t.Helper()
|
|
for i, msg := range msgs {
|
|
types := make([]string, 0, len(msg.Content))
|
|
for _, part := range msg.Content {
|
|
s := string(part.Type)
|
|
if part.ProviderExecuted {
|
|
s += "(PE)"
|
|
}
|
|
types = append(types, s)
|
|
}
|
|
t.Logf(" msg[%d] role=%s parts=%v", i, msg.Role, types)
|
|
}
|
|
}
|
|
|
|
// partTypeSet returns the set of part types present in a message.
|
|
func partTypeSet(parts []codersdk.ChatMessagePart) map[codersdk.ChatMessagePartType]struct{} {
|
|
set := make(map[codersdk.ChatMessagePartType]struct{}, len(parts))
|
|
for _, p := range parts {
|
|
set[p.Type] = struct{}{}
|
|
}
|
|
return set
|
|
}
|