Danielle Maywood f751f81052 fix(coderd): fix flake in TestAPI/ModifyAutostopWithRunningWorkspace (#18932) ...

Fixes https://github.com/coder/internal/issues/521

This happened due to a race condition present in how
`AwaitWorkspaceBuildJobCompleted` works.

`AwaitWorkspaceBuildJobCompleted` works by waiting until
`/api/v2/workspacesbuilds/{workspacebuild}/` returns a workspace build
with `.Job.CompletedAt != nil`. The issue here is that _sometimes_ the
returned `codersdk.WorkspaceBuild` can contain a build from _before_ a
provisioner job completed, but contain the provisioner job from _after_
it completed.

Let me demonstrate:

Here we query the database for `database.WorkspaceBuild`.

https://github.com/coder/coder/blob/a3f64f74f794c733126ad21cd1feb0801caf67c4/coderd/coderd.go#L1409-L1415

Inside of the `workspaceBuild` route handler, we call
`workspaceBuildsData`

https://github.com/coder/coder/blob/a3f64f74f794c733126ad21cd1feb0801caf67c4/coderd/workspacebuilds.go#L54

This then calls `GetProvisionerJobsByIDsWithQueuePosition`

https://github.com/coder/coder/blob/a3f64f74f794c733126ad21cd1feb0801caf67c4/coderd/workspacebuilds.go#L852-L856

As these two calls happen _outside of a transaction_, the state of the
world can change underneath. This can result in an in-progress workspace
build having a completed provisioner job attached to it.

2025-07-21 13:04:28 +01:00

..

agentapi

chore!: route connection logs to new table (#18340)

2025-07-15 14:36:06 +10:00

agentmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

apidoc

chore: add managed_agent_limit licensing feature (#18876)

2025-07-17 20:19:01 +10:00

apikey

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

appearance

fix: make cli respect deployment --docs-url (#14568)

2024-09-18 21:47:53 +10:00

audit

chore: mark workspace apps and workspace agents as unaudited (#18761)

2025-07-15 16:08:42 +10:00

autobuild

fix: exclude prebuilt workspaces from lifecycle executor (#18762)

2025-07-08 11:35:28 +01:00

awsidentity

…

azureidentity

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderdtest

refactor: simplify OAuth2 authorization flow and use 302 redirects (#18923)

2025-07-20 16:22:52 +02:00

connectionlog

chore!: route connection logs to new table (#18340)

2025-07-15 14:36:06 +10:00

cryptokeys

chore: update to coder/quartz v0.2.0 (#18007)

2025-05-27 16:05:03 +04:00

database

chore: mark workspace apps and workspace agents as unaudited (#18761)

2025-07-15 16:08:42 +10:00

devtunnel

chore: disable devtunnel tests on windows (#18521)

2025-06-24 19:01:29 +10:00

dynamicparameters

chore: modify parameter dynamic immutability behavior (#18583)

2025-07-09 08:45:24 -06:00

entitlements

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

externalauth

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

files

chore: support zip filetypes in the file cache (#18750)

2025-07-08 15:46:39 -06:00

gitsshkey

…

healthcheck

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

httpapi

chore: create interface for pkgs to return codersdk errors (#18719)

2025-07-03 08:33:45 -05:00

httpmw

feat: add RFC 9728 OAuth2 resource metadata support (#18920)

2025-07-19 22:05:15 +02:00

idpsync

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

jobreaper

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

jwtutils

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

mcp

feat: implement MCP HTTP server endpoint with authentication (#18670)

2025-07-03 19:27:41 +02:00

metricscache

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

notifications

chore: remove dbmem (#18803)

2025-07-09 09:46:31 +02:00

oauth2provider

refactor: simplify OAuth2 authorization flow and use 302 redirects (#18923)

2025-07-20 16:22:52 +02:00

oauthpki

fix: stop extending API key access if OIDC refresh is available (#17878)

2025-05-19 12:05:35 +04:00

portsharing

…

prebuilds

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

prometheusmetrics

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

promoauth

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerdserver

feat: persist AI task state in template imports & workspace builds (#18449)

2025-06-24 10:36:37 +00:00

provisionerkey

chore: shorten provisioner key (#14017)

2024-07-25 16:08:12 -05:00

proxyhealth

feat: add csp headers for embedded apps (#18374)

2025-06-17 09:00:32 -08:00

pubsub

feat(coderd): add inbox notifications endpoints (#16889)

2025-03-18 00:02:47 +01:00

rbac

chore!: route connection logs to new table (#18340)

2025-07-15 14:36:06 +10:00

render

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

runtimeconfig

chore(coderd/runtimeconfig): remove dbmem from tests (#18790)

2025-07-08 14:31:05 +00:00

schedule

fix: exclude prebuilt workspaces from lifecycle executor (#18762)

2025-07-08 11:35:28 +01:00

searchquery

chore: populate connectionlog count using a separate query (#18629)

2025-07-15 15:03:30 +10:00

telemetry

feat: graduate prebuilds to general availability (#18607)

2025-06-26 15:54:52 +02:00

testdata

feat: implement dynamic parameter validation (#18482)

2025-06-23 12:35:15 -05:00

tracing

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck

chore(coderd/updatecheck): remove dbmem from tests (#18792)

2025-07-08 14:32:46 +00:00

userpassword

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

util

feat: implement dynamic parameter validation (#18482)

2025-06-23 12:35:15 -05:00

webpush

chore: remove unnecessary redeclarations in for loops (part 2) (#18593)

2025-06-26 12:28:00 -06:00

workspaceapps

chore!: route connection logs to new table (#18340)

2025-07-15 14:36:06 +10:00

workspacestats

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

wsbuilder

feat: use preview to compute workspace tags from terraform (#18720)

2025-07-03 14:35:44 -05:00

wspubsub

feat: add app status tracking to the backend (#17163)

2025-03-31 10:55:44 -04:00

activitybump_test.go

chore: add standard test logger ignoring db canceled (#15556)

2024-11-18 14:09:22 +04:00

aitasks_test.go

feat: add the /aitasks/prompts endpoint (#18464)

2025-06-24 13:06:02 +02:00

aitasks.go

feat: add the /aitasks/prompts endpoint (#18464)

2025-06-24 13:06:02 +02:00

apikey_test.go

feat: add separate max token lifetime for administrators (#18267)

2025-06-06 17:36:30 +02:00

apikey.go

feat: add separate max token lifetime for administrators (#18267)

2025-06-06 17:36:30 +02:00

apiroot.go

…

audit_internal_test.go

chore: add sql filter to fetching audit logs (#14070)

2024-08-01 12:07:19 -05:00

audit_test.go

chore: mark workspace apps and workspace agents as unaudited (#18761)

2025-07-15 16:08:42 +10:00

audit.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

authorize_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

authorize.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

client_test.go

…

coderd_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

coderd_test.go

chore(testutil): add testutil.GoleakOptions (#16070)

2025-01-08 15:38:37 +00:00

coderd.go

feat: add RFC 9728 OAuth2 resource metadata support (#18920)

2025-07-19 22:05:15 +02:00

csp.go

…

debug_test.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

debug.go

chore(cli): increase healthcheck timeout in TestSupportbundle (#17291)

2025-04-09 09:21:17 +01:00

deployment_test.go

…

deployment.go

chore: remove chats experiment (#18535)

2025-06-25 13:03:32 +00:00

deprecated.go

chore!: remove deprecated agent v1 routes (#13486)

2024-06-11 12:22:59 +10:00

experiments_test.go

chore: revert dynamic params as a safe experiment (#17510)

2025-04-22 16:21:15 +00:00

experiments.go

fix: do not warn on valid known experiments (#18514)

2025-06-24 09:14:41 +01:00

externalauth_test.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

externalauth.go

fix: limit OAuth redirects to local paths (#14585)

2024-09-10 15:58:50 +01:00

files_test.go

fix: support windows specific zip mime type for template uploads (#15442)

2024-11-08 18:24:12 +11:00

files.go

fix: support windows specific zip mime type for template uploads (#15442)

2024-11-08 18:24:12 +11:00

gitsshkey_test.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

gitsshkey.go

feat: add API key scope to restrict access to user data (#17692)

2025-05-15 15:32:52 +01:00

inboxnotifications_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

inboxnotifications.go

fix(coderd): fix panics by always checking for non-nil request logger (#18228)

2025-06-12 13:50:50 +03:00

insights_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

insights.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00

latencycheck.go

…

mcp_http.go

feat: implement MCP HTTP server endpoint with authentication (#18670)

2025-07-03 19:27:41 +02:00

members_test.go

chore: update error message for duplicate organization members (#17594)

2025-04-28 14:51:33 -06:00

members.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

notifications_test.go

feat(coderd): add new dispatch logic for coder inbox (#16764)

2025-03-05 22:43:18 +01:00

notifications.go

feat(coderd): add new dispatch logic for coder inbox (#16764)

2025-03-05 22:43:18 +01:00

oauth2_error_compliance_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_metadata_test.go

feat: implement RFC 6750 Bearer token authentication (#18644)

2025-07-02 19:14:54 +02:00

oauth2_metadata_validation_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_security_test.go

feat: implement OAuth2 dynamic client registration (RFC 7591/7592) (#18645)

2025-07-03 18:33:47 +02:00

oauth2_test.go

refactor: organize OAuth2 provider tests into dedicated packages (#18747)

2025-07-03 20:41:47 +02:00

oauth2.go

refactor: simplify OAuth2 authorization flow and use 302 redirects (#18923)

2025-07-20 16:22:52 +02:00

organizations_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

organizations.go

chore: implement filters for the organizations query (#14468)

2024-08-28 13:24:28 -05:00

pagination_test.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

pagination.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

parameters_test.go

feat: use preview to compute workspace tags from terraform (#18720)

2025-07-03 14:35:44 -05:00

parameters.go

chore: refactor dynamic parameters into dedicated package (#18420)

2025-06-20 13:00:39 -05:00

presets_test.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

presets.go

feat: allow for default presets (#18445)

2025-06-24 12:19:19 +02:00

provisionerdaemons_test.go

fix: return provisioners in desc order and add limit to cli (#16720)

2025-02-26 21:06:51 +02:00

provisionerdaemons.go

feat(coderd/httpapi): add QueryParamParser.JSONStringMap (#16578)

2025-02-18 14:14:30 +00:00

provisionerjobs_internal_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

provisionerjobs_test.go

feat: add provisioner daemon name to provisioner jobs responses (#17877)

2025-05-19 16:05:39 +01:00

provisionerjobs.go

fix(coderd): fix panics by always checking for non-nil request logger (#18228)

2025-06-12 13:50:50 +03:00

roles_test.go

chore: protect organization endpoints with license (#14001)

2024-07-25 16:07:53 -05:00

roles.go

chore: ensure proper rbac permissions on 'Acquire' file in the cache (#18348)

2025-06-16 13:40:45 +00:00

tailnet_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

tailnet.go

fix: use client preferred URL for the default DERP (#18911)

2025-07-17 20:17:44 +10:00

templates_test.go

feat: support dynamic parameters on create template request (#18636)

2025-07-02 09:44:01 -05:00

templates.go

feat: support dynamic parameters on create template request (#18636)

2025-07-02 09:44:01 -05:00

templateversions_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

templateversions.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

updatecheck_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

updatecheck.go

…

userauth_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

userauth.go

chore: add custom samesite options to auth cookies (#16885)

2025-04-08 14:15:14 -05:00

users_test.go

chore: remove dbmem (#18803)

2025-07-09 09:46:31 +02:00

users.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

webpush_test.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

webpush.go

feat(coderd): add webpush package (#17091)

2025-03-27 10:03:53 +00:00

workspaceagentportshare_test.go

chore: join owner, template, and org in new workspace view (#15116)

2024-10-22 09:20:54 -05:00

workspaceagentportshare.go

docs: fix swagger documentation for DELETE port share endpoint (#18426)

2025-06-18 14:07:53 +00:00

workspaceagents_test.go

feat(site): use websocket connection for devcontainer updates (#18808)

2025-07-14 21:35:35 +01:00

workspaceagents.go

feat(site): use websocket connection for devcontainer updates (#18808)

2025-07-14 21:35:35 +01:00

workspaceagentsrpc_internal_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceagentsrpc_test.go

fix: remove unnecessary user lookup in agent API calls (#17934)

2025-05-20 17:07:50 +02:00

workspaceagentsrpc.go

chore!: route connection logs to new table (#18340)

2025-07-15 14:36:06 +10:00

workspaceapps_test.go

chore: remove unnecessary redeclarations in for loops (#18440)

2025-06-20 13:16:55 -06:00

workspaceapps.go

feat: enable key rotation (#15066)

2024-10-25 17:14:35 +01:00

workspacebuilds_test.go

chore: fix flake in TestWorkspaceBuildsProvisionerState (#18839)

2025-07-15 15:07:13 +10:00

workspacebuilds.go

feat: add connectionlogs API (#18628)

2025-07-15 14:55:34 +10:00

workspaceproxies_test.go

…

workspaceproxies.go

…

workspaceresourceauth_test.go

fix!: enforce regex for agent names (#16641)

2025-02-20 05:09:26 +00:00

workspaceresourceauth.go

…

workspaces_test.go

fix(coderd): fix flake in TestAPI/ModifyAutostopWithRunningWorkspace (#18932)

2025-07-21 13:04:28 +01:00

workspaces.go

fix(site): exclude workspace schedule settings for prebuilt workspaces (#18826)

2025-07-15 14:11:04 +01:00

workspaceupdates_test.go

chore: update testutil chan helpers (#17408)

2025-04-16 10:37:09 -06:00

workspaceupdates.go

chore: update golang to 1.24.1 (#17035)

2025-03-26 01:56:39 -05:00