Files
35C4n0r e8e3a4e642 feat(cmd/tests): update tests to fail on invalid and absolute urls (#639)
## Description
Updated the tests:
- We now don't accept absolute urls (http / https)
- We only accept urls that start with `../../../../.icons/*` and exists

<!-- Briefly describe what this PR does and why -->

## Type of Change

- [ ] New module
- [ ] New template
- [x] Bug fix
- [ ] Feature/enhancement
- [ ] Documentation
- [ ] Other

## Testing & Validation

- [x] Tests pass (`bun test`)
- [x] Code formatted (`bun fmt`)
- [x] Changes tested locally

---------

Co-authored-by: DevCats <christofer@coder.com>
2026-01-08 08:13:16 -06:00

118 lines
2.6 KiB
Go

package main
import (
"os"
"path/filepath"
"testing"
)
type readmeTestCase struct {
filePath string
shouldPass bool
}
func loadTestCases(t *testing.T, dir string, shouldPass bool) []readmeTestCase {
t.Helper()
files, err := os.ReadDir(dir)
if err != nil {
t.Fatalf("Failed to read directory %s: %v", dir, err)
}
var testCases []readmeTestCase
for _, file := range files {
testCases = append(testCases, readmeTestCase{
filePath: filepath.Join(dir, file.Name()),
shouldPass: shouldPass,
})
}
return testCases
}
func TestValidateModuleReadmes(t *testing.T) {
t.Parallel()
testCases := append(
loadTestCases(t, "testSamples/modules/pass", true),
loadTestCases(t, "testSamples/modules/fail", false)...,
)
for _, tc := range testCases {
t.Run(tc.filePath, func(t *testing.T) {
t.Parallel()
content, err := os.ReadFile(tc.filePath)
if err != nil {
t.Fatalf("Failed to read file: %v", err)
}
rm := readme{
filePath: tc.filePath,
rawText: string(content),
}
resource, errs := parseCoderResourceReadme("modules", rm)
if len(errs) != 0 {
if tc.shouldPass {
for _, e := range errs {
t.Errorf("Unexpected parsing error: %v", e)
}
}
return
}
validationErrs := validateCoderModuleReadme(resource)
if tc.shouldPass && len(validationErrs) != 0 {
for _, e := range validationErrs {
t.Errorf("Unexpected validation error: %v", e)
}
} else if !tc.shouldPass && len(validationErrs) == 0 {
t.Error("Expected validation errors but got none")
}
})
}
}
func TestValidateTemplateReadmes(t *testing.T) {
t.Parallel()
testCases := append(
loadTestCases(t, "testSamples/templates/pass", true),
loadTestCases(t, "testSamples/templates/fail", false)...,
)
for _, tc := range testCases {
t.Run(tc.filePath, func(t *testing.T) {
t.Parallel()
content, err := os.ReadFile(tc.filePath)
if err != nil {
t.Fatalf("Failed to read file: %v", err)
}
rm := readme{
filePath: tc.filePath,
rawText: string(content),
}
resource, errs := parseCoderResourceReadme("templates", rm)
if len(errs) != 0 {
if tc.shouldPass {
for _, e := range errs {
t.Errorf("Unexpected parsing error: %v", e)
}
}
return
}
validationErrs := validateCoderModuleReadme(resource)
if tc.shouldPass && len(validationErrs) != 0 {
for _, e := range validationErrs {
t.Errorf("Unexpected validation error: %v", e)
}
} else if !tc.shouldPass && len(validationErrs) == 0 {
t.Error("Expected validation errors but got none")
}
})
}
}